Re: ext3/ext4 fsync hack

2015-01-06 Thread Hallvard Breien Furuseth
On 01/06/2015 03:18 PM, Howard Chu wrote: Hallvard Breien Furuseth wrote: () If the new pages below mt_next_pgno were freed instead of written, me_size becomes too big. Huh? mt_next_pgno definitively tells how many pages have ever been used in the DB file. No, see ITS#7886: Allocate an

Re: ext3/ext4 fsync hack

2015-01-06 Thread Hallvard Breien Furuseth
Sorry, forgot this one. On 01/06/2015 03:18 PM, Howard Chu wrote: Hallvard Breien Furuseth wrote: Another issue: After an MDB_NOSYNC commit, mdb_env_sync() only fdatasync()s. It does not know when the file grew. I suppose we can change the FORCE flag to also cause fsync() to be used.

Re: ext3/ext4 fsync hack

2015-01-06 Thread Howard Chu
Hallvard Breien Furuseth wrote: On 18/12/14 05:40, openldap-commit2de...@openldap.org wrote: commit 0018eeb2c3b2239c30def9d47c9d194a4ebf35fe Author: Howard Chu h...@openldap.org Date: Thu Dec 18 04:38:53 2014 + Hack for potential ext3/ext4 corruption issue Use regular fsync()

ext3/ext4 fsync hack (was: openldap.git branch mdb.master updated. 0018eeb2c3b2239c30def9d47c9d194a4ebf35fe)

2014-12-24 Thread Hallvard Breien Furuseth
On 18/12/14 05:40, openldap-commit2de...@openldap.org wrote: commit 0018eeb2c3b2239c30def9d47c9d194a4ebf35fe Author: Howard Chu h...@openldap.org Date: Thu Dec 18 04:38:53 2014 + Hack for potential ext3/ext4 corruption issue Use regular fsync() if we think this commit grew the