When is it safe to leave sc_writewait uninitialized? The field
seems to have emerged in the middle of RE24, and I don't see any
flags which say it should/should not be used.
Since not setting it crashed back-relay in ITS#8428, does that
mean everything which creates a slap_callback should set
Hallvard Breien Furuseth wrote:
When is it safe to leave sc_writewait uninitialized? The field
seems to have emerged in the middle of RE24, and I don't see any
flags which say it should/should not be used.
Where would such flags reside?
Since not setting it crashed back-relay in ITS#8428,
Hallvard Breien Furuseth wrote:
Howard Chu wrote:
Hallvard Breien Furuseth wrote:
When is it safe to leave sc_writewait uninitialized? The field
seems to have emerged in the middle of RE24, and I don't see any
flags which say it should/should not be used.
Where would such flags reside?
I wrote:
> Oh, right... New problem, though: If a a third-party module sets
> sc_private in such an initializer, that now sets sc_writewait instead.
I mean, and old module which predates sc_writewait.
--
Hallvard
Hallvard Breien Furuseth wrote:
I wrote:
Oh, right... New problem, though: If a a third-party module sets
sc_private in such an initializer, that now sets sc_writewait instead.
I mean, and old module which predates sc_writewait.
Hm yeah, I suppose we could just move sc_writewait to the end