Re: Propose to MDB_PICKUP for mdb_dpi_open()

[Леонид Юрьев]

Ok, I will refine my changes.
Thanks.
30.04.2015 19:46 пользователь "Howard Chu"  написал:

> Леонид Юрьев wrote:
>
>> Hm, but how open dbi which some flags, ensure that are present?
>>
>> Same for  main-dbi without change stored flags?
>>
>
> If you want to verify which flags are present, use mdb_dbi_flags() to
> retrieve them after opening.
>
> This is why most of your posts meet negative responses - you attempt to
> make changes before understanding how the existing system works. That's not
> a good or productive approach to software development.
>
>  30.04.2015 19:16 пользователь "Howard Chu" > > написал:
>>
>> Леонид Юрьев wrote:
>>
>> Hi, Howard.
>>
>> I would like to introduce the MDB_PICKUP flag for mdb_dpi_open().
>> Please see
>>
>> https://github.com/ReOpen/ReOpenLDAP/commit/04f92c952e42ff4c843135c42fdb9aa4b70a34fe
>>
>> At least, this is required for mdb_chk tool, when a DBI should
>> be opened
>> with flags that stored inside LMDB, which while a DBI was
>> created. It is
>> particularly important for DBI_MAIN.
>>
>>
>> This flag is completely unnecessary. Opening an existing DBI with
>> flags=0 accomplishes that task already.
>>
>> --
>>-- Howard Chu
>>CTO, Symas Corp. http://www.symas.com
>>Director, Highland Sun http://highlandsun.com/hyc/
>>Chief Architect, OpenLDAP http://www.openldap.org/project/
>>
>>
>
> --
>   -- Howard Chu
>   CTO, Symas Corp.   http://www.symas.com
>   Director, Highland Sun http://highlandsun.com/hyc/
>   Chief Architect, OpenLDAP  http://www.openldap.org/project/
>

Re: Propose to MDB_PICKUP for mdb_dpi_open()

[Леонид Юрьев]

Hm, but how open dbi which some flags, ensure that are present?

Same for  main-dbi without change stored flags?
30.04.2015 19:16 пользователь "Howard Chu"  написал:

> Леонид Юрьев wrote:
>
>> Hi, Howard.
>>
>> I would like to introduce the MDB_PICKUP flag for mdb_dpi_open().
>> Please see
>>
>> https://github.com/ReOpen/ReOpenLDAP/commit/04f92c952e42ff4c843135c42fdb9aa4b70a34fe
>>
>> At least, this is required for mdb_chk tool, when a DBI should be opened
>> with flags that stored inside LMDB, which while a DBI was created. It is
>> particularly important for DBI_MAIN.
>>
>
> This flag is completely unnecessary. Opening an existing DBI with flags=0
> accomplishes that task already.
>
> --
>   -- Howard Chu
>   CTO, Symas Corp.   http://www.symas.com
>   Director, Highland Sun http://highlandsun.com/hyc/
>   Chief Architect, OpenLDAP  http://www.openldap.org/project/
>

Re: Propose to MDB_PICKUP for mdb_dpi_open()

[Howard Chu]

Леонид Юрьев wrote:

Hm, but how open dbi which some flags, ensure that are present?

Same for  main-dbi without change stored flags?


If you want to verify which flags are present, use mdb_dbi_flags() to 
retrieve them after opening.


This is why most of your posts meet negative responses - you attempt to 
make changes before understanding how the existing system works. That's 
not a good or productive approach to software development.



30.04.2015 19:16 пользователь "Howard Chu" mailto:h...@symas.com>> написал:

Леонид Юрьев wrote:

Hi, Howard.

I would like to introduce the MDB_PICKUP flag for mdb_dpi_open().
Please see

https://github.com/ReOpen/ReOpenLDAP/commit/04f92c952e42ff4c843135c42fdb9aa4b70a34fe

At least, this is required for mdb_chk tool, when a DBI should
be opened
with flags that stored inside LMDB, which while a DBI was
created. It is
particularly important for DBI_MAIN.


This flag is completely unnecessary. Opening an existing DBI with
flags=0 accomplishes that task already.

--
   -- Howard Chu
   CTO, Symas Corp. http://www.symas.com
   Director, Highland Sun http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP http://www.openldap.org/project/




--
  -- Howard Chu
  CTO, Symas Corp.   http://www.symas.com
  Director, Highland Sun http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/

Re: Propose to MDB_PICKUP for mdb_dpi_open()

[Howard Chu]

Леонид Юрьев wrote:

Hi, Howard.

I would like to introduce the MDB_PICKUP flag for mdb_dpi_open().
Please see
https://github.com/ReOpen/ReOpenLDAP/commit/04f92c952e42ff4c843135c42fdb9aa4b70a34fe

At least, this is required for mdb_chk tool, when a DBI should be opened
with flags that stored inside LMDB, which while a DBI was created. It is
particularly important for DBI_MAIN.


This flag is completely unnecessary. Opening an existing DBI with 
flags=0 accomplishes that task already.


--
  -- Howard Chu
  CTO, Symas Corp.   http://www.symas.com
  Director, Highland Sun http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/

Propose to MDB_PICKUP for mdb_dpi_open()

[Леонид Юрьев]

Hi, Howard.

I would like to introduce the MDB_PICKUP flag for mdb_dpi_open().
Please see
https://github.com/ReOpen/ReOpenLDAP/commit/04f92c952e42ff4c843135c42fdb9aa4b70a34fe

At least, this is required for mdb_chk tool, when a DBI should be opened
with flags that stored inside LMDB, which while a DBI was created. It is
particularly important for DBI_MAIN.

Leonid.