Re: (ITS#9017) Improving performance of commit sync in Windows

2020-02-20 Thread hyc
Howard Chu wrote: > There should be an off64_t type instead. > But it looks to me like only the env->me_size field could ever overflow, > and using size_t for that should be fine. The other uses are for the meta > page, which is always either offset 0 or > offset 4096 (with 4KB pagesize), and

RE: Re: (ITS#9017) Improving performance of commit sync in Windows

2020-02-18 Thread kriszyp
as.com;>Howard ChuSent: February = 18, 2020 8:15 AMTo: mailto:kris...@gmail.com;>Kris Zy= pCc: mailto:openldap-its@openldap.org;>openldap-i= t...@openldap.orgSubject: Re: (ITS#9017) Improving performance= of commit sync in Windows<= /p>Kris Zyp wrote: Yes, I= will work on upgrading

Re: (ITS#9017) Improving performance of commit sync in Windows

2020-02-18 Thread hyc
Kris Zyp wrote: > Yes, I will work on upgrading this patch to 1.0. >=20 > However, I believe in order to realize optimal Windows performance with= out regression/slow-downs, I will also need to disable the use of NTDLL (= and use direct > CreateFileMapping memory maps instead), as mentioned=C2=A0

Re: (ITS#9017) Improving performance of commit sync in Windows

2020-02-18 Thread kriszyp
--ce7c35059edab753 Content-Type: text/plain; charset="UTF-8" Yes, I will work on upgrading this patch to 1.0. However, I believe in order to realize optimal Windows performance without regression/slow-downs, I will also need to disable the use of NTDLL (and use direct

Re: (ITS#9017) Improving performance of commit sync in Windows

2020-02-17 Thread hyc
h...@symas.com wrote: > Kris Zyp wrote: >> Sorry to keep pestering, but just pinging about this patch again, as I still >> think this fix could benefit windows users. And at this point, I think I can >> say we >> have tested it pretty well, running on our servers for almost a year :). > > Looks

Re: (ITS#9017) Improving performance of commit sync in Windows

2020-02-17 Thread hyc
Kris Zyp wrote: > Sorry to keep pestering, but just pinging about this patch again, as I still > think this fix could benefit windows users. And at this point, I think I can > say we > have tested it pretty well, running on our servers for almost a year :). Looks like this patch is against the

Re: (ITS#9017) Improving performance of commit sync in Windows

2020-02-06 Thread kriszyp
;> >>> Thanks, >>> Kris >>> >>> >>> >>> *From: *Kris Zyp >>> *Sent: *April 30, 2019 12:43 PM >>> *To: *Howard Chu ; openldap-its@OpenLDAP.org >>> *Subject: *RE: (ITS#9017) Improving performance of commit sync in

Re: (ITS#9017) Improving performance of commit sync in Windows

2019-09-18 Thread kriszyp
back into the range of "lightning" >> performance :). >> >> >> >> What is the performance difference between your patch using writemap, an= d >> just >> >> not using writemap in the first place? >> >> >> >> -- >> &g

Re: (ITS#9017) Improving performance of commit sync in Windows

2019-06-17 Thread kriszyp
> *Sent: *April 30, 2019 12:43 PM > *To: *Howard Chu ; openldap-its@OpenLDAP.org > *Subject: *RE: (ITS#9017) Improving performance of commit sync in Windows > > > > > What is the point of using writemap mode if you still need to use > WriteFile > > > on every i

RE: (ITS#9017) Improving performance of commit sync in Windows

2019-05-03 Thread kriszyp
m; openldap-its@OpenLDAP.org Subject: Re: (ITS#9017) Improving performance of commit sync in Windows kris...@gmail.com wrote: > Full_Name: Kristopher William Zyp > Version: LMDB 0.9.23 > OS: Windows > URL: https://github.com/kriszyp/node-lmdb/commit/7ff525ae57684a163d32af74= a0ab9332b7fc4ce9

RE: (ITS#9017) Improving performance of commit sync in Windows

2019-04-30 Thread kriszyp
view!=20 Thanks, Kris From: Howard Chu Sent: April 30, 2019 7:12 AM To: kris...@gmail.com; openldap-its@OpenLDAP.org Subject: Re: (ITS#9017) Improving performance of commit sync in Windows kris...@gmail.com wrote: > Full_Name: Kristopher William Zyp > Version: LMDB 0.9.23 > OS: Windows > U

Re: (ITS#9017) Improving performance of commit sync in Windows

2019-04-30 Thread hyc
kris...@gmail.com wrote: > Full_Name: Kristopher William Zyp > Version: LMDB 0.9.23 > OS: Windows > URL: > https://github.com/kriszyp/node-lmdb/commit/7ff525ae57684a163d32af74a0ab9332b7fc4ce9 > Submission from: (NULL) (71.199.6.148) > > > We have seen very poor performance on the sync of

(ITS#9017) Improving performance of commit sync in Windows

2019-04-30 Thread kriszyp
Full_Name: Kristopher William Zyp Version: LMDB 0.9.23 OS: Windows URL: https://github.com/kriszyp/node-lmdb/commit/7ff525ae57684a163d32af74a0ab9332b7fc4ce9 Submission from: (NULL) (71.199.6.148) We have seen very poor performance on the sync of commits on large databases in Windows. On