Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
openlp.org Core (openlp-core)
Tooltip descriptions and a new Label for ServiceManager
--
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/11549
Your team openlp.org Core is
Review: Approve
Approve.
Some stylistic comments:
Various line splits happen within translate() call
self.Toolbar.addToolbarButton(u'New Service',
u':/services/service_new.png', translate(u'ServiceManager',
u'Create a new Service'), self.onNewService)
might be better as
The proposal to merge lp:~meths/openlp/trivialfixes into lp:openlp has been
updated.
Status: Needs review = Superseded
--
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/11549
Your team openlp.org Core is subscribed to branch lp:openlp.
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
--
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/11555
Your team openlp.org Core is subscribed to branch lp:openlp.
=== modified file 'openlp/core/ui/servicemanager.py'
---
The proposal to merge lp:~meths/openlp/trivialfixes into lp:openlp has been
updated.
Status: Needs review = Superseded
--
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/11555
Your team openlp.org Core is subscribed to branch lp:openlp.
Review: Approve
--
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/11556
Your team openlp.org Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
6 matches
Mail list logo
