Re: [Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2009-09-21 Thread Raoul Snyman
Review: Approve -- https://code.edge.launchpad.net/~meths/openlp/trivialfixes/+merge/12146 Your team openlp.org Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2009-09-21 Thread Tim Bentley
Review: Needs Fixing Some looks go but some is bad. Lines 21-28 etc make the code more unreadable. Readability is vital -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/12178 Your team openlp.org Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp updated

2009-09-21 Thread Jon Tibble
The proposal to merge lp:~meths/openlp/trivialfixes into lp:openlp has been updated. Status: Needs review = Superseded -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/12178 Your team openlp.org Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2009-09-21 Thread Raoul Snyman
Review: Approve Mostly fine. -- https://code.edge.launchpad.net/~meths/openlp/trivialfixes/+merge/12184 Your team openlp.org Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :