Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/presentations into lp:openlp

Review: Approve We don't have C++ coding standards, so I unfortunately don't have grounds to moan about your coding style :-P -- https://code.edge.launchpad.net/~j-corwin/openlp/presentations/+merge/12310 Your team openlp.org Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

Review: Approve If you're going to tidy up code, won't you please also rename 1 letter variables into something a little more descriptive? aa = temp_songauthors bb = temp_authors etc. -- https://code.edge.launchpad.net/~meths/openlp/trivialfixes/+merge/12320 Your team openlp.org Core is

Re: [Openlp-core] [Merge] lp:~trb143/openlp/audit into lp:openlp

Review: Approve What's with the extra line in classes.py and meta.py? -- https://code.edge.launchpad.net/~trb143/openlp/audit/+merge/12326 Your team openlp.org Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core

[Openlp-core] [Merge] lp:~j-corwin/openlp/presentations into lp:openlp updated

The proposal to merge lp:~j-corwin/openlp/presentations into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12310 Your team openlp.org Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp updated

The proposal to merge lp:~meths/openlp/trivialfixes into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/12320 Your team openlp.org Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/presentations into lp:openlp

I pushed some more incomplete changes after my original merge request, since I was expecting the merge to only merge the revision I'd requested and not later ones on the same branch. However it seems this is not the case, and my later incomplete changes ended up merged in trunk. This appears

[Openlp-core] [Merge] lp:~trb143/openlp/audit into lp:openlp updated

The proposal to merge lp:~trb143/openlp/audit into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~trb143/openlp/audit/+merge/12326 Your team openlp.org Core is subscribed to branch lp:openlp. ___ Mailing

[Openlp-core] [Merge] lp:~j-corwin/openlp/presentations into lp:openlp

Jonathan Corwin has proposed merging lp:~j-corwin/openlp/presentations into lp:openlp. Requested reviews: openlp.org Core (openlp-core) Not entirely sure about the rules for __init__.py, but these changes get rid of the linux errors. --

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/presentations into lp:openlp

Review: Approve Looks good. -- https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12370 Your team openlp.org Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/presentations into lp:openlp

Review: Approve There should be a blank line between the copyright notice and import os -- https://code.edge.launchpad.net/~j-corwin/openlp/presentations/+merge/12370 Your team openlp.org Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~j-corwin/openlp/presentations into lp:openlp updated

The proposal to merge lp:~j-corwin/openlp/presentations into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12370 Your team openlp.org Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~j-corwin/openlp/presentations into lp:openlp

Jonathan Corwin has proposed merging lp:~j-corwin/openlp/presentations into lp:openlp. Requested reviews: openlp.org Core (openlp-core) Got powerpoint viewer working! -- https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12383 Your team openlp.org Core is subscribed to

[Openlp-core] [Merge] lp:~j-corwin/openlp/presentations into lp:openlp updated

The proposal to merge lp:~j-corwin/openlp/presentations into lp:openlp has been updated. Status: Needs review = Superseded -- https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12383 Your team openlp.org Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/presentations into lp:openlp

Review: Approve Looks good. -- https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12388 Your team openlp.org Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp. Requested reviews: openlp.org Core (openlp-core) -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/12395 Your team openlp.org Core is subscribed to branch lp:openlp. === modified file 'cnvdb.py'

Re: [Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

Review: Approve Approved -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/12395 Your team openlp.org Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :