Hi Bastian,
We're not trying to discourage you from contributing at all, and we'd never
stop someone from contributing. We just want the contribution to line up better
with the project's greater goals.
If you have the motivation and the time to do it, that is awesome and we'd love
you to do
I see. The only change that would influence distributing via a Linux packaging
system is the introduction of the vlc module as a new dependency. The other
changes do not interfere if the Linux packages install python packages with
their Python dist information which is the case for all the
Review: Disapprove
Hi Bastian,
Thank you for contributing to OpenLP! It's great to see some of the issues I've
seen in OpenLP finally addressed. We have not had the time to look into these
issues, and we're happy to see someone looking into them.
Unfortunately your changes are not compatible
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Commit message changed to:
This fixes setuptools' dependencies according to
scripts/check_dependencies.py.
The minimum Python version is set to 3.5 because the async/await feature is in
use in the code
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Description changed to:
For more details, see:
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356147
--
Your team OpenLP Core is requested to review the proposed merge of
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Description changed to:
This fixes setuptools' dependencies according to
scripts/check_dependencies.py.
The minimum Python version is set to 3.5 because the async/await feature is in
use in the code base.
6 matches
Mail list logo
