Re: [Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

Review: Needs Fixing Looks good. One thing I would prefer to change though, is "VLC additions" aka "VLC additional commands". They are not commands, they are command line arguments, so I would call them "VLC arguments". In my opinion, "additions" is ambiguous and unclear. --

[Openlp-core] macOS Test Results: Passed

macOS tests passed! -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/366608 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] Linux Test Results: Passed

Linux tests passed! -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/366608 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] Linting: Passed

Linting passed! -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/366608 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp. Commit message: Media plays successfully and cleanups. Added VLC additions Requested reviews: Tomas Groth (tomasgroth) For more details, see: https://code.launchpad.net/~trb143/openlp/more_media/+merge/366608

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/more_media/+merge/366336 -- Your team OpenLP Core is subscribed to branch lp:openlp.