macOS tests passed!
--
https://code.launchpad.net/~tomasgroth/openlp/portable-path/+merge/366785
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Linux tests passed!
--
https://code.launchpad.net/~tomasgroth/openlp/portable-path/+merge/366785
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Linting passed!
--
https://code.launchpad.net/~tomasgroth/openlp/portable-path/+merge/366785
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Tomas Groth has proposed merging lp:~tomasgroth/openlp/portable-path into
lp:openlp.
Commit message:
Make it possible to specify the portable path to use for OpenLP Data when in
portable mode. This is very useful during development.
Requested reviews:
Phill (phill-ridout)
For more details,
The proposal to merge lp:~tomasgroth/openlp/portable-path into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~tomasgroth/openlp/portable-path/+merge/366734
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Good point!
I will test a bit later.
I think it's a good thing to use pymupdf, but a bit annoying that we need to
keep the support for the bin mupdf.
--
https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366749
Your team OpenLP Core is subscribed to branch lp:openlp.
So it is not a blocker.
--
https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366749
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
That is right and therefore I added it as optional dependency. The other PDF
controller types are still there and are of a higher priority than PyMuPDF.
--
https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366749
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Needs Information
As far as I know pymupdf is not available in Debian and Ubuntu, which is a
blocker for now.
Feel free to correct me if I'm wrong.
--
https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366749
Your team OpenLP Core is subscribed to branch lp:openlp.
The advantage over the current method (subprocess) is it is more performant and
you get rid of having to depend on an executable. PyMuPDF has binary wheels
available on PyPI so this has advantages for packaging.
--
https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366749
Your
No, we do not have to include MuPDF's source code. The AGPL has additional
obligations for an OPERATOR who makes a AGPL-licenced work available via
network. As OpenLP has the remote features, this applies here.
So a church that runs a MODIFIED MuPDF with OpenLP would have to provide its
MuPDF
Also tests failed!
--
https://code.launchpad.net/~tomasgroth/openlp/portable-path/+merge/366734
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Fixing
Sorry, a few nit picks...
Diff comments:
> === modified file 'openlp/core/app.py'
> --- openlp/core/app.py2019-03-28 21:03:32 +
> +++ openlp/core/app.py2019-04-30 19:47:11 +
> @@ -301,6 +302,8 @@
> help='Set logging to LEVEL
Review: Needs Information
So what you're saying is that if we merge this proposed code, we will need to
include the source code for MuPDF with OpenLP?
What advantage does this have over the current method?
--
https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366749
Your team
macOS tests passed!
--
https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366749
Your team OpenLP Core is requested to review the proposed merge of
lp:~bastian-germann/openlp/pymupdf into lp:openlp.
___
Mailing list:
Linting passed!
--
https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366749
Your team OpenLP Core is requested to review the proposed merge of
lp:~bastian-germann/openlp/pymupdf into lp:openlp.
___
Mailing list:
Linux tests passed!
--
https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366749
Your team OpenLP Core is requested to review the proposed merge of
lp:~bastian-germann/openlp/pymupdf into lp:openlp.
___
Mailing list:
Bastian Germann has proposed merging lp:~bastian-germann/openlp/pymupdf into
lp:openlp.
Commit message:
Add PyMuPDF as additional PDF controller
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366749
** Branch unlinked: lp:~bastian-germann/openlp/gpl3
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1795876
Title:
License violations
Status in OpenLP:
Fix Committed
Status in OpenLP 2.0 series:
19 matches
Mail list logo
