[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread noreply
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~trb143/openlp/more_media/+merge/368843 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Bug 1832923] [NEW] SongSelect error handling

2019-06-14 Thread Johnthan
Public bug reported: A user on the forum had an error when trying to import from the SongSelect websiteOpenLP locked up and did NOT handle the error the website returned Please see https://forums.openlp.org/discussion/4346/openlp-crashes-

Re: [Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread Phill
Review: Approve -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/368843 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] macOS Test Results: Passed

2019-06-14 Thread Raoul Snyman
macOS tests passed! -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/368843 Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/more_media into lp:openlp. ___ Mailing list:

[Openlp-core] Linting: Passed

2019-06-14 Thread Raoul Snyman
Linting passed! -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/368843 Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/more_media into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core

[Openlp-core] Linux Test Results: Passed

2019-06-14 Thread Raoul Snyman
Linux tests passed! -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/368843 Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/more_media into lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp. Commit message: Adds basic streaming service item UI to set up streaming Fix issues with suffix refactor Requested reviews: OpenLP Core (openlp-core) For more details, see:

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp. Commit message: Adds basic streaming service item UI to set up streaming Fix issues with suffix refactor Requested reviews: OpenLP Core (openlp-core) For more details, see:

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/more_media/+merge/368842 -- Your team OpenLP Core is requested to review the proposed merge of

Re: [Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread Phill
Review: Approve -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/368841 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] Linting: Passed

2019-06-14 Thread Raoul Snyman
Linting passed! -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/368842 Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/more_media into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core

Re: [Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread Phill
Review: Needs Fixing Just one inconsistency with text labels (see inline) and the failed linting, but other than that looks ok! Diff comments: > > === modified file 'openlp/core/ui/media/mediatab.py' > --- openlp/core/ui/media/mediatab.py 2019-05-04 19:47:06 + > +++

[Openlp-core] Linux Test Results: Passed

2019-06-14 Thread Raoul Snyman
Linux tests passed! -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/368842 Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/more_media into lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/more_media/+merge/368841 -- Your team OpenLP Core is requested to review the proposed merge of

[Openlp-core] Linux Test Results: Passed

2019-06-14 Thread Raoul Snyman
Linux tests passed! -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/368841 Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/more_media into lp:openlp. ___ Mailing list:

[Openlp-core] Linting: Failed

2019-06-14 Thread Raoul Snyman
Linting failed, please see https://ci.openlp.io/job/MP-03-Linting/119/ for more details -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/368841 Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/more_media into lp:openlp.

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp. Commit message: Adds basic streaming service item UI to set up streaming Fix issues with suffix refactor Requested reviews: OpenLP Core (openlp-core) For more details, see:

[Openlp-core] [Bug 1832874] Re: Temporary songs appear in the 'Delete Duplicate songs' wizard

2019-06-14 Thread Tim Bentley
Code to fix this was removed from the Songs plugin in 2.2 but was there in 2.0 ** Changed in: openlp Status: New => Confirmed ** Changed in: openlp Importance: Undecided => High -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to

[Openlp-core] [Bug 1832876] [NEW] Please add songbook to the 'Delete Duplicate Songs' Wizard

2019-06-14 Thread Johnthan
Public bug reported: Windows 10 OpenLP 2.4.6 When trying to delete duplicate songs using the wizard, please add the songbook and theme to the information displayed. It helps to know that there are three duplicates of a song, but each is in a different songbook or that they have different

[Openlp-core] [Bug 1832874] [NEW] Temporary songs appear in the 'Delete Duplicate songs' wizard

2019-06-14 Thread Johnthan
Public bug reported: Windows 10 OpenLP 2.4.6 When you run the Delete Duplicate songs wizard most songs marked in the db as Temporary will show up and the user has no idea that they are temporary It would be best if the songs were removed from the db when they are no longer needed, but at