Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/fix-presentations-cleanup-bug/+merge/369624
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
macOS tests passed!
--
https://code.launchpad.net/~raoul-snyman/openlp/fix-presentations-cleanup-bug/+merge/369624
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/fix-presentations-cleanup-bug into lp:openlp.
Linting passed!
--
https://code.launchpad.net/~raoul-snyman/openlp/fix-presentations-cleanup-bug/+merge/369624
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/fix-presentations-cleanup-bug into lp:openlp.
___
Linux tests passed!
--
https://code.launchpad.net/~raoul-snyman/openlp/fix-presentations-cleanup-bug/+merge/369624
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/fix-presentations-cleanup-bug into lp:openlp.
Raoul Snyman has proposed merging
lp:~raoul-snyman/openlp/fix-presentations-cleanup-bug into lp:openlp.
Commit message:
Fix a bug when cleaning up thumbnails where all presentation controllers,
whether enabled or not, would be cycled through.
Requested reviews:
OpenLP Core (openlp-core)
For
Linux tests failed, please see https://ci.openlp.io/job/MP-02-Linux_Tests/203/
for more details
--
https://code.launchpad.net/~raoul-snyman/openlp/zeroconf/+merge/369623
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
The proposal to merge lp:~raoul-snyman/openlp/zeroconf into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/zeroconf/+merge/369554
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/zeroconf into
lp:openlp.
Commit message:
Add Zeroconf services to OpenLP so that external devices can find OpenLP on the
network.
Requested reviews:
Tomas Groth (tomasgroth)
For more details, see:
See inline
Diff comments:
> === added file 'openlp/core/api/zeroconf.py'
> --- openlp/core/api/zeroconf.py 1970-01-01 00:00:00 +
> +++ openlp/core/api/zeroconf.py 2019-07-01 22:53:54 +
> @@ -0,0 +1,101 @@
> +# -*- coding: utf-8 -*-
> +# vim: autoindent shiftwidth=4 expandtab
Diff comments:
> === added file 'openlp/core/api/zeroconf.py'
> --- openlp/core/api/zeroconf.py 1970-01-01 00:00:00 +
> +++ openlp/core/api/zeroconf.py 2019-07-01 22:53:54 +
> @@ -0,0 +1,101 @@
> +# -*- coding: utf-8 -*-
> +# vim: autoindent shiftwidth=4 expandtab
Review: Needs Fixing
Please see inline comments.
Diff comments:
> === added file 'openlp/core/api/zeroconf.py'
> --- openlp/core/api/zeroconf.py 1970-01-01 00:00:00 +
> +++ openlp/core/api/zeroconf.py 2019-07-01 22:53:54 +
> @@ -0,0 +1,101 @@
> +# -*- coding: utf-8 -*-
> +#
11 matches
Mail list logo
