Review: Needs Fixing
Minor issue.
Diff comments:
> === modified file 'openlp/plugins/songs/lib/importers/chordpro.py'
> --- openlp/plugins/songs/lib/importers/chordpro.py2019-04-13 13:00:22
> +
> +++ openlp/plugins/songs/lib/importers/chordpro.py2019-08-28 19:52:20
> +
> @@
Linting passed!
--
https://code.launchpad.net/~tomasgroth/openlp/chordpro-fixes/+merge/371955
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
macOS tests passed!
--
https://code.launchpad.net/~tomasgroth/openlp/chordpro-fixes/+merge/371955
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Linux tests passed!
--
https://code.launchpad.net/~tomasgroth/openlp/chordpro-fixes/+merge/371955
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
JavaScript tests passed!
--
https://code.launchpad.net/~tomasgroth/openlp/chordpro-fixes/+merge/371955
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Tomas Groth has proposed merging lp:~tomasgroth/openlp/chordpro-fixes into
lp:openlp.
Commit message:
Added support for more directives/tags when importing chord pro files.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
The proposal to merge lp:~tomasgroth/openlp/chordpro-fixes into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~tomasgroth/openlp/chordpro-fixes/+merge/371954
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Approve
--
https://code.launchpad.net/~tomasgroth/openlp/chordpro-fixes/+merge/371954
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
JavaScript tests failed, please see
https://ci.openlp.io/job/MP-02-JavaScript-Tests/14/ for more details
--
https://code.launchpad.net/~tomasgroth/openlp/chordpro-fixes/+merge/371954
Your team OpenLP Core is requested to review the proposed merge of
lp:~tomasgroth/openlp/chordpro-fixes into
Tomas Groth has proposed merging lp:~tomasgroth/openlp/chordpro-fixes into
lp:openlp.
Commit message:
Added support for more directives/tags when importing chord pro files.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
10 matches
Mail list logo