On 22/01/2019 14:21, Bastian Germann wrote:
> The pymediainfo license violation is gone in trunk now. How about changing
> the license headers now?
> Is there anyone in the last comment's list who did a lot of things? I guess
> @springermac.
>
Feel free to use whichever license best serves the
This is also taking over the X session on my system rendering X unusable until
restarted (Ctrl+Alt+Backspace works as do the other Ctrl+Alt+Fx keys to get
terminals).
Killing OpenLP from said terminals does not restore control to X though so the
X restart is necessary.
--
You received this
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/98113
Various cleanups and fix bugs #15 and #941966
If people want to wait
Just thought it worth adding the bug fix is diff lines 133-5.
--
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/98113
Your team OpenLP Core is requested to review the proposed merge of
lp:~meths/openlp/trivialfixes into lp:openlp.
___
Hi Derek, A new test build is up here http://builds.projecthq.biz
/media-test-OpenLP-1.9.8-bzr1436-setup.exe
Could you try it and let us know if it fixes your issue and also that it
doesn't break anything either! Thanks.
--
You received this bug notification because you are a member of OpenLP
Review: Approve
--
https://code.launchpad.net/~j-corwin/openlp/bug-952254/+merge/96921
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Information
Looks sensible, nothing set up to test it at the moment though.
Not sure about the lack of logging. Do we want exceptions that don't log
anything when hit?
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-927473/+merge/92665
Your team OpenLP Core is subscribed
Just looking at this and wondering about recursion/duplicating code execution -
should line 12 be return self.saveFileAs() like servicemanager.py:479?
--
https://code.launchpad.net/~smpettit/openlp/bug-905040/+merge/87201
Your team OpenLP Core is requested to review the proposed merge of
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/87190
Unused imports
Refactor identical search function code.
--
https
Are you updating the wiki and changing line 127?
--
https://code.launchpad.net/~mahfiaz/openlp/bug-904384/+merge/87192
Your team OpenLP Core is requested to review the proposed merge of
lp:~mahfiaz/openlp/bug-904384 into lp:openlp.
___
Mailing list:
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/87198
Fix crashes in media settings - bug #908252
Few cleanups
--
https
** Changed in: openlp
Status: Confirmed = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/908252
Title:
OpenLP crashes when media settings are changed after cancelling the
Review: Approve
--
https://code.launchpad.net/~mahfiaz/openlp/bug-904384/+merge/87199
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
** Changed in: openlp
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/908252
Title:
OpenLP crashes when media settings are changed after cancelling the
** Changed in: openlp
Status: New = Confirmed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/908252
Title:
OpenLP crashes when media settings are changed after cancelling the
dialog
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #892668 in OpenLP: Duplicate entries in Recent Files list (win7)
https://bugs.launchpad.net/openlp/+bug/892668
Bug #900481 in OpenLP: Trackback
This shifts the exception trigger down in the event that we get a non unicode
theme passed through this. I don't know where this will be triggered though
and don't have any broken themes to test with (not sure where they'd come from
either) so haven't added any exception handling.
--
** Changed in: openlp
Status: Confirmed = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/882819
Title:
Problem with v1 theme with non-english characters in the name
Status in
** Changed in: openlp
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/882819
Title:
Problem with v1 theme with non-english characters in the name
Status
Yeah, complete lack of detail explaining what is going on so it just
appears hung.
Oh and at least on windows that import box is incorrectly titled
python
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #892668 in OpenLP: Duplicate entries in Recent Files list (win7)
https://bugs.launchpad.net/openlp/+bug/892668
For more details, see:
https
** Changed in: openlp
Status: New = Confirmed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/892668
Title:
Duplicate entries in Recent Files list (win7)
Status in OpenLP - Worship
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/84397
Reduce the risk of duplicates in the recent files list by always using
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/84366
Normal variety of cleanups including whitespace, unused import, indentation
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-863845/+merge/84381
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/84337
Normal variety of cleanups including whitespace, unused import, indentation
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/68170
Cleanups
--
https://code.launchpad.net/~meths/openlp/testing/+merge/68170
Your team
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/68177
Cleanups
Resubmit: Remove unused string_is_unicode function
--
https://code.launchpad.net
Review: Needs Fixing
Line 16: OSIS was designed to provide a common format for [distribution of]
electronic Bibles.
Square bracket text is optional, the main point is removing the existing double
instances of format.
Line 154: Could you make it try the PowerPoint 2003 or 2007 Viewers. please?
Review: Needs Fixing
Line 12: I think this could be better but I'm failing to come up with better at
the moment so if anyone thinks of something it can go in otherwise I'll let it
pass (the rest needs fixing).
Line 51: Make it or Delete to remove an alert you do not need.
Line 64: Fix lack of
Review: Needs Fixing
Line 45: don't put a comma before the and in a list.
Line 52: don't put apostrophes in plurals.
--
https://code.launchpad.net/~wesleystout/openlp/documentation/+merge/55782
Your team OpenLP Core is subscribed to branch lp:openlp.
No it doesn't. Genesis 1,3 is Genesis chapters 1 and 3. We could add
'Book Chapter\n'
'Book Chapter-Chapter\n'
+'Book Chapter,Chapter\n'
'Book Chapter:Verse-Verse\n'
if you think it needs the extra example.
The comma as a
Review: Needs Fixing
There's a string freeze.
--
https://code.launchpad.net/~raoul-snyman/openlp/wizard/+merge/53199
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53213
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/wizard/+merge/53298
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/53308
Fix bug with KJ21 not getting the first verse in each chapter because not all
bibles
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/53350
Cleanups
--
https://code.launchpad.net/~meths/openlp/testing/+merge/53350
Your team
Review: Approve
--
https://code.launchpad.net/~mahfiaz/openlp/media_fixes/+merge/52901
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/52728
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Fixing
Never return from a finally - remember finally is guaranteed to run and so
overrides your except return. So take all that non-cleanup stuff out of
finally too - you only want to cleanup (close the zip in this case) in finally.
Take zip.close() out of except - the finally
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/debian/+merge/52646
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Fixing
Don't take away the finally block - if there is an exception the zip file
handle stays open.
Don't return from an exception handler either.
--
https://code.launchpad.net/~mahfiaz/openlp/media_fixes/+merge/52533
Your team OpenLP Core is subscribed to branch lp:openlp.
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/52301
Cleanups
--
https://code.launchpad.net/~meths/openlp/testing/+merge/52301
Your team
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/52233
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/fixes/+merge/52108
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/51391
Fix Jesus' words in BibleGateway parsing.
--
https://code.launchpad.net/~meths
Review: Needs Information
What's the stray underscore for? Line 70
--
https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/51137
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/51197
Fix handling of verses that are missing but acknowledged - manifested in
illegal verse
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/51137
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Fixing
Line 30 - remove double space and fix as line is too long. (length max 80 chars
BTW)
--
https://code.launchpad.net/~orangeshirt/openlp/foilpresenterimport/+merge/51211
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/51237
Fix non-saving OpenLyrics authors (Bug 724568)
--
https://code.launchpad.net
** Changed in: openlp
Status: New = Fix Committed
** Changed in: openlp
Assignee: (unassigned) = Jon Tibble (meths)
** Changed in: openlp
Milestone: None = 1.9.5
** Changed in: openlp
Importance: Undecided = High
--
You received this bug notification because you
Review: Needs Fixing
Please add a utility method, something like add_unknown_author(), rather than
adding the same piece of code in three places.
Could you also take care of the unknown author adding in olpimport.py with this
patch please.
--
Review: Approve
--
https://code.launchpad.net/~mahfiaz/openlp/fixes_and_improvements/+merge/50813
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/50994
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~orangeshirt/openlp/foilpresenterimport/+merge/50984
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/default-image/+merge/51010
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/51061
Cleanups and fixes
--
https://code.launchpad.net/~meths/openlp/trivialfixes
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50636
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50653
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Approve
The correct fix for README shouldn't add line 11, it should just remove line 9
but nevermind.
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50499
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/trivial2/+merge/50520
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
Looks okay - want descriptions in merge proposals though.
--
https://code.launchpad.net/~mahfiaz/openlp/fixes_and_improvements/+merge/50521
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Review: Needs Fixing
Lines 494 onwards would be better formatted like below I think as it saves
using \ and we're all used to having and reading translate() calls needing
their own line.
self.tagTableWidget.horizontalHeaderItem(0).setText(
translate('OpenLP.DisplayTagTab', 'Description'))
Review: Needs Fixing
I've said I'd prefer that it just be a display name and not split but even
ignoring that...
This is a new place where the unknown author is being added. Fix all the other
locations to add it in the same way or, even better, refactor so that there is
only one place that
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/50463
Fix the CCLI author handling to work with or without a comma
--
https
No new line at EOF?
--
https://code.launchpad.net/~raoul-snyman/openlp/readme/+merge/50465
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/50467
Fix the CCLI author handling to work with or without a comma
--
https
Review: Needs Fixing
Merge conflicts
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50466
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
build_icon returns a QIcon, no need for all the QIcon(build_icon()) stuff.
Line 1070 is in UiStrings already as it's in the menu in mainwindow
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50469
Your team OpenLP Core is subscribed to branch lp:openlp.
The print statements are part of the debugging/song dump method and are fine.
Raoul has clarified the variable names to mahfiaz in IRC and on the wiki coding
standards page and they are fine too.
If Raoul is happy with leaving the xml.py to use the naming another day then
this looks ready.
--
Review: Approve
--
https://code.launchpad.net/~mahfiaz/openlp/opensongfixes/+merge/50282
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/50348
Fix the mime data string so it is the non-translated version.
--
https
Review: Needs Fixing
Lines 159, 162, 165, 168, 171, 174 and 177 should be VerseType.Type not a magic
number.
Line 241 s/.tag/.Tags/ and then remove the .tag() method. It is redundant.
--
https://code.launchpad.net/~mahfiaz/openlp/opensongfixes/+merge/50042
Your team OpenLP Core is subscribed
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/50184
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/windows-updates/+merge/50209
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Fixing
Please make line 442: Tags = [name[0].lower() for name in Names]
Same in 454
Line 62+63 should be taken care of in the method. Make the method guarantee to
return a Type (which I thought you had actually in a previous revision?)
Line 148+149 are different to 62+63 - what
Review: Needs Fixing
You haven't followed the naming changes through all the way to the end.
opensongimport and xml need the correct matching of types to types, defs to
defs, names to names, etc.
What's line 404 for? You aren't using that regex.
Missed a s/verseIndex/verse_index/ in
Review: Needs Fixing
Sorry I didn't notice this earlier. Don't remove the VerseTypes in lines
274-290. There's nothing special about this location - the strings are
centralised and used in numerous files, don't create multiple points to have to
change stuff.
--
Are you using the Neue Genfer Übersetzung from bibleserver.com?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/706209
Title:
Bibles: after a exception in a reference search the search button
stays
Review: Needs Fixing
Not sure why we care about the int scenarios in the methods as users don't know
about them so they can only come from code so we're just going to be doing:
VerseType.Tags[VerseType.Type]
and bypassing the methods anyway. The only things the methods need to take
care of is
Review: Needs Information
Can we remove the All Files? I don't think there is any reason to have it (we
don't have it in other places where we know what format we want) and it keeps
leading to issues like http://support.openlp.org/issues/114 with people trying
to import incorrect types.
--
Review: Approve
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/49865
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/49670
Fix translation grammar breaking strings.
--
https://code.launchpad.net/~meths/openlp
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/49682
Fix translation grammar breaking strings - complete with commas!
Fix unicode for string
Review: Needs Fixing
Bad indent 53
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49677
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49687
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/49695
Fix translation grammar breaking strings - complete with commas, strings and
less typos!
Fix
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/49709
Various cleanups:
- whitespace
- imports
- unused variables
- misnamed variables
--
https
Review: Needs Fixing
Need to fix:
Incorrect alignment lines 69 and 74.
Question rather than saying fix:
Are those new quotes in the connections deliberate and necessary then?
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/49717
Your team OpenLP Core is subscribed to branch
Sorry, that using authors with only display names to reproduce was
another bug where songs get overwritten on save rather than creating a
new song. I was never able to get a stack trace from everything I
tried.
--
You received this bug notification because you are a member of OpenLP
Core, which
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/49755
Resubmitting to include a fix in editsongform. A new song can overwrite a song
that has
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49544
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/ssp_import/+merge/49548
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Fixing
Loose the magic numbers (== [0-9]), see the equivalent song search changes in
trivialfixes for what I mean if you're unsure.
--
https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/49552
Your team OpenLP Core is subscribed to branch lp:openlp.
First trace should be fixed in 1288.
Second looks like
- http://support.openlp.org/issues/87
and is a variation on another goto_slide issue
- http://support.openlp.org/issues/85
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/49503
Typo
--
https://code.launchpad.net/~meths/openlp/testing/+merge/49503
Your team OpenLP
Jon Tibble has proposed merging lp:~meths/openlp/testing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/testing/+merge/49507
Typo
Fix overzealous alertTab refactoring.
--
https://code.launchpad.net/~meths/openlp
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49434
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/49440
Fix my bad with the data dirs.
--
https://code.launchpad.net/~meths/openlp
1 - 100 of 613 matches
Mail list logo
