[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib6 into lp:openlp

2017-09-25 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib6 into lp:openlp. Requested reviews: Tim Bentley (trb143) Phill (phill-ridout) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib6/+merge/331276 This is ready to go now! Upgrade the image plugin to use

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib6 into lp:openlp

2017-09-25 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib6 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib6/+merge/331252 -- Your team OpenLP Core is subscribed to branch lp:ope

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib6 into lp:openlp

2017-09-24 Thread Phill
Review: Needs Fixing Just noticed one minor mistake. -- https://code.launchpad.net/~phill-ridout/openlp/pathlib6/+merge/331252 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib6 into lp:openlp

2017-09-24 Thread Phill
those __init__ methods just call the super method. They don't do anything I fail to see any reason for keeping them! On Sun, 24 Sep 2017, 22:01 Tim Bentley wrote: > Review: Needs Information > > Why have you removed a couple of __init__ methods? > -- > https://code.launchp

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib6 into lp:openlp

2017-09-24 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib6 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib6/+merge/331252 Upgrade the image plugin to use pathlib. Other minor changes and fixes. lp

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib5 into lp:openlp

2017-09-21 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib5 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib5/+merge/331127 More pathlib changes, focused mainly on the

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib5 into lp:openlp

2017-09-21 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib5 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib5/+merge/331121 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib5 into lp:openlp

2017-09-20 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib5 into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib5/+merge/331121 More pathlib changes, focused mainly on the

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib5 into lp:openlp

2017-09-20 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib5 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib5/+merge/330943 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib5 into lp:openlp

2017-09-18 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib5 into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib5/+merge/330943 More pathlib changes, focused mainly on the presentation plugin lp:~phill-ridout

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib5 into lp:openlp

2017-09-18 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib5 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib5/+merge/330895 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib5 into lp:openlp

2017-09-18 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib5 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib5/+merge/330895 More pathlib changes, focused mainly on the presentation plugin lp:~phill

[Openlp-core] [Merge] lp:~phill-ridout/openlp/tgcs_json_fix into lp:openlp

2017-09-09 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/tgcs_json_fix into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/tgcs_json_fix/+merge/330477 Thanks to TGC for his json fix Also fixes some setting upgrades that

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib4 into lp:openlp

2017-09-03 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib4 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Phill (phill-ridout) Raoul Snyman (raoul-snyman) Tomas Groth (tomasgroth) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~phill-ridout/openlp

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib4 into lp:openlp

2017-09-03 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib4 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib4/+merge/329697 -- Your team OpenLP Core is requested to review the proposed merge of

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib4 into lp:openlp

2017-08-27 Thread Phill
Review: Approve Sorry this is ready to go -- https://code.launchpad.net/~phill-ridout/openlp/pathlib4/+merge/329697 Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/pathlib4 into lp:openlp. ___ Mailing list

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib4 into lp:openlp

2017-08-27 Thread Phill
Review: Needs Fixing -- https://code.launchpad.net/~phill-ridout/openlp/pathlib4/+merge/329697 Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/pathlib4 into lp:openlp. ___ Mailing list: https

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib4 into lp:openlp

2017-08-27 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib4 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Tomas Groth (tomasgroth) Raoul Snyman (raoul-snyman) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib4/+merge/329697

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib4 into lp:openlp

2017-08-27 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib4 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib4/+merge/329695 -- Your team OpenLP Core is requested to review the proposed merge of

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib4 into lp:openlp

2017-08-27 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib4 into lp:openlp. Requested reviews: Tomas Groth (tomasgroth) OpenLP Core (openlp-core) Tim Bentley (trb143) Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib4/+merge/329695

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib4 into lp:openlp

2017-08-27 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib4 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib4/+merge/329676 -- Your team OpenLP Core is requested to review the proposed merge of

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib4 into lp:openlp

2017-08-26 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib4 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib4/+merge/329676 Change the settings upgrade code to handle versioned upgrades Upgrade settings

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib4 into lp:openlp

2017-08-26 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib4 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib4/+merge/329671 -- Your team OpenLP Core is requested to review the proposed merge of

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib4 into lp:openlp

2017-08-26 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib4 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib4/+merge/329671 I'm just proposing this merge to get a clear diff -- Your team OpenLP

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib3 into lp:openlp

2017-08-24 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib3 into lp:openlp has been updated. Status: Work in progress => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib3/+merge/329481 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib3 into lp:openlp

2017-08-24 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib3 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Tomas Groth (tomasgroth) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib3/+merge/329540 Part 3, converted some

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib3 into lp:openlp

2017-08-24 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib3 into lp:openlp has been updated. Status: Merged => Work in progress For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib3/+merge/329481 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib3 into lp:openlp

2017-08-23 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib3 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tomas Groth (tomasgroth) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib3/+merge/329481 Part 3, converted some

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib3 into lp:openlp

2017-08-23 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib3 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib3/+merge/328950 -- Your team OpenLP Core is subscribed to branch lp:ope

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib3 into lp:openlp

2017-08-18 Thread Phill
Check to see if we have any media Player's available. > """ > log.debug('_check_available_media_players') > -controller_dir = os.path.join('openlp', 'core', 'ui', 'media') > +controller_

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib3 into lp:openlp

2017-08-17 Thread Phill
> See inline See my inline reply. -- https://code.launchpad.net/~phill-ridout/openlp/pathlib3/+merge/328950 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-c

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib3 into lp:openlp

2017-08-17 Thread Phill
See my inline reply. -- https://code.launchpad.net/~phill-ridout/openlp/pathlib3/+merge/328950 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Bug 1709643] Re: Line spacing setting not honoured

2017-08-14 Thread Phill
Hi JC. Thanks for reporting this bug. I tried to replicate it on windows running the latest development version. It seemed to work for me, but I had to use ridiculously large numbers just to see a small change. Could you try using a small font size and then setting the spacing to 100pt, to see if

[Openlp-core] [Bug 1710109] Re: languagemanager.py - ValueError: Unknown format code 'i' for object of type 'int'

2017-08-14 Thread Phill
** Changed in: openlp Status: New => In Progress ** Changed in: openlp Importance: Undecided => Medium ** Changed in: openlp Assignee: (unassigned) => Phill (phill-ridout) -- You received this bug notification because you are a member of OpenLP Core, which is subs

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib3 into lp:openlp

2017-08-12 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib3 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib3/+merge/328950 Part 3, converted some more utility methods lp:~phill-ridout/openlp/pathlib3

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-09 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib2 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328825 Definitely ready for merging, unless, of course you

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-09 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib2 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328805 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-09 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib2 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328694 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-09 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib2 into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328805 Part 2 Changed the pathedit widget over to using

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-07 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib2 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328694 Part 2 Changed the pathedit widget over to using

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-07 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib2 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328616 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-04 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib2 into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328616 Part 2 Changed the pathedit widget over to using pathlib Added a 'patched&

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-04 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib2 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328595 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-04 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib2 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328595 Part 2 Changed the pathedit widget over to using pathlib Added a 'pa

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib1 into lp:openlp

2017-08-02 Thread Phill
ts. Just tgc asked me to break it up as the diff on my other branch was 15,000 lines and growing! (https://code.launchpad.net/~phill-ridout/openlp/pathlib/+merge/326416/comments/855627) -- https://code.launchpad.net/~phill-ridout/openlp/pathlib1/+merge/328435 Your team OpenLP Core is subscrib

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib1 into lp:openlp

2017-08-01 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib1 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tomas Groth (tomasgroth) OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib1/+merge/328435 This is the first in

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib into lp:openlp

2017-07-07 Thread Phill
a look. Thanks, I'm still working on it and have plenty still to do! -- https://code.launchpad.net/~phill-ridout/openlp/pathlib/+merge/326416 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~open

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib into lp:openlp

2017-07-07 Thread Phill
the changes are wide and far reaching, I was planning to make all the changes and do some very through testing before merging this in to trunk to track down any bugs -- https://code.launchpad.net/~phill-ridout/openlp/pathlib/+merge/326416 Your team OpenLP Core is su

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib into lp:openlp

2017-06-28 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib/+merge/325905 -- Your team OpenLP Core is subscribed to branch lp:ope

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib into lp:openlp

2017-06-24 Thread Phill
athlib is better than using os.path, which I could demonstrate with code samples from OpenLP, but if windows has issues. -- https://code.launchpad.net/~phill-ridout/openlp/pathlib/+merge/325905 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Bug 1209515] Re: getFileNames corrupts file names that use "special chars"

2017-06-15 Thread Phill
I've tested on Ubuntu 17.04 (Unity) and Windows 7. Anybody with KDE, just to round up testing? On Thu, 15 Jun 2017, 02:36 David Wales, wrote: > Tested on OS X El Capitan with python 3, and PyQt 5 installed using > brew. > > Works perfectly. > > -- > You received this bug notification because yo

[Openlp-core] [Bug 1209515] Re: getFileNames corrupts file names that use "special chars"

2017-06-11 Thread Phill
mahfiaz, Thanks for that, but could you test the paste bin script linked to in my email (https://lists.openlp.io/pipermail/openlp-dev/2017-June/000273.html) please? Its PyQt5! Also which platform are you on? -- You received this bug notification because you are a member of OpenLP Core, which i

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/TODOne into lp:openlp

2017-06-08 Thread Phill
Add this to your merge proposal: lp:~phill-ridout/openlp/TODOne (revision 2746) [SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/2078/ [SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1988/ [SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests

[Openlp-core] [Merge] lp:~phill-ridout/openlp/TODOne into lp:openlp

2017-06-06 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/TODOne into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/TODOne/+merge/324904 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/TODOne into lp:openlp

2017-06-06 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/TODOne into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/TODOne/+merge/325201 I've TODOne some of the TODO's. As well as some other clean ups

[Openlp-core] [Merge] lp:~phill-ridout/openlp/test-fixes into lp:openlp

2017-06-03 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/test-fixes into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/test-fixes/+merge/325039 Fixed some bible media item tests and one render test. The 02-Functional

[Openlp-core] [Merge] lp:~phill-ridout/openlp/test-fixes into lp:openlp

2017-06-03 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/test-fixes into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/test-fixes/+merge/325038 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/test-fixes into lp:openlp

2017-06-03 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/test-fixes into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/test-fixes/+merge/325038 Fixed some bible media item tests and one render test. The 02-Functional

[Openlp-core] [Bug 1695268] Re: Bibles plugin fails to load due to invalid "last search type" value

2017-06-03 Thread Phill
The value comes from line 250 of the diff at https://code.launchpad.net /~phill-ridout/openlp/saved_bible_verses/+merge/324674 This should only affect you if you go from a newer version of openlp to an older version, and as we don't support downgrading I'm going to set this as 

[Openlp-core] [Bug 1081577] Re: Support Visual Song Book Import

2017-06-03 Thread Phill
The software is still available at: https://web.archive.org/web/20161109024056/http://visualsongbook.com/downloads.asp maybe we could still help some poor old users... ** Changed in: openlp/trunk Status: Won't Fix => Confirmed -- You received this bug notification because you are a membe

[Openlp-core] [Merge] lp:~phill-ridout/openlp/TODOne into lp:openlp

2017-05-31 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/TODOne into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/TODOne/+merge/324904 I've TODOne some of the TODO's. As well as some other clean ups

[Openlp-core] [Merge] lp:~phill-ridout/openlp/TODOne into lp:openlp

2017-05-31 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/TODOne into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/TODOne/+merge/324887 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/TODOne into lp:openlp

2017-05-31 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/TODOne into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/TODOne/+merge/324887 I've TODOne some of the TODO's. As well as some other clean ups

[Openlp-core] [Merge] lp:~phill-ridout/openlp/TODOne into lp:openlp

2017-05-31 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/TODOne into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/TODOne/+merge/324815 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Bug 1694732] [NEW] wizard sub title does not wrap

2017-05-31 Thread Phill
Public bug reported: See attached screen shot. Running from trunk revno ~ 2737. Windows 10. Control Panel\All Control Panel Items\Display set to Medium (125%) ** Affects: openlp Importance: Low Status: New ** Attachment added: "Untitled.png" https://bugs.launchpad.net/bugs/169

[Openlp-core] [Bug 1694713] [NEW] FRW themes are xml based

2017-05-31 Thread Phill
Public bug reported: The FRW themes are xml based. These should be changed over to the json format. ** Affects: openlp Importance: Low Assignee: Phill (phill-ridout) Status: New ** Changed in: openlp Importance: Undecided => Low ** Changed in: openlp Assig

[Openlp-core] [Merge] lp:~phill-ridout/openlp/TODOne into lp:openlp

2017-05-30 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/TODOne into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/TODOne/+merge/324815 I've TODOne some of the TODO's. As well as some other clean ups lp:~ph

[Openlp-core] [Bug 1644548] Re: QMessageBox has changed return types

2017-05-30 Thread Phill
I have searched through the source code, and this doesn't actually affect us. So I'm going to close this bug. ** Changed in: openlp Status: New => Invalid -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.n

[Openlp-core] [Bug 1625681] Re: If Bible search results are locked, duplicated results are listed

2017-05-30 Thread Phill
** Changed in: openlp Status: New => In Progress ** Changed in: openlp Assignee: (unassigned) => Phill (phill-ridout) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1625681 Title

[Openlp-core] [Bug 1513490] Re: List of authors uses localized "and" instead of English

2017-05-30 Thread Phill
** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1513490 Title: List of authors uses localized "and" instead of English Status in Open

[Openlp-core] [Bug 1620371] Re: The imp package is pending deprecation in favor of importlib.

2017-05-30 Thread Phill
** Changed in: openlp Assignee: (unassigned) => Phill (phill-ridout) ** Branch linked: lp:~phill-ridout/openlp/import-depreciations ** Changed in: openlp Status: Confirmed => Fix Committed ** Changed in: openlp Milestone: None => 2.6 -- You received this bug not

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-d into lp:openlp

2017-05-30 Thread Phill
Just a few inline comments. Nothing major that I could spot. Diff comments: > > === modified file 'openlp/core/lib/projector/db.py' > --- openlp/core/lib/projector/db.py 2017-05-20 05:51:58 + > +++ openlp/core/lib/projector/db.py 2017-05-27 18:29:46 + > @@ -243,7 +244,9 @@ > """

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/saved_bible_verses into lp:openlp

2017-05-30 Thread Phill
ng is that you could build up a list of verses, possibly from different places in the bible, and present them as one item. I think it should be down to the user to decided if they want to add duplicate verses. How often would you add all the search results as a service item? --

Re: [Openlp-core] [Merge] lp:~trb143/openlp/themecleanup into lp:openlp

2017-05-30 Thread Phill
> I presume at some point we will drop support for XML themes altogether? I'd > like to see a TODO, comment suggesting when we can drop it. i.e. # TODO: xml > theme loading code can be removed after OpenLP 2.8 has been released. But otherwise this looks good. Not tested tho! -- https://code.launc

Re: [Openlp-core] [Merge] lp:~trb143/openlp/themecleanup into lp:openlp

2017-05-30 Thread Phill
Review: Needs Information I presume at some point we will drop support for XML themes altogether? I'd like to see a TODO, comment suggesting when we can drop it. i.e. # TODO: xml theme loading code can be removed after OpenLP 2.8 has been released. -- https://code.launchpad.net/~trb143/openlp/t

[Openlp-core] [Bug 1660480] Re: Filetype OSZL is not named in Windows Registry

2017-05-29 Thread Phill
** Changed in: openlp Importance: Undecided => Low -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1660480 Title: Filetype OSZL is not named in Windows Registry Status in OpenLP: New Bug descri

[Openlp-core] [Bug 1660478] Re: Opening recent file does not prompt to save changes

2017-05-29 Thread Phill
** Changed in: openlp Importance: Undecided => Medium -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1660478 Title: Opening recent file does not prompt to save changes Status in OpenLP: New Bu

[Openlp-core] [Bug 1674363] Re: Inconsistent action with middle/right click

2017-05-29 Thread Phill
I've marked it as low, as somebody have a look at this. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1674363 Title: Inconsistent action with middle/right click Status in OpenLP: New Bug descrip

[Openlp-core] [Bug 1674363] Re: Inconsistent action with middle/right click

2017-05-29 Thread Phill
** Changed in: openlp Importance: Undecided => Low -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1674363 Title: Inconsistent action with middle/right click Status in OpenLP: New Bug descripti

[Openlp-core] [Bug 1674387] Re: Display all song slides (panic button)

2017-05-29 Thread Phill
Something like a verse order override? ** Changed in: openlp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1674387 Title: Display all song slides (panic button)

[Openlp-core] [Bug 1676469] Re: Feature Request: (Un)Freeze

2017-05-29 Thread Phill
Could you expand on this please? The workflow that (I think you are requesting) can be achieved by queuing the item up in the preview controller and then sending that live. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.l

[Openlp-core] [Bug 1676472] Re: Expand Scripture selections

2017-05-29 Thread Phill
** Changed in: openlp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1676472 Title: Expand Scripture selections Status in OpenLP: New Bug description: New w

[Openlp-core] [Bug 1679199] Re: Wishlist: Custom Slide Header

2017-05-29 Thread Phill
** Changed in: openlp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1679199 Title: Wishlist: Custom Slide Header Status in OpenLP: New Bug description: New

[Openlp-core] [Merge] lp:~phill-ridout/openlp/saved_bible_verses into lp:openlp

2017-05-26 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/saved_bible_verses into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/saved_bible_verses/+merge/324674 Merged in trunk Adds more flexibility to 'locking&#

[Openlp-core] [Merge] lp:~phill-ridout/openlp/saved_bible_verses into lp:openlp

2017-05-26 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/saved_bible_verses into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/saved_bible_verses/+merge/323727 -- Your team OpenLP Core is subscribed to bra

[Openlp-core] [Merge] lp:~phill-ridout/openlp/path_edit into lp:openlp

2017-05-22 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/path_edit into lp:openlp. Requested reviews: Tomas Groth (tomasgroth) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/path_edit/+merge/324434 Add a custom widget for editing and selecting paths

[Openlp-core] [Merge] lp:~phill-ridout/openlp/path_edit into lp:openlp

2017-05-22 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/path_edit into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/path_edit/+merge/324432 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/path_edit into lp:openlp

2017-05-22 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/path_edit into lp:openlp. Requested reviews: Tim Bentley (trb143) Tomas Groth (tomasgroth) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/path_edit/+merge/324432 Add a custom widget for editing and selecting paths

[Openlp-core] [Merge] lp:~phill-ridout/openlp/path_edit into lp:openlp

2017-05-22 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/path_edit into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/path_edit/+merge/324409 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/path_edit into lp:openlp

2017-05-22 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/path_edit into lp:openlp. Requested reviews: Tim Bentley (trb143) Tomas Groth (tomasgroth) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/path_edit/+merge/324409 Add a custom widget for editing and selecting paths

[Openlp-core] [Merge] lp:~phill-ridout/openlp/path_edit into lp:openlp

2017-05-22 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/path_edit into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/path_edit/+merge/324026 -- Your team OpenLP Core is subscribed to branch lp:ope

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/import-depreciations into lp:openlp

2017-05-22 Thread Phill
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/import-depreciations/+merge/324045 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/import-depreciations into lp:openlp

2017-05-22 Thread Phill
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/import-depreciations/+merge/324045 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core

[Openlp-core] [Bug 1687467] Re: Display problems for hidpi laptops

2017-05-22 Thread Phill
** Changed in: openlp Importance: Undecided => Low -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1687467 Title: Display problems for hidpi laptops Status in OpenLP: New Bug description: OS

[Openlp-core] [Bug 1692187] Re: [Regression] Presentations/Images with same name gets the same thumbnail

2017-05-22 Thread Phill
** Changed in: openlp Importance: Undecided => Low -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1692187 Title: [Regression] Presentations/Images with same name gets the same thumbnail Status

[Openlp-core] [Bug 1692187] [NEW] [Regression] Presentations/Images with same name gets the same thumbnail

2017-05-20 Thread Phill
Public bug reported: Part of this bug has been regressed! In the presentations plugin, openlp.plugins.presentations.lib.presentationcontroller.PresentationDocument#get_thumbnail_folder and openlp.plugins.presentations.lib.presentationcontroller.PresentationDocument#get_temp_folder where not ch

[Openlp-core] [Merge] lp:~phill-ridout/openlp/import-depreciations into lp:openlp

2017-05-15 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/import-depreciations into lp:openlp. Requested reviews: Tim Bentley (trb143) Phill (phill-ridout) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/import-depreciations/+merge/324045 Fix the depreciated code, and

[Openlp-core] [Merge] lp:~phill-ridout/openlp/import-depreciations into lp:openlp

2017-05-15 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/import-depreciations into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/import-depreciations/+merge/324025 -- Your team OpenLP Core is subscribed to bra

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/import-depreciations into lp:openlp

2017-05-14 Thread Phill
Review: Needs Fixing -- https://code.launchpad.net/~phill-ridout/openlp/import-depreciations/+merge/324025 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/path_edit into lp:openlp

2017-05-14 Thread Phill
I had merged with trunk, but forgot to update trunk! -- https://code.launchpad.net/~phill-ridout/openlp/path_edit/+merge/324026 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

<    1   2   3   4   5   6   7   8   9   10   >