The proposal to merge lp:~alisonken1/openlp/pjlink2-q into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-q/+merge/343669
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Approve
--
https://code.launchpad.net/~alisonken1/openlp/pjlink2-q/+merge/343669
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
Looks good to me. Thanks!
--
https://code.launchpad.net/~alisonken1/openlp/pjlink2-q/+merge/343669
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Ken Roberts has proposed merging lp:~alisonken1/openlp/pjlink2-q into lp:openlp.
Commit message:
PJLink2 update Q
Requested reviews:
Tim Bentley (trb143)
Phill (phill-ridout)
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-q/+merge/343669
PJLink2 update Q
The proposal to merge lp:~alisonken1/openlp/pjlink2-q into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-q/+merge/343668
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Ken Roberts has proposed merging lp:~alisonken1/openlp/pjlink2-q into lp:openlp.
Commit message:
PJLink2 update Q
Requested reviews:
Phill (phill-ridout)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-q/+merge/343668
PJLink2 update Q
The proposal to merge lp:~alisonken1/openlp/pjlink2-q into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-q/+merge/342022
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Needs Fixing
A few issues / questions. See in line.
Diff comments:
>
> === modified file 'openlp/core/projectors/editform.py'
> --- openlp/core/projectors/editform.py2017-12-29 09:15:48 +
> +++ openlp/core/projectors/editform.py2018-03-24 08:24:22 +
> @@ -58,10
Review: Approve
Looks OK but projectors is not my strong point.
--
https://code.launchpad.net/~alisonken1/openlp/pjlink2-q/+merge/342022
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post
Ken Roberts has proposed merging lp:~alisonken1/openlp/pjlink2-q into lp:openlp.
Commit message:
PJLink2 update Q
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-q/+merge/342022
PJLink2 update Q
The proposal to merge lp:~alisonken1/openlp/pjlink2-q into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-q/+merge/341563
--
Your team OpenLP Core is subscribed to branch lp:openlp.
which fix is clashing? I tried a merge from trunk and it merged fine.
--
https://code.launchpad.net/~alisonken1/openlp/pjlink2-q/+merge/341563
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
> Sorry will clash with one of my fixes which has been merged
>
> See question
>> 'ACKN': {'version': ['2', ],
>> + 'default': '2',
>Why do we have a missing slot?
2 new commands in PJLink are only valid for version 2 and have no version 1
equivalent.
Missing slot is to
Review: Needs Fixing
Sorry will clash with one of my fixes which has been merged
See question
Diff comments:
>
> === modified file 'openlp/core/projectors/constants.py'
> --- openlp/core/projectors/constants.py 2018-01-03 00:35:14 +
> +++ openlp/core/projectors/constants.py
Ken Roberts has proposed merging lp:~alisonken1/openlp/pjlink2-q into lp:openlp.
Commit message:
PJLink2 update Q
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-q/+merge/341563
PJLink2 update Q
15 matches
Mail list logo
