I confirm it to be working.
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.la
I think Launchpad is being idiotic again. I've both pushed and branched from
that branch.
https://bazaar.launchpad.net/~raoul-snyman/openlp/fix-circ-deps/files
https://bazaar.launchpad.net/~raoul-snyman/openlp/fix-circ-deps/revision/2838?start_revid=2838
Try lp:~raoul-snyman/openlp/fix-circ
Your branch is empty.
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpa
Sure. Just a moment...
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchp
Hey Bastian, I tried removing the imports in lib/__init__.py and then using
direct imports in the other files, and it seems to have worked. Do you want to
try my branch and see if it works on your computer as well?
https://code.launchpad.net/~raoul-snyman/openlp/fix-circ-deps
--
https://code.
Yes, please post the stacktrace, I'd like see what's going on there.
And I'll fix the code coverage to use pytest.
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Right, CI runs nose2:
https://ci.openlp.io/job/Trunk-04b-Test_Coverage/369/console
On my main development machine (Arch Linux) pytest actually segfaults on some
test. If you are interested I can post the stacktrace somewhere.
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+m
Tim means pytest, not pylint. But if there's a problem that nose2 shows, we
should fix it.
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https
It may be explained by the fact that you are using nose2 for the tests.
Most of the devs and Jenkins have move to pylint!
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Your team OpenLP Core is subscribed to branch lp:openlp.
_
To be honest, I never actually came across this in CI. Perhaps a test was being
skipped? How did you come across it?
My mail server uses DMARC and friends, and your mail server probably rejects
the e-mails from Launchpad because they're not actually from me. At least
that's what I guess might b
By the way: I never get info mail about Raoul's comments. Do you know what
causes launchpad not to send them?
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Sure, it is kind of a hack. But it is better to have a working CI with a hack
as long as this is not fixed properly. It annoys me even though I only work for
a short time in the openlp code.
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Your team OpenLP Core is
I kinda agree with Tim, I think I'd rather figure out if there's a way we can
remove the circular dependency, rather than just adding an import to
short-circuit it.
I'll see if I can poke around in there tonight.
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Y
Review: Needs Fixing
Needs fixing correctly as that is a hack and bigger problem waiting to trip us
up.
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Maili
The test imports o.p.c.forms.editcustomform.EditCustomForm which imports
something from o.p.c.lib that in turn wants to import EditCustomForm. That is a
circular dependency.
As the added line (__init__.py) is implicitly executed on all o.p.c.forms*
imports, o.p.c.lib is imported before any o.p.
Hey Bastian,
Can you just explain to me how the line you added to an otherwise "empty" file
solves the problem? I'm curious, as it doesn't make sense to me (even though it
clearly works!), and I'm confused :-(
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Your
Bastian Germann has proposed merging lp:~bastian-germann/openlp/fix-circ-dep
into lp:openlp.
Commit message:
Fix a circular dependency that is hit when you run
tests.interfaces.openlp_plugins.custom.forms.test_customform:
ImportError: Failed to import test module:
tests.interfaces.openlp_plugi
The proposal to merge lp:~bastian-germann/openlp/fix-circ-dep into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357597
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Needs Fixing
Need to convert to a correct From statement. Blanket imports are not used in
openlp code.
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357597
Your team OpenLP Core is subscribed to branch lp:openlp.
Bastian Germann has proposed merging lp:~bastian-germann/openlp/fix-circ-dep
into lp:openlp.
Commit message:
Fix a circular dependency that is hit when you run
tests.interfaces.openlp_plugins.custom.forms.test_customform:
ImportError: Failed to import test module:
tests.interfaces.openlp_plugi
20 matches
Mail list logo
