[Openlp-core] [Merge] lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp

2019-06-25 Thread noreply
The proposal to merge lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview/+merge/369062 -- Your team

[Openlp-core] [Merge] lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp

2019-06-25 Thread Tim Bentley
The proposal to merge lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp has been updated. Commit message changed to: #1832874 changed songsplugin.py from `is true` to `== True` to force the deletion of temporary song records in the database on closing OpenLP. This

Re: [Openlp-core] [Merge] lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp

2019-06-25 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview/+merge/369062 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp

2019-06-25 Thread Tomas Groth
Review: Approve -- https://code.launchpad.net/~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview/+merge/369062 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp

2019-06-21 Thread Raoul Snyman
Review: Approve Technically you are supposed to have a test included, but for this first time I'll let it pass. -- https://code.launchpad.net/~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview/+merge/369062 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp

2019-06-19 Thread Johnthan
Johnthan has proposed merging lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1832874 in OpenLP: "Temporary songs appear in the 'Delete Duplicate songs' wizard"

[Openlp-core] [Merge] lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp

2019-06-19 Thread Johnthan
The proposal to merge lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview/+merge/369061 -- Your team

[Openlp-core] [Merge] lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp

2019-06-19 Thread Johnthan
Johnthan has proposed merging lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1832874 in OpenLP: "Temporary songs appear in the 'Delete Duplicate songs' wizard"

[Openlp-core] [Merge] lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp

2019-06-19 Thread Johnthan
The proposal to merge lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview/+merge/369012 -- Your team

[Openlp-core] [Merge] lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp

2019-06-18 Thread Johnthan
Johnthan has proposed merging lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1832874 in OpenLP: "Temporary songs appear in the 'Delete Duplicate songs' wizard"