Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-20 Thread Andreas Preikschat
Review: Approve -- https://code.launchpad.net/~sam92/openlp/fix-songbook-search/+merge/216341 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-20 Thread Andreas Preikschat
The proposal to merge lp:~sam92/openlp/fix-songbook-search into lp:openlp has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~sam92/openlp/fix-songbook-search/+merge/216341 --

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-20 Thread noreply
The proposal to merge lp:~sam92/openlp/fix-songbook-search into lp:openlp has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~sam92/openlp/fix-songbook-search/+merge/216341 --

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-17 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-songbook-search into lp:openlp. Requested reviews: Tim Bentley (trb143) Related bugs: Bug #1306958 in OpenLP: Song Book search broken https://bugs.launchpad.net/openlp/+bug/1306958 For more details, see:

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-17 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~sam92/openlp/fix-songbook-search/+merge/216341 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-16 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~sam92/openlp/fix-songbook-search/+merge/215978 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-16 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-songbook-search into lp:openlp. Requested reviews: Tim Bentley (trb143) Related bugs: Bug #1306958 in OpenLP: Song Book search broken https://bugs.launchpad.net/openlp/+bug/1306958 For more details, see:

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-16 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/fix-songbook-search into lp:openlp has been updated. Description changed to: Fix Songbook search lp:~sam92/openlp/fix-songbook-search (revision 2357) [SUCCESS] http://ci.openlp.org/job/Branch-01-Pull/354/ [SUCCESS]

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-16 Thread Samuel Mehrbrodt
Hm somehow on Windows it can't handle UTF-8 filenames: File Z:\var\lib\jenkins\projects\openlp\branch\openlp\plugins\songs\lib\openlyricsimport.py, line 72, in do_import parsed_file = etree.parse(open(file_path, 'rb'), parser) nose.proxy.FileNotFoundError: [Errno 2] No such file or

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-15 Thread Raoul Snyman
What Andreas said... -- https://code.launchpad.net/~sam92/openlp/fix-songbook-search/+merge/215243 Your team OpenLP Core is requested to review the proposed merge of lp:~sam92/openlp/fix-songbook-search into lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-15 Thread Samuel Mehrbrodt
The file_import_test fails and I don't know why. Can someone help me out there? -- https://code.launchpad.net/~sam92/openlp/fix-songbook-search/+merge/215978 Your team OpenLP Core is requested to review the proposed merge of lp:~sam92/openlp/fix-songbook-search into lp:openlp.

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-15 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-songbook-search into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1306958 in OpenLP: Song Book search broken https://bugs.launchpad.net/openlp/+bug/1306958 For more details, see:

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-12 Thread Andreas Preikschat
Could you extend the tests please? It's not really testing something. -- https://code.launchpad.net/~sam92/openlp/fix-songbook-search/+merge/215243 Your team OpenLP Core is requested to review the proposed merge of lp:~sam92/openlp/fix-songbook-search into lp:openlp.

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-10 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-songbook-search into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-songbook-search/+merge/215099 Fix Songbook search [SUCCESS]

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbook-search into lp:openlp

2014-04-10 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-songbook-search into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-songbook-search/+merge/215243 Fix Songbook search [SUCCESS]