Re: [Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-21 Thread Jonathan Corwin
Out of curiosity, why have you made all the files executable? -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/15118 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-15 Thread Raoul Snyman
Review: Approve Looks good! Nice catch on the .append! I think you might even be able to lose the \'s... verse = u'Amazing Grace!\n' u'How sweet the sound\n' u'To save a wretch like me;\n' u'I once was lost but now am found,\n' u'Was blind, but now I see.' --

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-11-15 Thread noreply
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14880 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-10 Thread Raoul Snyman
Review: Approve I see we're still going with multiple toolbars, but they seem to be sane :-) -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14684 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-09 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) More slidecontroller cleanups. Stop Preview of media splatting the display. Make the live toolbar a sensible size again. --

Re: [Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-09 Thread Tim Bentley
Added code to allow media previews -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14650 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-09 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14662 Your team OpenLP Core is subscribed to branch lp:openlp. === modified file

Re: [Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-08 Thread Raoul Snyman
Review: Approve Well, if I could see more than the resource file, I might have had some issues, but since I can't, you're fortunate to have evaded the Fly Eye. -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14616 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-08 Thread Jonathan Corwin
Should that \xf5 about three quarters of the way down be \xf6? ;) -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14616 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-11-08 Thread noreply
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14616 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-08 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Fix bugs in previous merges and set the size policy correctly. -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14620 Your team OpenLP Core is subscribed to

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-08 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman): -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14621 Your team OpenLP Core is subscribed to branch lp:openlp. === modified file

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-11-08 Thread noreply
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14621 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-07 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Remove Can_be_disabled as no longer require Sort out status handling in plugin form. -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14579 Your team OpenLP

Re: [Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-07 Thread Jon Tibble
Review: Approve Looks good and works for me. -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14586 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-04 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: Jon Tibble (meths) Fix remote song editing generation of error messages -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14433 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-03 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Clean up song editing Fix wonky expansion in service manager -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14378 Your team OpenLP Core is subscribed to

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-11-02 Thread noreply
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14308 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-11-01 Thread Raoul Snyman
Review: Approve Nice! -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14284 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-10-30 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Fixes Amend theme file handing works better Renderer cleans up on change of images better Save Preview is now optional - this makes ServiceItem editing work better

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-10-30 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Superseded -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14242 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-10-30 Thread noreply
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14243 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-10-29 Thread Raoul Snyman
Review: Approve Looks fine to me. -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14138 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-10-29 Thread noreply
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14139 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-10-29 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Initial version of edit songs and custom from service item. Works fine but unable to hide edit menu item as it messes up all mouse events. Code commented out till we

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-10-29 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14166 Your team OpenLP Core is subscribed to branch lp:openlp. === modified file

Re: [Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-10-29 Thread Jon Tibble
Review: Approve Looks okay. Note typo in doctext for future patch. -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14166 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-10-29 Thread noreply
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14166 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-10-29 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Minor fixes to improve usage -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14178 Your team OpenLP Core is subscribed to branch lp:openlp. === modified file

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-10-29 Thread noreply
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/14178 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-10-25 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Superseded -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/13899 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-10-25 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/13911 Your team OpenLP Core is subscribed to branch lp:openlp. === modified file 'openlp-1to2-converter.py'

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-10-25 Thread noreply
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/13911 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-10-25 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Clean up conversion code changed in error More audit work but still incomplete New Context menu for ServiveItems allowing themes to the changed at run time. Handles

Re: [Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-10-25 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/13917 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-10-25 Thread noreply
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/13921 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-10-24 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Superseded -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/13886 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-10-24 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Maintain position on slidecontroller when editing and redisplaying songs -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/13899 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp

2009-10-23 Thread Raoul Snyman
Review: Approve This might just break that biggest merge evar! :-P -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/13857 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

[Openlp-core] [Merge] lp:~trb143/openlp/fixes into lp:openlp updated

2009-10-23 Thread noreply
The proposal to merge lp:~trb143/openlp/fixes into lp:openlp has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~trb143/openlp/fixes/+merge/13857 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: