Review: Approve
--
https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365811
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365811
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365811
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Fixing
Please remove the media changes.
--
https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365765
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
Spoke to superfly last night Qt 5.12 is fine!
--
https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365421
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
But if you do not have a defined set of mandatory packages you would have to
insert suh a check for every non-core-python package that you import. What an
ugly code would that make for!
--
https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365421
Your team OpenLP Core is
No, the package can be removed even though you have setup.py which only you use.
Packages can be removed by accident and then will go bang.
Please do not change code which is fitting to a supported defensive pattern.
--
https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365421
Your
Why do they break OpenLP? pymediainfo is marked in setup.py as mandatory
dependency. Or do you mean the i18n string?
--
https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365421
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Needs Fixing
Please remove the video code changes as they break OpenLP and do not provide an
acceptable user experience.
Diff comments:
> === modified file 'openlp/core/ui/media/mediacontroller.py'
> --- openlp/core/ui/media/mediacontroller.py 2019-02-14 15:09:09 +
> +++
Instead of running python3 -m pytest in MP-04-macOS-Tests it could be changed
to python3 setup.py test. This would take care of any dependencies and they
would not have to be installed manually every time a dependency changes.
--
openlp/core/ui/style.py uses qdarkstyle.
--
https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365379
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
See inline comment about wrong minimum version of Qt
Diff comments:
>
> === modified file 'scripts/check_dependencies.py'
> --- scripts/check_dependencies.py 2019-02-14 15:09:09 +
> +++ scripts/check_dependencies.py 2019-04-02 00:15:48 +
> @@ -40,8 +40,8 @@
Review: Needs Fixing
As noted above there is some lint errors that must be fixed.
I noticed you imported qdarkstyle, but it is not used anywhere? I assume it
must be activated using a new setting? (I admit I have not run this branch)
--
13 matches
Mail list logo
