Azaziah has proposed merging
lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Tomas Groth (tomasgroth)
Related bugs:
Bug #805082 in OpenLP: "[windows] F1 shortcut does not work"
Review: Approve
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/308660
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
See below
Diff comments:
>
> === modified file 'openlp/core/lib/__init__.py'
> --- openlp/core/lib/__init__.py 2016-08-12 19:16:12 +
> +++ openlp/core/lib/__init__.py 2016-10-17 04:44:46 +
> @@ -310,30 +310,23 @@
>
> def
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/307572
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
The proposal to merge
lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc into lp:openlp
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/307572
--
Your team
Review: Approve
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/307572
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
Sorry conflicts with trunk.
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/307572
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
The proposal to merge
lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc into lp:openlp
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/307572
--
Your team
** Changed in: openlp
Status: In Progress => Fix Committed
** Changed in: openlp
Milestone: None => 2.5.1
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1612187
Title:
Changing shortcut
** Changed in: openlp
Status: In Progress => Fix Committed
** Changed in: openlp
Milestone: None => 2.5.1
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1616441
Title:
Missing in String
** Changed in: openlp/trunk
Status: In Progress => Fix Committed
** Changed in: openlp/trunk
Milestone: None => 2.5.1
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1294111
Title:
** Changed in: openlp
Milestone: None => 2.5.1
** Changed in: openlp
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1497637
Title:
Escape item does
** Changed in: openlp
Status: In Progress => Fix Committed
** Changed in: openlp
Milestone: 1.9.7 => 2.5.1
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/805082
Title:
[windows] F1
The proposal to merge
lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/307572
--
Your team
Answered to trb143's notes.
Diff comments:
>
> === modified file 'openlp/core/lib/__init__.py'
> --- openlp/core/lib/__init__.py 2016-08-12 19:16:12 +
> +++ openlp/core/lib/__init__.py 2016-10-17 04:44:46 +
> @@ -310,30 +310,23 @@
>
> def
Review: Approve
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/308660
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
>The problem with the word "and" is that in English "," is used before
>it, where as in many other languages "," is never used before "and". To
>make it even more complicated there's no "," before and if the list
>only has two items.
Actually, it depends on the person. I personally hold to "no
19 matches
Mail list logo
