Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-16 Thread Phill
Review: Needs Fixing One small typo, and a couple comments that need changing. Diff comments: > === modified file 'openlp/core/common/__init__.py' > --- openlp/core/common/__init__.py2018-02-24 16:10:02 + > +++ openlp/core/common/__init__.py2018-04-16 11:33:07 + > @@ -44,7 +44,7

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-16 Thread Phill
> One small typo, and a couple comments that need changing. Sorry! -- https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343306 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-16 Thread Simon Hanna
I wonder what the reason behind replacing vertial tabs with new lines is... Looking at where the regex is being used I'm inclined to say the whole thing needs to be reworked. It's also used in the filename cleaning where linefeeds are strange, but then again I don't know what the input always

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-16 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343277 -- Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-16 Thread Phill
Review: Needs Fixing I've done some research in to this. Officially the only code points allowed are: " [2] Char ::= #x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x1-#x10] /* any Unicode character, excluding the surrogate blocks, FFFE, and . */ " (