Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-17 Thread Tim Bentley
Review: Approve Looks good to me. -- https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343465 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-17 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp. Requested reviews: Phill (phill-ridout) Tim Bentley (trb143) Related bugs: Bug #1727517 in OpenLP: "Unicode control chars causes song importer to crash" https://bugs.launchpad.net/openlp/+bug/1727517

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-17 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343422 -- Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-17 Thread Tim Bentley
Review: Needs Fixing See comments inline lp:~thelinuxguy/openlp/fix-newline-bug (revision 2822) https://ci.openlp.io/job/Branch-01-Pull/2502/ [SUCCESS] https://ci.openlp.io/job/Branch-02a-Linux-Tests/2403/ [SUCCESS]

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-17 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp. Requested reviews: Phill (phill-ridout) Tim Bentley (trb143) Related bugs: Bug #1727517 in OpenLP: "Unicode control chars causes song importer to crash" https://bugs.launchpad.net/openlp/+bug/1727517

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-17 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343306 -- Your team OpenLP Core is subscribed to branch lp:openlp.