Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/wix-packaging into lp:openlp/packaging

Review: Needs Fixing See inline Diff comments: > > === modified file 'builders/windows-builder.py' > --- builders/windows-builder.py 2019-03-13 21:00:05 + > +++ builders/windows-builder.py 2019-05-07 05:01:47 + > @@ -315,11 +403,10 @@ >

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/wix-packaging into lp:openlp/packaging

Replies inline :-) Diff comments: > > === modified file 'builders/windows-builder.py' > --- builders/windows-builder.py 2019-03-13 21:00:05 + > +++ builders/windows-builder.py 2019-05-07 05:01:47 + > @@ -315,11 +403,10 @@ > copy(os.path.join(self.mutool_exe),

[Openlp-core] Linux Test Results: Passed

Linux tests passed! -- https://code.launchpad.net/~bastian-germann/openlp/main/+merge/367156 Your team OpenLP Core is requested to review the proposed merge of lp:~bastian-germann/openlp/main into lp:openlp. ___ Mailing list:

[Openlp-core] macOS Test Results: Failed

macOS tests failed, please see https://ci.openlp.io/job/MP-04-macOS-Tests/77/ for more details -- https://code.launchpad.net/~bastian-germann/openlp/main/+merge/367156 Your team OpenLP Core is requested to review the proposed merge of lp:~bastian-germann/openlp/main into lp:openlp.

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/wix-packaging into lp:openlp/packaging

You can now use PyMuPDF instead of mupdf.exe -- https://code.launchpad.net/~raoul-snyman/openlp/wix-packaging/+merge/367013 Your team OpenLP Core is subscribed to branch lp:openlp/packaging. ___ Mailing list: https://launchpad.net/~openlp-core Post to

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/main into lp:openlp

Review: Needs Information Please explain to me again how PyInstaller will handle this, and how to use this approach in Debian? Remember, our users are not Python developers. I don't care how "unpythonic" run_openlp.py is, I care how practical it is. --

[Openlp-core] [Merge] lp:~bastian-germann/openlp/main into lp:openlp

Bastian Germann has proposed merging lp:~bastian-germann/openlp/main into lp:openlp. Commit message: Use start script __main__.py which enables 'python -m openlp' Requested reviews: OpenLP Core (openlp-core) For more details, see:

[Openlp-core] Linting: Passed

Linting passed! -- https://code.launchpad.net/~bastian-germann/openlp/main/+merge/367156 Your team OpenLP Core is requested to review the proposed merge of lp:~bastian-germann/openlp/main into lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~trb143/openlp/no_vlc into lp:openlp

The proposal to merge lp:~trb143/openlp/no_vlc into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/no_vlc/+merge/367067 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] Linux Test Results: Passed

Linux tests passed! -- https://code.launchpad.net/~trb143/openlp/no_vlc/+merge/367110 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] Linting: Passed

Linting passed! -- https://code.launchpad.net/~trb143/openlp/no_vlc/+merge/367111 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

[Openlp-core] Linux Test Results: Passed

Linux tests passed! -- https://code.launchpad.net/~trb143/openlp/no_vlc/+merge/367111 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] Linting: Failed

Linting failed, please see https://ci.openlp.io/job/MP-03-Linting/93/ for more details -- https://code.launchpad.net/~trb143/openlp/no_vlc/+merge/367110 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~trb143/openlp/no_vlc into lp:openlp

The proposal to merge lp:~trb143/openlp/no_vlc into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/no_vlc/+merge/367110 -- Your team OpenLP Core is subscribed to branch lp:openlp.