[Openlp-core] [Bug 1194314] Re: Feature Requests: Webpages Ad-Lib Bible Verses

2013-08-14 Thread Phill
I'm sorry for my earlier abruptness! -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1194314 Title: Feature Requests: Webpages Ad-Lib Bible Verses Status in OpenLP - Worship Presentation Software:

[Openlp-core] [Bug 1211913] Re: Issues importing Sunday Plus FIles

2013-08-14 Thread Phill
** Changed in: openlp/2.0 Status: Confirmed = In Progress ** Changed in: openlp/2.0 Assignee: (unassigned) = Phill (phill-ridout) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1211913

[Openlp-core] [Merge] lp:~phill-ridout/openlp/1211913_2.0 into lp:openlp/2.0

2013-08-14 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/1211913_2.0 into lp:openlp/2.0. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/1211913_2.0/+merge/180234 Fixes #1211913. The case of field names can change, so have taken

[Openlp-core] [Bug 1211913] Re: Issues importing Sunday Plus FIles

2013-08-14 Thread Phill
** Branch linked: lp:~phill-ridout/openlp/1211913_2.0 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1211913 Title: Issues importing Sunday Plus FIles Status in OpenLP - Worship Presentation

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1194610 into lp:openlp

2013-08-14 Thread Raoul Snyman
Review: Needs Fixing Same as the other merge proposal. What happens if the character encoding fails? Default to u'cp1252'. Also, (unrelated) test please. -- https://code.launchpad.net/~phill-ridout/openlp/1194610/+merge/178456 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~oliwee/openlp/HideBibleVerses into lp:openlp

2013-08-14 Thread Raoul Snyman
Review: Needs Fixing As Phil identified, the object name needs to be the same: 21 + self.display_verse_check_box.setObjectName(u'verse_display_check_box') Line 51 doesn't need to be blank. It's a short method, you're not increasing readability by adding it. For any code that is committed

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1209515_2.0 into lp:openlp/2.0

2013-08-14 Thread Raoul Snyman
Review: Needs Fixing 47 +Provide a work around for a bug in QFileDialog (#1209515) Can you just be specific and say this is for a Launchpad bug (I might think it is a PyQt4 bug). 63 + file_list = QtCore.QStringList() 73 + file_list.append(QtCore.QString(file)) Why? This is