I think there is really two parts to this bug.
1. We should validate the formatting tags when a user enters a song manually:
a) For 2.0 series think we should display a message box saying that the
formatting tags are invalid.
b) For trunk series, I was thinking it would be nice if we
1a) So the users can't leave the editor before fixing the malformed
tags? This would be the easiest solution, but not very user friendly.
The user should have the possibility to save a song every time, even
when it is malformed. Anyway, a message box should point out the user
that there is an
1a) So the users can't leave the editor before fixing the malformed
tags? This would be the easiest solution, but not very user friendly.
The user should have the possibility to save a song every time, even
when it is malformed. Anyway, a message box should point out the user
that there is an
1a) I see. So the best solution for 2.0 series would be a message box
when the user leaves the song editor, without let him out before he has
fixed the problem. I think with my quick'n'dirty function this should be
no too hard. I'll try that at the weekend.
2) I do not know anything about the
Public bug reported:
The OSIS import code is based on reading lines using regex, not XML-
parsing, which means that when trying to import a bible in OSIS format,
it wont work unless the line breaks are just right, which shouldn't be a
requirement for a XML format.
** Affects: openlp
Do you have any sample files? If so could you attach then please.
** Tags added: bible bible-import
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1215830
Title:
OSIS import is line/regex based,
The OSIS that comes out of mod2osis is not valid XML. If it were, we
would have used lxml.
** Changed in: openlp
Status: New = Invalid
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1215830
Not all OSIS xml comes from mod2osis...
And I'd still say this is a valid issue if valid a OSIS file can't be imported.
** Changed in: openlp
Status: Invalid = New
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
Tomas, is this a hypothetical bug It might not work if..., or have you
found an example OSIS Bible which didn't import?
If the latter, please attach it.
If the former then I'm sure we've got plenty of real bugs to fix before we
worry about code that might not work under situations that might
** Changed in: openlp
Status: New = Incomplete
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1215830
Title:
OSIS import is line/regex based, not XML based
Status in OpenLP - Worship
This is a real case. But I can't really attach/distribute the example because
this version isn't in public domain.
The problem has be worked around by converting into CSV, and it has been
imported that way instead, so the issue isn't high priority.
--
You received this bug notification because
Hi Tomas, you can e-mail it to any of the e-mail addresses on my
Launchpad.net profile page.
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1215830
Title:
OSIS import is line/regex based, not XML
Public bug reported:
OpenLP 2.0.2, Build 2165
When I edit a song and press the save button and open the song again for
editing, all lyrics are gone.
The verses are still there, but without lyrics inside.
I checked the database and there are no lyrics in this song anymore.
** Affects: openlp
The bug affects build 2159 to 2165. On 2158, the issue does not occur
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1216044
Title:
Lyrics will be deleteted when saving a song
Status in OpenLP -
Tim Bentley has proposed merging lp:~trb143/openlp/202-2 into lp:openlp/2.0.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1216044 in OpenLP: Lyrics will be deleteted when saving a song
https://bugs.launchpad.net/openlp/+bug/1216044
For more details, see:
** Changed in: openlp
Status: New = In Progress
** Changed in: openlp
Importance: Undecided = Critical
** Changed in: openlp
Milestone: None = 2.0.2
** Changed in: openlp
Assignee: (unassigned) = Tim Bentley (trb143)
** Branch linked: lp:~trb143/openlp/202-2
--
You
Review: Approve
This works for me.
--
https://code.launchpad.net/~trb143/openlp/202-2/+merge/181892
Your team OpenLP Core is requested to review the proposed merge of
lp:~trb143/openlp/202-2 into lp:openlp/2.0.
___
Mailing list:
The proposal to merge lp:~trb143/openlp/202-2 into lp:openlp/2.0 has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~trb143/openlp/202-2/+merge/181892
--
https://code.launchpad.net/~trb143/openlp/202-2/+merge/181892
Your team OpenLP Core is
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/202-2/+merge/181892
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~trb143/openlp/202-2 into lp:openlp/2.0 has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/202-2/+merge/181892
--
https://code.launchpad.net/~trb143/openlp/202-2/+merge/181892
Your team OpenLP Core is
** Branch linked: lp:openlp/2.0
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1216044
Title:
Lyrics will be deleteted when saving a song
Status in OpenLP - Worship Presentation Software:
In
** Changed in: openlp
Status: In Progress = Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1216044
Title:
Lyrics will be deleteted when saving a song
Status in OpenLP - Worship
22 matches
Mail list logo
