Re: [Openlp-core] [Merge] lp:~felipe-q/openlp/refactoring_fixes into lp:openlp

2014-01-10 Thread Phill
Hi Felipep, It is regrettable that trunk broke for windows with a recent merge, but the fact is that we don't have any/many Windows (or osx) developers to test each merge request. Hopefully issues like this in the future will be caught by an increased number of tests. Unfortunately as

Re: [Openlp-core] [Merge] lp:~felipe-q/openlp/refactoring_fixes into lp:openlp

2014-01-10 Thread Felipe Polo-Wood
All, You all are witnesses that I have been asked to write tests for my code and that I have complied; I have been asked to write tests for code that I didn't write, but touched, and I have complied; I have been asked to modify my code for aesthetic reasons, and I have complied (not too happy,

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/mupdf into lp:openlp

2014-01-10 Thread Tim Bentley
Review: Needs Fixing Looks great but in final testing came up with a problem Settings dialog - the tick box seems to use all three states. Tick box and type rubbish in to the file box. Press cancel and you get an error message - Not Correct. When the dialog reappears the light grey tick is