Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/media_ext_refactors into lp:openlp

2019-05-31 Thread Tim Bentley
Review: Needs Fixing Minor improvement please Diff comments: > > === modified file 'openlp/core/ui/media/mediacontroller.py' > --- openlp/core/ui/media/mediacontroller.py 2019-05-05 05:59:29 + > +++ openlp/core/ui/media/mediacontroller.py 2019-05-31 20:34:31 + > @@ -131,7 +106,8 @@

[Openlp-core] [Merge] lp:~phill-ridout/openlp/media_ext_refactors into lp:openlp

2019-05-31 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/media_ext_refactors into lp:openlp. Commit message: refactor media extensions Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/media_ext_refactors/+merge/368212 -- Your team

[Openlp-core] Linting: Passed

2019-05-31 Thread Raoul Snyman
Linting passed! -- https://code.launchpad.net/~phill-ridout/openlp/media_ext_refactors/+merge/368212 Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/media_ext_refactors into lp:openlp. ___ Mailing list:

[Openlp-core] macOS Test Results: Passed

2019-05-31 Thread Raoul Snyman
macOS tests passed! -- https://code.launchpad.net/~phill-ridout/openlp/media_ext_refactors/+merge/368212 Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/media_ext_refactors into lp:openlp. ___ Mailing list:

[Openlp-core] Linux Test Results: Passed

2019-05-31 Thread Raoul Snyman
Linux tests passed! -- https://code.launchpad.net/~phill-ridout/openlp/media_ext_refactors/+merge/368212 Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/media_ext_refactors into lp:openlp. ___ Mailing list: