Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/dependencies into lp:openlp

Review: Approve Looks ok to me... -- https://code.launchpad.net/~bastian-germann/openlp/dependencies/+merge/367931 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/presentation-beyond-last into lp:openlp

Review: Needs Fixing See line 189 for my main comment. Others are just me being nit-picky! Diff comments: > > === modified file 'openlp/plugins/presentations/lib/impresscontroller.py' > --- openlp/plugins/presentations/lib/impresscontroller.py 2019-05-22 > 06:47:00 + > +++

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/presentation-load-speedup into lp:openlp

Just a comment on implementation. Diff comments: > > === modified file 'openlp/core/ui/servicemanager.py' > --- openlp/core/ui/servicemanager.py 2019-05-24 18:50:51 + > +++ openlp/core/ui/servicemanager.py 2019-05-27 18:44:30 + > @@ -509,7 +510,8 @@ > service = [] >