[Openlp-core] [Bug 1842523] [NEW] trunk V2898 adding video file to Service causes errors

2019-09-03 Thread Johnthan
Public bug reported: Windows 10 32 bit trunk V2898 Single display with custom screen 1024x768 in OpenLP settings I loaded a small moving background in MPG format. I checked and the issue with not being able to edit a song is still valid. The media item was shown in the Library. I used Drag

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/main into lp:openlp

2019-09-03 Thread Tim Bentley
Review: Needs Fixing You have left the python3 construct in the openlp/__main__.py which leaves this as an entry point. Please confirm this is correct or remove. -- https://code.launchpad.net/~bastian-germann/openlp/main/+merge/368590 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/main into lp:openlp

2019-09-03 Thread Bastian Germann
Hey! I would really like to see this merged before the alpha. See also https://www.python.org/dev/peps/pep-0423/#use-a-single-name on exporting only one package per module. If you merge this, I am going to provide an openlp package via PyPI and propose a new installation method that does not

Re: [Openlp-core] [Merge] lp:~john+ubuntu-g/openlp/singingthefaith into lp:openlp

2019-09-03 Thread Tomas Groth
Review: Needs Fixing Hi John, sorry for mentioning this before, but the hint file should be placed in the folder openlp/plugins/songs/lib/importers/ If the user does not supply a hint file you can then load it from this path: AppLocation.get_directory(AppLocation.PluginsDir) / 'songs' / 'lib' /

[Openlp-core] Linting: Passed

2019-09-03 Thread Raoul Snyman
Linting passed! -- https://code.launchpad.net/~john+ubuntu-g/openlp/singingthefaith/+merge/372194 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] macOS Test Results: Passed

2019-09-03 Thread Raoul Snyman
macOS tests passed! -- https://code.launchpad.net/~john+ubuntu-g/openlp/singingthefaith/+merge/372194 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] Linux Test Results: Passed

2019-09-03 Thread Raoul Snyman
Linux tests passed! -- https://code.launchpad.net/~john+ubuntu-g/openlp/singingthefaith/+merge/372194 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] JavaScript Test Results: Passed

2019-09-03 Thread Raoul Snyman
JavaScript tests passed! -- https://code.launchpad.net/~john+ubuntu-g/openlp/singingthefaith/+merge/372194 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~john+ubuntu-g/openlp/singingthefaith into lp:openlp

2019-09-03 Thread John Lines
John Lines has proposed merging lp:~john+ubuntu-g/openlp/singingthefaith into lp:openlp. Commit message: Initial merge of SingingTheFaithImport, including update to importer.py Requested reviews: Raoul Snyman (raoul-snyman) Tomas Groth (tomasgroth) Phill (phill-ridout) For more details,

[Openlp-core] [Merge] lp:~john+ubuntu-g/openlp/singingthefaith into lp:openlp

2019-09-03 Thread John Lines
The proposal to merge lp:~john+ubuntu-g/openlp/singingthefaith into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~john+ubuntu-g/openlp/singingthefaith/+merge/372191 -- Your team OpenLP Core is subscribed to branch

Re: [Openlp-core] Linting: Failed

2019-09-03 Thread John Lines
> Linting failed, please see https://ci.openlp.io/job/MP-05-Linting/166/ for > more details now fixed - blank lines at end of test code -- https://code.launchpad.net/~john+ubuntu-g/openlp/singingthefaith/+merge/372191 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] Linting: Failed

2019-09-03 Thread Raoul Snyman
Linting failed, please see https://ci.openlp.io/job/MP-05-Linting/166/ for more details -- https://code.launchpad.net/~john+ubuntu-g/openlp/singingthefaith/+merge/372191 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] macOS Test Results: Passed

2019-09-03 Thread Raoul Snyman
macOS tests passed! -- https://code.launchpad.net/~john+ubuntu-g/openlp/singingthefaith/+merge/372191 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] Linux Test Results: Passed

2019-09-03 Thread Raoul Snyman
Linux tests passed! -- https://code.launchpad.net/~john+ubuntu-g/openlp/singingthefaith/+merge/372191 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] JavaScript Test Results: Passed

2019-09-03 Thread Raoul Snyman
JavaScript tests passed! -- https://code.launchpad.net/~john+ubuntu-g/openlp/singingthefaith/+merge/372191 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~john+ubuntu-g/openlp/singingthefaith into lp:openlp

2019-09-03 Thread John Lines
John Lines has proposed merging lp:~john+ubuntu-g/openlp/singingthefaith into lp:openlp. Commit message: Initial merge of SingingTheFaithImport, including update to importer.py Requested reviews: Tomas Groth (tomasgroth) Phill (phill-ridout) Raoul Snyman (raoul-snyman) For more details,

[Openlp-core] [Merge] lp:~john+ubuntu-g/openlp/singingthefaith into lp:openlp

2019-09-03 Thread John Lines
The proposal to merge lp:~john+ubuntu-g/openlp/singingthefaith into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~john+ubuntu-g/openlp/singingthefaith/+merge/372031 -- Your team OpenLP Core is subscribed to branch