[Openlp-core] [Bug 1171064] Re: Graphics issues with x11 bypass enabled in Ubuntu 13.04

2017-06-14 Thread Raoul Snyman
I'm closing this because it doesn't seem to be happening anymore. ** Changed in: openlp Status: Confirmed => Invalid -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1171064 Title: Graphics

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-e into lp:openlp

2017-06-09 Thread Raoul Snyman
Review: Needs Fixing Diff comments: > > === modified file 'openlp/core/ui/projector/manager.py' > --- openlp/core/ui/projector/manager.py 2017-05-27 18:21:24 + > +++ openlp/core/ui/projector/manager.py 2017-06-09 14:14:27 + > @@ -278,6 +279,10 @@ > """ > Manage

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/TODOne into lp:openlp

2017-06-09 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/TODOne/+merge/325201 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~suutari-olli/openlp/azaziah-fixes-and-improvements into lp:openlp

2017-06-08 Thread Raoul Snyman
Review: Approve Nicely done Olli! -- https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325102 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

Re: [Openlp-core] [Question #633171]: Background Video Support & 2.5.1

2017-06-05 Thread Raoul Snyman
Question #633171 on OpenLP changed: https://answers.launchpad.net/openlp/+question/633171 Raoul Snyman posted a new comment: Please see our wiki page: https://wiki.openlp.org/Development:Getting_Started -- You received this question notification because your team OpenLP Core is an answer

Re: [Openlp-core] [Merge] lp:~suutari-olli/openlp/azaziah-fixes-and-improvements into lp:openlp

2017-06-05 Thread Raoul Snyman
I'll test it out on my Mac. -- https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325053 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-04 Thread Raoul Snyman
Review: Disapprove We're moving away from Python generated HTML, and using a JS system based on Reveal.js. Come chat with tgc and myself in IRC. -- https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/325043 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~suutari-olli/openlp/azaziah-fixes-and-improvements into lp:openlp

2017-06-04 Thread Raoul Snyman
Review: Needs Fixing Just some minor things. Also, I really would prefer to see 1 new test, not just updates to tests. Diff comments: > > === modified file 'openlp/plugins/bibles/lib/mediaitem.py' > --- openlp/plugins/bibles/lib/mediaitem.py2017-05-07 18:39:17 + > +++

Re: [Openlp-core] [Merge] lp:~samothjtm/openlp/bug-1695587 into lp:openlp

2017-06-04 Thread Raoul Snyman
Once you've fixed up the issues, you'll need to resubmit the merge proposal (link in the top right hand corner) -- https://code.launchpad.net/~samothjtm/openlp/bug-1695587/+merge/325035 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~samothjtm/openlp/bug-1695587 into lp:openlp

2017-06-04 Thread Raoul Snyman
Here, I've fixed your issues for you and written a test for you. Next time it's on you. === modified file 'openlp/plugins/songs/lib/mediaitem.py' --- openlp/plugins/songs/lib/mediaitem.py 2017-06-03 10:44:28 + +++ openlp/plugins/songs/lib/mediaitem.py 2017-06-04 20:18:23 + @@

Re: [Openlp-core] [Merge] lp:~samothjtm/openlp/bug-1695587 into lp:openlp

2017-06-04 Thread Raoul Snyman
Review: Needs Fixing -- https://code.launchpad.net/~samothjtm/openlp/bug-1695587/+merge/325035 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~samothjtm/openlp/bug-1695587 into lp:openlp

2017-06-04 Thread Raoul Snyman
I've got a couple of comments below for you to take a look at. Also, as previously noted, you need a code test before we'll accept your merge proposal. I'm afraid that manual testing, while nice, does not constitute a test for merging purposes. Diff comments: > === modified file

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/test-fixes into lp:openlp

2017-06-03 Thread Raoul Snyman
Review: Approve Looks good to me. -- https://code.launchpad.net/~phill-ridout/openlp/test-fixes/+merge/325039 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Bug 1695587] Re: Entire Song doesn't search Song Number

2017-06-03 Thread Raoul Snyman
"Entire Song" searches most attributes on the song, not just the title and the lyrics. I can't remember exactly which attributes, I'd have to go back and look at the code. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

[Openlp-core] [Bug 1081577] Re: Support Visual Song Book Import

2017-06-03 Thread Raoul Snyman
It appears Visual Song Book is dead. The site ends in a dead redirect and there's no way to download the software. ** Changed in: openlp/trunk Status: New => Won't Fix -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-d into lp:openlp

2017-06-01 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-d/+merge/324978 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/TODOne into lp:openlp

2017-05-31 Thread Raoul Snyman
Review: Needs Fixing I'm afraid you have a conflict :-( Text conflict in openlp/core/ui/lib/pathedit.py -- https://code.launchpad.net/~phill-ridout/openlp/TODOne/+merge/324887 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Bug 1650910] Re: Not Handling OSErrors

2017-05-31 Thread Raoul Snyman
Actually, my point still stands. An exception dialog should not show up, we should inform the user of the problem instead. ** Changed in: openlp Status: Won't Fix => Confirmed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/add-assets into lp:openlp/branding

2017-05-31 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/add-assets into lp:openlp/branding. Requested reviews: Daniel Borges (danielborges93) OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/add-assets/+merge/324900 - Add pre-built macOS

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/packaging-osx-2.6 into lp:openlp/packaging

2017-05-31 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/packaging-osx-2.6 into lp:openlp/packaging. Requested reviews: Daniel Borges (danielborges93) OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/packaging-osx-2.6/+merge/324899 Change

[Openlp-core] [Bug 1694713] Re: FRW themes are xml based

2017-05-31 Thread Raoul Snyman
We should probably only do this once 2.6 has been released. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1694713 Title: FRW themes are xml based Status in OpenLP: New Bug description: The

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-d into lp:openlp

2017-05-31 Thread Raoul Snyman
Review: Needs Fixing One comment below, just a minor fix. As Tomas said, if those strings are going to be available to the user they should be translated. We don't need to worry about how stable the strings are yet, so just go ahead and do it now before we forget about them. Diff comments: >

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/TODOne into lp:openlp

2017-05-30 Thread Raoul Snyman
Review: Needs Fixing Just one minor edit. Diff comments: > > === modified file 'openlp/plugins/presentations/lib/powerpointcontroller.py' > --- openlp/plugins/presentations/lib/powerpointcontroller.py 2017-05-14 > 10:11:10 + > +++ openlp/plugins/presentations/lib/powerpointcontroller.py

Re: [Openlp-core] [Merge] lp:~gtalent/openlp/easyworship6 into lp:openlp

2017-05-22 Thread Raoul Snyman
Review: Approve I agree. -- https://code.launchpad.net/~gtalent/openlp/easyworship6/+merge/321504 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Question #633038]: Bible search on remote app and web not working

2017-05-19 Thread Raoul Snyman
Question #633038 on OpenLP changed: https://answers.launchpad.net/openlp/+question/633038 Status: Open => Needs information Raoul Snyman requested more information: Which remote app? The Android app or the iOS app? What version of OpenLP are you running (Help -> About)? -- You re

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/chords into lp:openlp

2017-05-17 Thread Raoul Snyman
Review: Approve I'm going to say yes to this. I've had a look through the code and nothing stands out to me as wrong. -- https://code.launchpad.net/~tomasgroth/openlp/chords/+merge/324210 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Question #632375]: ?here is mod2osis?

2017-05-13 Thread Raoul Snyman
Question #632375 on OpenLP changed: https://answers.launchpad.net/openlp/+question/632375 Status: Open => Answered Raoul Snyman proposed the following answer: E-Sword is not the SWORD Project. You need the SWORD Project. -- You received this question notification because your team Ope

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/refactor-mock into lp:openlp

2017-05-10 Thread Raoul Snyman
The proposal to merge lp:~raoul-snyman/openlp/refactor-mock into lp:openlp has been updated. Description changed to: Mock comes with Python as of 3.3, and I don't think there is anyone using lower than 3.3, so let's use Python's mock directly now. Windows tests are failing due to file sharing

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/refactor-mock into lp:openlp

2017-05-10 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/refactor-mock into lp:openlp. Commit message: Mock comes with Python as of 3.3, and I don't think there is anyone using lower than 3.3, so let's use Python's mock directly now. Requested reviews: Tim Bentley (trb143) For more details

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/refactor-mock into lp:openlp

2017-05-10 Thread Raoul Snyman
The proposal to merge lp:~raoul-snyman/openlp/refactor-mock into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/refactor-mock/+merge/323296 -- Your team OpenLP Core is subscribed to branch lp:ope

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/appveyor-update into lp:openlp

2017-05-05 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~tomasgroth/openlp/appveyor-update/+merge/323642 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/refactor-mock into lp:openlp

2017-05-03 Thread Raoul Snyman
Touche. I did this on the plane from Tucson to Raleigh :-) -- https://code.launchpad.net/~raoul-snyman/openlp/refactor-mock/+merge/323296 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post

[Openlp-core] [Bug 1688048] Re: CCLI SongSelect Login cancel

2017-05-03 Thread Raoul Snyman
** Changed in: openlp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1688048 Title: CCLI SongSelect Login cancel Status in OpenLP: New Bug description:

Re: [Openlp-core] [Merge] lp:~gtalent/openlp/easyworship6 into lp:openlp

2017-04-26 Thread Raoul Snyman
Hey Gary, Is there any way we'd be able to detect if we can ignore the first line? -- https://code.launchpad.net/~gtalent/openlp/easyworship6/+merge/321504 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/refactor-mock into lp:openlp

2017-04-26 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/refactor-mock into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/refactor-mock/+merge/323296 Mock comes with Python as of 3.3, and I don't think

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/update-macos-install into lp:openlp/documentation

2017-04-20 Thread Raoul Snyman
The proposal to merge lp:~raoul-snyman/openlp/update-macos-install into lp:openlp/documentation has been updated. Description changed to: - Update the macOS installation instructions - Change Mac OS X -> macOS - Update the FAQ a bit Thanks to "froggles" on https://forums.openlp.o

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/update-macos-install into lp:openlp/documentation

2017-04-20 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/update-macos-install into lp:openlp/documentation. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/update-macos-install/+merge/322811 Update the macOS installation

[Openlp-core] [Bug 1641617] Re: Window behind OpenLP logo after update prevents initialization

2017-04-02 Thread Raoul Snyman
Yes, I fixed it in 2.4.6. ** Changed in: openlp Assignee: (unassigned) => Raoul Snyman (raoul-snyman) ** Also affects: openlp/trunk Importance: Low Assignee: Raoul Snyman (raoul-snyman) Status: Confirmed ** Also affects: openlp/2.4 Importance: Undecided Status:

[Openlp-core] [Bug 1678632] [NEW] SongSelect Importer Infinite Loop

2017-04-02 Thread Raoul Snyman
Public bug reported: The SongSelect importer appears to go into an infinite loop when searching. Clicking the "Cancel" button stops the search though. See the following post on the forums: https://forums.openlp.org/discussion/comment/10171/#Comment_10171 ** Affects: openlp Importance: Low

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/website-openlp-2.4.6 into lp:openlp/website

2017-03-31 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/website-openlp-2.4.6 into lp:openlp/website. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/website-openlp-2.4.6/+merge/321632 Blog post for the 2.4.6 release

Re: [Openlp-core] [Merge] lp:~gtalent/openlp/easyworship6 into lp:openlp

2017-03-31 Thread Raoul Snyman
Hi Gary, One other thing. The person I imported their EW6 database for said that the importer added the title of each verse at the top of each verse, so Verse 1 would start with "Verse 1" and then the rest of the lines of the verse. I don't see anything like that in your code, but I thought

Re: [Openlp-core] [Merge] lp:~gtalent/openlp/easyworship6 into lp:openlp

2017-03-31 Thread Raoul Snyman
> That would iterate over every file and directory in the base EW6 directory Actually, it only iterates over every directory, not every file. It gives you a list of files, and you can either iterate over the files yourself (which is usually what people do with it), or you can just check if a

Re: [Openlp-core] [Merge] lp:~trb143/openlp/trans31032017 into lp:openlp/2.4

2017-03-31 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/trans31032017/+merge/321519 Your team OpenLP Core is subscribed to branch lp:openlp/2.4. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~gtalent/openlp/easyworship6 into lp:openlp

2017-03-30 Thread Raoul Snyman
I mean, it may be prudent. Don't you just love autocarrot... -- https://code.launchpad.net/~gtalent/openlp/easyworship6/+merge/321504 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

Re: [Openlp-core] [Merge] lp:~gtalent/openlp/easyworship6 into lp:openlp

2017-03-30 Thread Raoul Snyman
Review: Needs Fixing Hey Gary, there's an easier way to do your _find_files method. Use the os.walk() function. Also, if may be president to have a maximum depth just in case the user selected an incorrect directory. -- https://code.launchpad.net/~gtalent/openlp/easyworship6/+merge/321504

Re: [Openlp-core] [Merge] lp:~gtalent/openlp/easyworship6 into lp:openlp

2017-03-30 Thread Raoul Snyman
Review: Needs Fixing I agree with Tomas, this is great. I used it the other evening to convert a user's EW6 database, and it seemed to work perfectly. Again, just a few issues, and then we can merge this. Diff comments: > > === modified file

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/backport-fix into lp:openlp/2.4

2017-03-29 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~thelinuxguy/openlp/backport-fix/+merge/321379 Your team OpenLP Core is subscribed to branch lp:openlp/2.4. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/custom-shortcuts-2.4 into lp:openlp/2.4

2017-03-29 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/custom-shortcuts-2.4 into lp:openlp/2.4. Commit message: Disable the shortcut controls when an action has not been selected Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-author_type into lp:openlp

2017-03-27 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/fix-author_type into lp:openlp. Commit message: Fix the author_type import properly Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/fix-author_type/+merge/321138 Fix

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-author-type-2.4 into lp:openlp/2.4

2017-03-27 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/fix-author-type-2.4 into lp:openlp/2.4. Commit message: Fix the author_type import properly Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/fix-author-type-2.4/+merge

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-translations into lp:openlp

2017-03-27 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/fix-translations into lp:openlp. Commit message: Fix a problem with loading Qt's translation files, bug #1676163 Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1676163 in OpenLP: "Missing Qt 5 translations (OL

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-translations-2.4 into lp:openlp/2.4

2017-03-27 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/fix-translations-2.4 into lp:openlp/2.4. Commit message: Fix a problem with loading Qt's translation files, bug #1676163 Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1676163 in OpenLP: "Missing Qt 5 transla

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-translations-2.4 into lp:openlp/2.4

2017-03-27 Thread Raoul Snyman
The proposal to merge lp:~raoul-snyman/openlp/fix-translations-2.4 into lp:openlp/2.4 has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/fix-translations-2.4/+merge/321129 -- Your team OpenLP Core is reques

[Openlp-core] [Bug 1676163] Re: Missing Qt 5 translations (OLP 2.3 >)

2017-03-27 Thread Raoul Snyman
** Branch linked: lp:~raoul-snyman/openlp/fix-tr-packaging -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1676163 Title: Missing Qt 5 translations (OLP 2.3 >) Status in OpenLP: New

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-translations-2.4 into lp:openlp/2.4

2017-03-27 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/fix-translations-2.4 into lp:openlp/2.4. Commit message: Fix a problem with loading Qt's translation files, bug #1676163 Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1676163 in OpenLP: "Missing Qt 5 transla

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-translations-2.4 into lp:openlp

2017-03-27 Thread Raoul Snyman
The proposal to merge lp:~raoul-snyman/openlp/fix-translations-2.4 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/fix-translations-2.4/+merge/321128 -- Your team OpenLP Core is requested to rev

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-tr-packaging into lp:openlp/packaging

2017-03-27 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/fix-tr-packaging into lp:openlp/packaging. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1676163 in OpenLP: "Missing Qt 5 translations (OLP 2.3 >)" https://bugs.launchpad.net/openlp/+bug/1676163 For

Re: [Openlp-core] [Merge] lp:~trb143/openlp/trans230324 into lp:openlp/2.4

2017-03-24 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/trans230324/+merge/320864 Your team OpenLP Core is subscribed to branch lp:openlp/2.4. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Bug 1675641] [NEW] EasyWorship 6 uses SQLite

2017-03-24 Thread Raoul Snyman
Public bug reported: As of EasyWorship 6, EW now Uses SQLite as their database format. We don't support this yet. One of our users emailed us their EW database so that we can create an importer. ** Affects: openlp Importance: Undecided Status: New -- You received this bug

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/db-upgrades-2.6 into lp:openlp

2017-03-22 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/db-upgrades-2.6 into lp:openlp. Commit message: Various fixes and things: - Update SongSelect importer to handle changes to the SongSelect site - Fix PresentationManager importer to take weird XML into account - Fix OpenLP importer

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/db-upgrades-2.6 into lp:openlp

2017-03-22 Thread Raoul Snyman
The proposal to merge lp:~raoul-snyman/openlp/db-upgrades-2.6 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/db-upgrades-2.6/+merge/319632 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-db-upgrade-2.4 into lp:openlp/2.4

2017-03-22 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/fix-db-upgrade-2.4 into lp:openlp/2.4. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/fix-db-upgrade-2.4/+merge/320587 Revert the database upgrade, fix a few more

[Openlp-core] [Bug 1674473] [NEW] SOF importer doesn't support SOF6

2017-03-20 Thread Raoul Snyman
Public bug reported: Songs of Fellowship have released a new book, and with it a new SOF file complete with a new internal format which of course the SOF importer doesn't understand. We need to fix the SOF importer (again). See https://support.openlp.org/scp/tickets.php?id=4101 for more details

Re: [Openlp-core] [Question #576452]: "Latest" development version is obsolete?

2017-03-20 Thread Raoul Snyman
Question #576452 on OpenLP changed: https://answers.launchpad.net/openlp/+question/576452 Raoul Snyman posted a new comment: Hey Timothy, You can sign up to our mailing list here: https://lists.openlp.io/mailman/listinfo/openlp-dev Also, if you dare ;-) you can look at our wiki here: https

Re: [Openlp-core] [Question #576452]: "Latest" development version is obsolete?

2017-03-20 Thread Raoul Snyman
Question #576452 on OpenLP changed: https://answers.launchpad.net/openlp/+question/576452 Status: Open => Answered Raoul Snyman proposed the following answer: Hi Timothy, It is obsolete, you're right. Most of our energy has been focused on developing OpenLP, as opposed to setting

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/chords into lp:openlp

2017-03-19 Thread Raoul Snyman
I know you don't have a lot of time on your hands at the moment, but I'd really prefer to see more test coverage. You've written a bunch of new functions and only some of them are being (indirectly) tested. Diff comments: > > === modified file

[Openlp-core] [Bug 1674130] [NEW] QAction object does not support indexing

2017-03-19 Thread Raoul Snyman
Public bug reported: Reported via the support system: https://support.openlp.org/scp/tickets.php?id=4134 Traceback (most recent call last): File "openlp/core/ui/mainwindow.py", line 1107, in closeEvent File "openlp/core/ui/mainwindow.py", line 1129, in clean_up File

[Openlp-core] [Bug 1608194] Re: Import from SongSelect no longer works (website updated)

2017-03-18 Thread Raoul Snyman
Yes, we know. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1608194 Title: Import from SongSelect no longer works (website updated) Status in OpenLP: In Progress Status in OpenLP 2.4 series:

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website

2017-03-17 Thread Raoul Snyman
The proposal to merge lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/website-fixes/+merge/320271 -- Your team OpenLP Core is subscribed to branch

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website

2017-03-17 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~thelinuxguy/openlp/website-fixes/+merge/320271 Your team OpenLP Core is subscribed to branch lp:openlp/website. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website

2017-03-17 Thread Raoul Snyman
Just a couple of tweaks: Rather than removing .social-links from custom.css, change it to this: .social-links { text-align: center; } Then add this style too: .social-links li { margin: 10px; width: 54px; } While you're at it, add this in too, it gives the menu a dark background

Re: [Openlp-core] [Question #564970]: right click live item

2017-03-17 Thread Raoul Snyman
Question #564970 on OpenLP changed: https://answers.launchpad.net/openlp/+question/564970 Raoul Snyman posted a new comment: Hi Timothy, I had a look last night, and we'd basically have to intercept all mouse events, and then selectively ignore or engage them. Not hard, but not a simple switch

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website

2017-03-17 Thread Raoul Snyman
Review: Needs Fixing Hi Simon, I'm seeing this, did you forget to commit something? http://pasteboard.co/4Fkd03Jdf.png -- https://code.launchpad.net/~thelinuxguy/openlp/website-fixes/+merge/320184 Your team OpenLP Core is subscribed to branch lp:openlp/website.

Re: [Openlp-core] [Merge] lp:~mikey74/openlp/dvdplayerfix into lp:openlp

2017-03-17 Thread Raoul Snyman
Review: Needs Fixing Hi Mike, Thanks for your contribution! As per our merge criteria, you need a test in order for this to be merged into trunk. Also, you only added the fix to trunk, not to the 2.4 line, so if you wanted to see it in 2.4.6 then you'll need to backport these changes to the

[Openlp-core] [Bug 1672777] Re: Right click menu on expanded Service item always sends the first slide to Live

2017-03-17 Thread Raoul Snyman
** Changed in: openlp Importance: Undecided => Low -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1672777 Title: Right click menu on expanded Service item always sends the first slide to Live

[Openlp-core] [Bug 1673254] Re: Preview not updated after reordering Service Manager

2017-03-17 Thread Raoul Snyman
** Changed in: openlp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1673254 Title: Preview not updated after reordering Service Manager Status in OpenLP: New

[Openlp-core] [Bug 1673251] Re: Incorrect file type suggested for Save As

2017-03-17 Thread Raoul Snyman
This is not a bug, I've marked it as wishlist. ** Changed in: openlp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1673251 Title: Incorrect file type suggested

Re: [Openlp-core] [Question #564970]: right click live item

2017-03-16 Thread Raoul Snyman
Question #564970 on OpenLP changed: https://answers.launchpad.net/openlp/+question/564970 Status: Open => Answered Raoul Snyman proposed the following answer: Hi Timothy, It's more of an unintentional side-effect. The live list view control supports reacting to right and middle cli

[Openlp-core] [Bug 1672230] Re: "Volunteer" button link is broken

2017-03-13 Thread Raoul Snyman
** Branch linked: lp:~raoul-snyman/openlp/website-contribute -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1672230 Title: "Volunteer" button link is broken Status in OpenLP: New Bug d

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/website-contribute into lp:openlp/website

2017-03-12 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/website-contribute into lp:openlp/website. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1672230 in OpenLP: ""Volunteer" button link is broken" https://bugs.launchpad.net/openlp/+bug/1672230 F

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/db-upgrades-2.6 into lp:openlp

2017-03-11 Thread Raoul Snyman
I'm actually still working on this branch, trying to figure out what's causing the segfaults. If I uncomment those commented out lines I get a segfault :-( -- https://code.launchpad.net/~raoul-snyman/openlp/db-upgrades-2.6/+merge/319632 Your team OpenLP Core is subscribed to branch lp:openlp

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/db-upgrades-2.6 into lp:openlp

2017-03-10 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/db-upgrades-2.6 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/db-upgrades-2.6/+merge/319632 Fix a songselect bug, a bunch of database upgrade bugs

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/transifex-live into lp:openlp/website

2017-03-09 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/transifex-live into lp:openlp/website. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/transifex-live/+merge/319529 Add Transifex Live JS to the site so that we can

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/db-upgrades-2.4 into lp:openlp/2.4

2017-03-08 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/db-upgrades-2.4 into lp:openlp/2.4. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/db-upgrades-2.4/+merge/319385 Add this to your merge proposal

Re: [Openlp-core] [Merge] lp:~trb143/openlp/webfull into lp:openlp

2017-03-05 Thread Raoul Snyman
Oh, also, with the new web remote we won't need Mako or the translations because it'll be completely client-side. -- https://code.launchpad.net/~trb143/openlp/webfull/+merge/319003 Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/webfull into lp:openlp.

Re: [Openlp-core] [Merge] lp:~trb143/openlp/webfull into lp:openlp

2017-03-05 Thread Raoul Snyman
So, some thoughts around removing the web remote from OpenLP: - The remote plugin should handle the download and install of the web remote - The downloadable web remote should be versioned - OpenLP needs to be aware of the versions - Users should be able to check if there's a new version of

Re: [Openlp-core] [Merge] lp:~trb143/openlp/removessl26 into lp:openlp

2017-03-04 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/removessl26/+merge/318988 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~trb143/openlp/removessl26 into lp:openlp

2017-03-04 Thread Raoul Snyman
The proposal to merge lp:~trb143/openlp/removessl26 into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~trb143/openlp/removessl26/+merge/318988 -- Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~trb143/openlp/removessl26 into lp:openlp

2017-03-04 Thread Raoul Snyman
Could you add a new test please? It doesn't have to be related, can be anywhere else. -- https://code.launchpad.net/~trb143/openlp/removessl26/+merge/318983 Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/removessl26 into lp:openlp.

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-importers-2.4 into lp:openlp/2.4

2017-03-02 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/fix-importers-2.4 into lp:openlp/2.4. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/fix-importers-2.4/+merge/318838 - Fix SongSelect so that it detects the login

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-importers-2.4 into lp:openlp

2017-03-02 Thread Raoul Snyman
The proposal to merge lp:~raoul-snyman/openlp/fix-importers-2.4 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/fix-importers-2.4/+merge/318837 -- Your team OpenLP Core is requested to rev

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/bug-1668669-2.4 into lp:openlp/2.4

2017-03-02 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/bug-1668669-2.4 into lp:openlp/2.4. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1668669 in OpenLP: "Configure OpenLP windows extends beyond the bottom of the screen" https://bugs.launchpad.net/o

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/bug-1668669-2.4 into lp:openlp

2017-03-02 Thread Raoul Snyman
The proposal to merge lp:~raoul-snyman/openlp/bug-1668669-2.4 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/bug-1668669-2.4/+merge/318691 -- Your team OpenLP Core is requested to rev

[Openlp-core] [Bug 1666005] Re: Song Editor saves wrong author

2017-03-02 Thread Raoul Snyman
** Changed in: openlp/2.4 Status: Fix Committed => In Progress ** Changed in: openlp/trunk Status: Fix Committed => In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1666005

[Openlp-core] [Bug 1668994] Re: Author display name not populated

2017-03-01 Thread Raoul Snyman
openlp/trunk Milestone: None => 2.5.1 ** Changed in: openlp/trunk Assignee: (unassigned) => Raoul Snyman (raoul-snyman) ** Changed in: openlp/2.4 Status: New => Fix Committed ** Changed in: openlp/2.4 Importance: Undecided => High ** Changed in: openlp/2.4 Ass

[Openlp-core] [Bug 1666005] Re: Song Editor saves wrong author

2017-03-01 Thread Raoul Snyman
** Branch linked: lp:~raoul-snyman/openlp/off-by-one ** Changed in: openlp Status: Confirmed => Fix Committed ** Changed in: openlp Importance: Undecided => High ** Changed in: openlp Assignee: (unassigned) => Raoul Snyman (raoul-snyman) ** Also affects: ope

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/off-by-one-2.4 into lp:openlp/2.4

2017-03-01 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/off-by-one-2.4 into lp:openlp/2.4. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1666005 in OpenLP: "Song Editor saves wrong author" https://bugs.launchpad.net/openlp/+bug/1666005 Bug #1668994 in OpenL

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/off-by-one-2.4 into lp:openlp

2017-03-01 Thread Raoul Snyman
The proposal to merge lp:~raoul-snyman/openlp/off-by-one-2.4 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/off-by-one-2.4/+merge/318708 -- Your team OpenLP Core is requested to review the propo

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/off-by-one into lp:openlp

2017-03-01 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/off-by-one into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/off-by-one/+merge/318719 Fix bug #1666005 and bug #1668994 Add this to your merge proposal

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/off-by-one-2.4 into lp:openlp

2017-03-01 Thread Raoul Snyman
The proposal to merge lp:~raoul-snyman/openlp/off-by-one-2.4 into lp:openlp has been updated. Description changed to: Fix bug #1666005 and bug #1668994 Add this to your merge proposal: lp:~raoul-snyman/openlp/off-by-one-2.4 (revision 2675) [SUCCESS] https

<    5   6   7   8   9   10   11   12   13   14   >