Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/animated-alerts into lp:openlp

2019-09-15 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/animated-alerts/+merge/372792 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/reveal-css into lp:openlp

2019-09-15 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~tomasgroth/openlp/reveal-css/+merge/372798 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/pyro4-maclo into lp:openlp

2019-09-13 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/pyro4-maclo/+merge/372748 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/animated-alerts into lp:openlp

2019-09-12 Thread Tim Bentley
Review: Needs Fixing Looks good but the js stuff goes over my head! One issue in alertsmanager and half done clean up. Diff comments: > > === modified file 'openlp/plugins/alerts/lib/alertsmanager.py' > --- openlp/plugins/alerts/lib/alertsmanager.py2019-04-13 13:00:22 > + > +++

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-wait-for-threads-error into lp:openlp

2019-09-12 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/fix-wait-for-threads-error/+merge/372669 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Bug 1842523] Re: trunk V2898 adding video file to Service causes errors

2019-09-07 Thread Tim Bentley
nager object at 0x12061530>> for live_display_active 2019-09-03 19:22:52,200 MainThread openlp.core.common.registry ERROROpenLP Error trace File run_openlp.py at line 87 called start() File run_openlp.py at line 83 called main() File

[Openlp-core] [Bug 1842523] Re: trunk V2898 adding video file to Service causes errors

2019-09-07 Thread Tim Bentley
penlp.core.ui.servicemanager.ServiceManager DEBUGEntering find_service_item ** Changed in: openlp Assignee: (unassigned) => Tim Bentley (trb143) ** Changed in: openlp Status: New => Confirmed ** Changed in: openlp Importance: Undecided => Critical --

[Openlp-core] [Bug 1842756] Re: trunk v2898 file lookup preset can't find files

2019-09-05 Thread Tim Bentley
Video Backgrounds is in the processing of changing so this will not work at present. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1842756 Title: trunk v2898 file lookup preset can't find files

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/main into lp:openlp

2019-09-03 Thread Tim Bentley
Review: Needs Fixing You have left the python3 construct in the openlp/__main__.py which leaves this as an entry point. Please confirm this is correct or remove. -- https://code.launchpad.net/~bastian-germann/openlp/main/+merge/368590 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Bug 1840092] Re: version 2889 song edit window 'save and preview' button only saves

2019-08-30 Thread Tim Bentley
** Changed in: openlp Status: In Progress => Fix Committed ** Changed in: openlp Milestone: None => 2.9.1 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1840092 Title: version 2889 song

[Openlp-core] [Bug 1841196] Re: V2892 Service Theme not working

2019-08-30 Thread Tim Bentley
** Changed in: openlp Milestone: None => 2.9.1 ** Changed in: openlp Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1841196 Title: V2892 Service Theme

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-display-chords into lp:openlp

2019-08-30 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/fix-display-chords/+merge/372072 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~trb143/openlp/latest-fixes into lp:openlp

2019-08-30 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/latest-fixes into lp:openlp. Commit message: Undo an incorrect change and replace missing code as pert of the display revamp. Requested reviews: Raoul Snyman (raoul-snyman) Related bugs: Bug #1840092 in OpenLP: "version 2889 song edit w

[Openlp-core] [Merge] lp:~trb143/openlp/latest-fixes into lp:openlp

2019-08-30 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/latest-fixes into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/latest-fixes/+merge/372055 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~trb143/openlp/latest-fixes into lp:openlp

2019-08-30 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/latest-fixes into lp:openlp. Commit message: Undo an incorrect change and replace missing code as pert of the display revamp. Requested reviews: Raoul Snyman (raoul-snyman) Related bugs: Bug #1840092 in OpenLP: "version 2889 song edit w

[Openlp-core] [Merge] lp:~trb143/openlp/latest-fixes into lp:openlp

2019-08-30 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/latest-fixes into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/latest-fixes/+merge/371774 -- Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/chordpro-fixes into lp:openlp

2019-08-28 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~tomasgroth/openlp/chordpro-fixes/+merge/371954 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/update-about into lp:openlp

2019-08-27 Thread Tim Bentley
Review: Approve Again -- https://code.launchpad.net/~raoul-snyman/openlp/update-about/+merge/371894 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/pymysql into lp:openlp

2019-08-27 Thread Tim Bentley
Review: Approve Approved -- https://code.launchpad.net/~raoul-snyman/openlp/pymysql/+merge/371851 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/pymysql into lp:openlp

2019-08-27 Thread Tim Bentley
Approved -- https://code.launchpad.net/~raoul-snyman/openlp/pymysql/+merge/371851 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/pymysql into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/update-about into lp:openlp

2019-08-27 Thread Tim Bentley
Approved -- https://code.launchpad.net/~raoul-snyman/openlp/update-about/+merge/371882 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Bug 1841375] [NEW] On Change of items with a different them the Background image does not change

2019-08-25 Thread Tim Bentley
Public bug reported: Using Song level theme setting. Add two items to the service each with a different theme. When they are displayed the themes changed correctly EXCEPT the background image does not change. This does work fine for gradients. ** Affects: openlp Importance: Critical

[Openlp-core] [Merge] lp:~trb143/openlp/latest-fixes into lp:openlp

2019-08-25 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/latest-fixes into lp:openlp. Commit message: Undo an incorrect change and replace missing code as pert of the display revamp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1840092 in OpenLP: "version 2889 song edit w

[Openlp-core] [Bug 1841196] Re: V2892 Service Theme not working

2019-08-25 Thread Tim Bentley
** Changed in: openlp Status: New => Confirmed ** Changed in: openlp Importance: Undecided => Medium ** Changed in: openlp Assignee: (unassigned) => Tim Bentley (trb143) ** Branch linked: lp:~trb143/openlp/latest-fixes -- You received this bug notification be

[Openlp-core] [Bug 1840092] Re: version 2889 song edit window 'save and preview' button only saves

2019-08-25 Thread Tim Bentley
w you get Save and "Save & Preview". Save saves and exits. "Save and Preview" saves the song and reloads the preview. ** Changed in: openlp Status: New => In Progress ** Changed in: openlp Assignee: (unassigned) => Tim Bentley (trb143) ** Changed in:

[Openlp-core] [Bug 1514894] Re: Simplify theme levels

2019-08-25 Thread Tim Bentley
** Changed in: openlp Assignee: Azaziah (suutari-olli) => (unassigned) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1514894 Title: Simplify theme levels Status in OpenLP: New Bug

[Openlp-core] [Bug 1832955] Re: v2880 groups act strange in service

2019-08-23 Thread Tim Bentley
** Changed in: openlp Status: New => Won't Fix -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1832955 Title: v2880 groups act strange in service Status in OpenLP: Won't Fix Bug

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/fix-image-height into lp:openlp

2019-08-22 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/fix-image-height/+merge/371681 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/image-scaling into lp:openlp

2019-08-21 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~tomasgroth/openlp/image-scaling/+merge/371610 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~trb143/openlp/transfixes into lp:openlp

2019-08-20 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/transfixes into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/transfixes/+merge/371426 -- Your team OpenLP Core is requested to review the proposed merge of

[Openlp-core] [Bug 1839726] Re: Version 2889 Blank Error window when closing application

2019-08-10 Thread Tim Bentley
switch on debugging and upload the log file. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1839726 Title: Version 2889 Blank Error window when closing application Status in OpenLP: New Bug

[Openlp-core] [Bug 1832939] Re: Need to select a display when first run of app

2019-08-10 Thread Tim Bentley
Live display was removed as the default due to major issues on machines with one display. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1832939 Title: Need to select a display when first run of app

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-IV into lp:openlp

2019-08-07 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/fixes-IV/+merge/371023 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Bug 1837294] Re: Alpha Test - Screen settings are not converted

2019-08-04 Thread Tim Bentley
** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1837294 Title: Alpha Test - Screen settings are not converted Status in OpenLP:

[Openlp-core] [Merge] lp:~trb143/openlp/alpha_fixes into lp:openlp

2019-08-04 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/alpha_fixes into lp:openlp. Commit message: Fixes all over the place. * Migration from 2.4 to trunk now handles the screen definitions * Custom generation from service manager works again * Print service works * Open last service works again

[Openlp-core] [Merge] lp:~trb143/openlp/alpha_fixes into lp:openlp

2019-08-04 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/alpha_fixes into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/alpha_fixes/+merge/370937 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~trb143/openlp/alpha_fixes into lp:openlp

2019-08-04 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/alpha_fixes into lp:openlp. Commit message: Fixes all over the place. * Migration from 2.4 to trunk now handles the screen definitions * Custom generation from service manager works again * Print service works * Open last service works again

[Openlp-core] [Merge] lp:~trb143/openlp/alpha_fixes into lp:openlp

2019-08-04 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/alpha_fixes into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/alpha_fixes/+merge/370936 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~trb143/openlp/alpha_fixes into lp:openlp

2019-08-04 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/alpha_fixes into lp:openlp. Commit message: Fixes all over the place. * Migration from 2.4 to trunk now handles the screen definitions * Custom generation from service manager works again * Print service works * Open last service works again

[Openlp-core] [Merge] lp:~trb143/openlp/alpha_fixes into lp:openlp

2019-08-04 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/alpha_fixes into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/alpha_fixes/+merge/370934 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~trb143/openlp/alpha_fixes into lp:openlp

2019-08-04 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/alpha_fixes into lp:openlp. Commit message: Fixes all over the place. * Migration from 2.4 to trunk now handles the screen definitions * Custom generation from service manager works again * Print service works * Open last service works again

[Openlp-core] [Bug 1837294] Re: Alpha Test - Screen settings are not converted

2019-07-28 Thread Tim Bentley
** Branch linked: lp:~trb143/openlp/alpha_fixes -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1837294 Title: Alpha Test - Screen settings are not converted Status in OpenLP: In Progress Bug

[Openlp-core] [Bug 1837294] Re: Alpha Test - Screen settings are not converted

2019-07-28 Thread Tim Bentley
** Changed in: openlp Status: New => In Progress ** Changed in: openlp Importance: Undecided => Critical ** Changed in: openlp Assignee: (unassigned) => Tim Bentley (trb143) ** Changed in: openlp Milestone: None => 2.9.1 -- You received this bug notification

[Openlp-core] [Bug 1095742] Re: Portable apps storing drive letter in db

2019-07-21 Thread Tim Bentley
** Changed in: openlp/trunk Milestone: None => 2.9.1 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1095742 Title: Portable apps storing drive letter in db Status in OpenLP: Fix Committed

[Openlp-core] [Bug 1608024] Re: DVD Media Time Stamps Not Working

2019-07-21 Thread Tim Bentley
** Changed in: openlp Assignee: (unassigned) => Tim Bentley (trb143) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1608024 Title: DVD Media Time Stamps Not Working Status in OpenLP:

[Openlp-core] [Bug 1837294] [NEW] Alpha Test - Screen settings are not converted

2019-07-20 Thread Tim Bentley
Public bug reported: One a Brand laptop with Fedora installed 2.4.6 build I have then run trunk (20-07-2019). I had a single screen with a live display and override position. The conversion has ignored all my overrides and not set me up with any displays. ** Affects: openlp Importance:

[Openlp-core] [Bug 1837293] [NEW] Alpha Test - Update breaks themes

2019-07-20 Thread Tim Bentley
Public bug reported: One a Brand laptop with Fedora installed 2.4.6 build I have then run trunk (20-07-2019). I had 3 default themes and 1 new theme. 2 themes are missing. the transparent theme still exists. One of the downloaded themes (Sunrise) is corrupted. Playing as song takes the old

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-III into lp:openlp

2019-07-19 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/fixes-III/+merge/370337 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-III into lp:openlp

2019-07-18 Thread Tim Bentley
Review: Needs Information See inline comments Diff comments: > > === modified file 'openlp/core/common/i18n.py' > --- openlp/core/common/i18n.py2019-06-28 18:09:25 + > +++ openlp/core/common/i18n.py2019-07-18 19:27:49 + > @@ -338,8 +338,8 @@ > Override the

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/wow_import_fixes into lp:openlp

2019-06-28 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/wow_import_fixes/+merge/369468 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/wow_import_fixes into lp:openlp

2019-06-28 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/wow_import_fixes/+merge/369463 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Bug 1832876] Re: Please add songbook to the 'Delete Duplicate Songs' Wizard

2019-06-25 Thread Tim Bentley
** Changed in: openlp Assignee: (unassigned) => Johnthan (johnmfl) ** Changed in: openlp Milestone: None => 2.9.1 ** Changed in: openlp Status: New => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

[Openlp-core] [Bug 1832874] Re: Temporary songs appear in the 'Delete Duplicate songs' wizard

2019-06-25 Thread Tim Bentley
** Changed in: openlp Status: Confirmed => Fix Committed ** Changed in: openlp Milestone: None => 2.9.1 ** Changed in: openlp Assignee: (unassigned) => Johnthan (johnmfl) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to

[Openlp-core] [Merge] lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp

2019-06-25 Thread Tim Bentley
The proposal to merge lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp has been updated. Commit message changed to: #1832874 changed songsplugin.py from `is true` to `== True` to force the deletion of temporary song records in the database on closing OpenLP. This

Re: [Openlp-core] [Merge] lp:~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp:openlp

2019-06-25 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview/+merge/369062 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp. Commit message: Adds basic streaming service item UI to set up streaming Fix issues with suffix refactor Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~trb143/openlp

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp. Commit message: Adds basic streaming service item UI to set up streaming Fix issues with suffix refactor Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~trb143/openlp

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/more_media/+merge/368842 -- Your team OpenLP Core is requested to review the proposed merge of

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/more_media/+merge/368841 -- Your team OpenLP Core is requested to review the proposed merge of

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-06-14 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp. Commit message: Adds basic streaming service item UI to set up streaming Fix issues with suffix refactor Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~trb143/openlp

[Openlp-core] [Bug 1832874] Re: Temporary songs appear in the 'Delete Duplicate songs' wizard

2019-06-14 Thread Tim Bentley
Code to fix this was removed from the Songs plugin in 2.2 but was there in 2.0 ** Changed in: openlp Status: New => Confirmed ** Changed in: openlp Importance: Undecided => High -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/fixes-201906-a into lp:openlp

2019-06-11 Thread Tim Bentley
Review: Approve Approved -- https://code.launchpad.net/~tomasgroth/openlp/fixes-201906-a/+merge/368677 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/fix-theme-thumb into lp:openlp

2019-06-09 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~tomasgroth/openlp/fix-theme-thumb/+merge/368596 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/fix-theme-thumb into lp:openlp

2019-06-07 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~tomasgroth/openlp/fix-theme-thumb/+merge/368571 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/pyro-impress into lp:openlp

2019-06-06 Thread Tim Bentley
Review: Approve Looks fine but no Mac so no idea if it runs! -- https://code.launchpad.net/~raoul-snyman/openlp/pyro-impress/+merge/368362 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/media_ext_refactors into lp:openlp

2019-06-01 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/media_ext_refactors/+merge/368221 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/media_ext_refactors into lp:openlp

2019-05-31 Thread Tim Bentley
Review: Needs Fixing Minor improvement please Diff comments: > > === modified file 'openlp/core/ui/media/mediacontroller.py' > --- openlp/core/ui/media/mediacontroller.py 2019-05-05 05:59:29 + > +++ openlp/core/ui/media/mediacontroller.py 2019-05-31 20:34:31 + > @@ -131,7 +106,8 @@

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/dependencies into lp:openlp

2019-05-28 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~bastian-germann/openlp/dependencies/+merge/367931 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/presentation-beyond-last into lp:openlp

2019-05-28 Thread Tim Bentley
Review: Approve Looks Ok. -- https://code.launchpad.net/~tomasgroth/openlp/presentation-beyond-last/+merge/367932 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/bundle-libvlc into lp:openlp

2019-05-22 Thread Tim Bentley
Review: Approve Looks good for the bits I understand! -- https://code.launchpad.net/~raoul-snyman/openlp/bundle-libvlc/+merge/367789 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-v07 into lp:openlp

2019-05-18 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-v07/+merge/367473 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~trb143/openlp/no_vlc into lp:openlp

2019-05-08 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/no_vlc into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/no_vlc/+merge/367110 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~trb143/openlp/no_vlc into lp:openlp

2019-05-08 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/no_vlc into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/no_vlc/+merge/367067 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-05-05 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp. Commit message: Media plays successfully and cleanups. Added VLC additions Requested reviews: Tomas Groth (tomasgroth) Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~trb143/openlp

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-05-05 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/more_media/+merge/366608 -- Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2_v04 into lp:openlp

2019-05-04 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~alisonken1/openlp/pjlink2_v04/+merge/366946 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-II into lp:openlp

2019-05-04 Thread Tim Bentley
Review: Needs Information See inline Diff comments: > === modified file 'openlp/core/app.py' > --- openlp/core/app.py2019-05-01 19:22:01 + > +++ openlp/core/app.py2019-05-04 18:27:23 + > @@ -287,12 +287,12 @@ > return QtWidgets.QApplication.event(self, event) >

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/portable-path into lp:openlp

2019-05-02 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~tomasgroth/openlp/portable-path/+merge/366785 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/gpl3 into lp:openlp

2019-04-30 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~bastian-germann/openlp/gpl3/+merge/366626 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-v03 into lp:openlp

2019-04-28 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-v03/+merge/366612 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-04-27 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp. Commit message: Media plays successfully and cleanups. Added VLC additions Requested reviews: Tomas Groth (tomasgroth) For more details, see: https://code.launchpad.net/~trb143/openlp/more_media/+merge/366608

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-04-27 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/more_media/+merge/366336 -- Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-v1 into lp:openlp

2019-04-26 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-v1/+merge/366334 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-v02 into lp:openlp

2019-04-26 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-v02/+merge/366554 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-04-21 Thread Tim Bentley
Prints are there as the code just explodes on my machine and shuts OpenLP down. No worth doing anything cute while it is this state! They never get called. Happy to move flag. -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/366336 Your team OpenLP Core is subscribed to branch

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-04-21 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp. Commit message: Media plays successfully and cleanups. Added VLC additions Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~trb143/openlp/more_media/+merge/366336

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-04-21 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/more_media/+merge/366335 -- Your team OpenLP Core is requested to review the proposed merge of

[Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-04-21 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp. Commit message: Media plays successfully and cleanups. Added VLC additions Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~trb143/openlp/more_media/+merge/366335

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/gpl3 into lp:openlp

2019-04-20 Thread Tim Bentley
Review: Needs Information What about the test files. Are you going to fix those as well? -- https://code.launchpad.net/~bastian-germann/openlp/gpl3/+merge/365987 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/pylint-fixes into lp:openlp

2019-04-13 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~tomasgroth/openlp/pylint-fixes/+merge/365986 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/pylint-fixes into lp:openlp

2019-04-12 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~tomasgroth/openlp/pylint-fixes/+merge/365979 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/wix-packaging into lp:openlp/packaging

2019-04-12 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/wix-packaging/+merge/365880 Your team OpenLP Core is subscribed to branch lp:openlp/packaging. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~trb143/openlp/media_state into lp:openlp

2019-04-11 Thread Tim Bentley
This is work in progress and needs 1 more merge to finish. The commented our code is not needed and needs to be cleaned up but want to keep till I finish. The stream code is the next set and I have infor for linux and windows but not mac. Did ask the mailing list and only tgc responded. --

[Openlp-core] [Merge] lp:~trb143/openlp/media_state into lp:openlp

2019-04-11 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/media_state into lp:openlp. Commit message: VLC plays and handles missing live display gracefully. Preview still works. Added experimental setting to remove UI incomplete stuff. various bug fixes and improvments, Requested reviews: OpenLP Core

[Openlp-core] [Merge] lp:~trb143/openlp/media_state into lp:openlp

2019-04-10 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/media_state into lp:openlp. Commit message: Fix up VLC so it works and plays. Still not finished but getting there. Requested reviews: Phill (phill-ridout) Related bugs: Bug #1823575 in OpenLP: "PluginManager still has plugin list&quo

[Openlp-core] [Merge] lp:~trb143/openlp/media_state into lp:openlp

2019-04-10 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~trb143/openlp/media_state/+merge/365762 -- Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/depends into lp:openlp

2019-04-10 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365811 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/depends into lp:openlp

2019-04-10 Thread Tim Bentley
Review: Needs Fixing Please remove the media changes. -- https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365765 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

Re: [Openlp-core] [Merge] lp:~rafaellerm/openlp/media_import_fix into lp:openlp

2019-04-09 Thread Tim Bentley
This is old code and the application has changed since this was started, If it is still an issue please resubmit. -- https://code.launchpad.net/~rafaellerm/openlp/media_import_fix/+merge/210113 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~rafaellerm/openlp/media_import_fix into lp:openlp

2019-04-09 Thread Tim Bentley
The proposal to merge lp:~rafaellerm/openlp/media_import_fix into lp:openlp has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~rafaellerm/openlp/media_import_fix/+merge/210113 -- Your team OpenLP Core is subscribed to branch lp:openlp.

  1   2   3   4   5   6   7   8   9   10   >