The proposal to merge lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343465
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Approve
Good, thanks for you patience
--
https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343465
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
Looks good to me.
--
https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343465
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-newline-bug into
lp:openlp.
Requested reviews:
Phill (phill-ridout)
Tim Bentley (trb143)
Related bugs:
Bug #1727517 in OpenLP: "Unicode control chars causes song importer to crash"
https://bugs.launchpad.net/openlp/+bug/1727517
The proposal to merge lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343422
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Needs Fixing
See comments inline
lp:~thelinuxguy/openlp/fix-newline-bug (revision 2822)
https://ci.openlp.io/job/Branch-01-Pull/2502/ [SUCCESS]
https://ci.openlp.io/job/Branch-02a-Linux-Tests/2403/ [SUCCESS]
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-newline-bug into
lp:openlp.
Requested reviews:
Phill (phill-ridout)
Tim Bentley (trb143)
Related bugs:
Bug #1727517 in OpenLP: "Unicode control chars causes song importer to crash"
https://bugs.launchpad.net/openlp/+bug/1727517
The proposal to merge lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343306
--
Your team OpenLP Core is subscribed to branch lp:openlp.
> One small typo, and a couple comments that need changing.
Sorry!
--
https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343306
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Review: Needs Fixing
One small typo, and a couple comments that need changing.
Diff comments:
> === modified file 'openlp/core/common/__init__.py'
> --- openlp/core/common/__init__.py2018-02-24 16:10:02 +
> +++ openlp/core/common/__init__.py2018-04-16 11:33:07 +
> @@ -44,7 +44,7
The proposal to merge lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343277
--
Your team OpenLP Core is subscribed to branch lp:openlp.
I wonder what the reason behind replacing vertial tabs with new lines is...
Looking at where the regex is being used I'm inclined to say the whole thing
needs to be reworked.
It's also used in the filename cleaning where linefeeds are strange, but then
again I don't know what the input always
Review: Needs Fixing
I've done some research in to this. Officially the only code points allowed are:
"
[2] Char ::= #x9 | #xA | #xD | [#x20-#xD7FF] |
[#xE000-#xFFFD] | [#x1-#x10] /* any Unicode character, excluding the
surrogate blocks, FFFE, and . */
" (
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-newline-bug into
lp:openlp.
Requested reviews:
Phill (phill-ridout)
Tim Bentley (trb143)
Related bugs:
Bug #1727517 in OpenLP: "Unicode control chars causes song importer to crash"
https://bugs.launchpad.net/openlp/+bug/1727517
The proposal to merge lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343256
--
Your team OpenLP Core is subscribed to branch lp:openlp.
will update shortly
Diff comments:
> === modified file 'openlp/core/common/__init__.py'
> --- openlp/core/common/__init__.py2018-02-24 16:10:02 +
> +++ openlp/core/common/__init__.py2018-04-14 20:05:07 +
> @@ -44,7 +44,7 @@
>
> FIRST_CAMEL_REGEX =
Review: Needs Fixing
See in line. One question and a few (more) minor fixes please.
Diff comments:
> === modified file 'openlp/core/common/__init__.py'
> --- openlp/core/common/__init__.py2018-02-24 16:10:02 +
> +++ openlp/core/common/__init__.py2018-04-14 20:05:07 +
> @@ -44,7
Review: Needs Fixing
One minor fix as I do not like the rename of the field
Diff comments:
> === modified file 'openlp/core/common/__init__.py'
> --- openlp/core/common/__init__.py2018-02-24 16:10:02 +
> +++ openlp/core/common/__init__.py2018-04-14 20:05:07 +
> @@ -471,15
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-newline-bug into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1727517 in OpenLP: "Unicode control chars causes song importer to crash"
https://bugs.launchpad.net/openlp/+bug/1727517
For more details,
19 matches
Mail list logo
