Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-11 Thread Tim Bentley
Review: Approve


-- 
https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328825
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-11 Thread Raoul Snyman
Review: Approve

Looks OK to me.
-- 
https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328825
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-04 Thread Raoul Snyman
We already have a custom file dialog, why not extend that one rather than write 
a completely new class?
-- 
https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328616
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-04 Thread Tim Bentley
Review: Needs Fixing

Trunk is fine

Advanced Tab 
Traceback (most recent call last):
  File 
"/home/tim/Projects/OpenLP/openlp/pathlib2/openlp/core/ui/mainwindow.py", line 
810, in on_settings_configure_iem_clicked
self.settings_form.exec()
  File 
"/home/tim/Projects/OpenLP/openlp/pathlib2/openlp/core/ui/settingsform.py", 
line 70, in exec
self.insert_tab(self.general_tab)
  File 
"/home/tim/Projects/OpenLP/openlp/pathlib2/openlp/core/ui/settingsform.py", 
line 89, in insert_tab
log.debug('Inserting {text} tab'.format(text=tab_widget.tab_title))
AttributeError: 'NoneType' object has no attribute 'tab_title'

Theme Edit with image 
Traceback (most recent call last):
  File 
"/home/tim/Projects/OpenLP/openlp/pathlib2/openlp/core/ui/thememanager.py", 
line 326, in on_edit_theme
self.theme_form.exec(True)
  File "/home/tim/Projects/OpenLP/openlp/pathlib2/openlp/core/ui/themeform.py", 
line 279, in exec
self.set_defaults()
  File "/home/tim/Projects/OpenLP/openlp/pathlib2/openlp/core/ui/themeform.py", 
line 109, in set_defaults
self.set_background_page_values()
  File "/home/tim/Projects/OpenLP/openlp/pathlib2/openlp/core/ui/themeform.py", 
line 322, in set_background_page_values
self.image_path_edit.path = path_to_str(self.theme.background_filename)
  File "/home/tim/Projects/OpenLP/openlp/pathlib2/openlp/core/common/path.py", 
line 37, in path_to_str
raise TypeError('parameter \'path\' must be of type Path or NoneType')
TypeError: parameter 'path' must be of type Path or NoneType


-- 
https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328595
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp