[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2014-11-02 Thread Tim Bentley
** Changed in: openlp/trunk Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1173749 Title: Songs with mismatching formatting tags still throw an exception

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2014-07-06 Thread Samuel Mehrbrodt
** Branch linked: lp:~sam92/openlp/2.0-backports ** Changed in: openlp/trunk Status: Confirmed = Fix Committed ** Changed in: openlp/trunk Assignee: (unassigned) = Samuel Mehrbrodt (sam92) -- You received this bug notification because you are a member of OpenLP Core, which is

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2014-02-05 Thread Raoul Snyman
** Changed in: openlp/2.0 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1173749 Title: Songs with mismatching formatting tags still throw an exception

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-12-25 Thread Phill
** Changed in: openlp/2.0 Status: In Progress = Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1173749 Title: Songs with mismatching formatting tags still throw an exception

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-11-18 Thread Launchpad Bug Tracker
** Branch linked: lp:openlp/2.0 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1173749 Title: Songs with mismatching formatting tags still throw an exception Status in OpenLP - Worship Presentation

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-10-23 Thread Phill
Additionally we should probably try and catch this error and issue a friendly warning to the user. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1173749 Title: Songs with mismatching formatting

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-09-14 Thread Andreas Preikschat
** Changed in: openlp/2.0 Milestone: 2.0.3 = 2.0.4 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1173749 Title: Songs with mismatching formatting tags still throw an exception Status in OpenLP

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-08-24 Thread Oliver Wieland
** Changed in: openlp/2.0 Assignee: (unassigned) = Oliver Wieland (oliwee) ** Changed in: openlp/2.0 Status: Confirmed = In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1173749

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-08-24 Thread Oliver Wieland
** Branch linked: lp:~oliwee/openlp/1173749-2.0 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1173749 Title: Songs with mismatching formatting tags still throw an exception Status in OpenLP -

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-08-24 Thread Oliver Wieland
1a) is done for 2.0 series. See linked branch. I'm not sure if I should propose for merging, because it's assigned to V2.0.3. Maybe I should wait until 2.0.2 is released? -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-08-23 Thread Phill
I think there is really two parts to this bug. 1. We should validate the formatting tags when a user enters a song manually: a) For 2.0 series think we should display a message box saying that the formatting tags are invalid. b) For trunk series, I was thinking it would be nice if we

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-08-23 Thread Oliver Wieland
1a) So the users can't leave the editor before fixing the malformed tags? This would be the easiest solution, but not very user friendly. The user should have the possibility to save a song every time, even when it is malformed. Anyway, a message box should point out the user that there is an

Re: [Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-08-23 Thread Phill
1a) So the users can't leave the editor before fixing the malformed tags? This would be the easiest solution, but not very user friendly. The user should have the possibility to save a song every time, even when it is malformed. Anyway, a message box should point out the user that there is an

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-08-23 Thread Oliver Wieland
1a) I see. So the best solution for 2.0 series would be a message box when the user leaves the song editor, without let him out before he has fixed the problem. I think with my quick'n'dirty function this should be no too hard. I'll try that at the weekend. 2) I do not know anything about the

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-08-22 Thread Oliver Wieland
I wrote a function which checks the consistency of the tags in the verse. The question is: What is the appropriate reaction of the program if the function returns there is a malplaced tag? Should the whole import be canceled? -- You received this bug notification because you are a member of

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-08-21 Thread Phill
** Also affects: openlp/2.0 Importance: Undecided Status: New ** Also affects: openlp/trunk Importance: High Status: Confirmed ** Changed in: openlp/2.0 Milestone: None = 2.0.3 ** Changed in: openlp/trunk Milestone: 2.0.2 = 2.1.1 ** Changed in: openlp/2.0

[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-08-10 Thread Oliver Wieland
I think the problem is, that the method '_get_missing_tags' only checks for 'not closed' tags, but not for 'not opened'. I'm nearly a Phyton newbie, therefore I don't understand the complete code around this method and the following calls in 'song_to_xml', so I'm sorry that i cannot fix the