[Openlp-core] [Merge] lp:~phill-ridout/openlp/1096450 into lp:openlp

2013-08-31 Thread noreply
The proposal to merge lp:~phill-ridout/openlp/1096450 into lp:openlp has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463 -- https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463 Your team

[Openlp-core] [Merge] lp:~phill-ridout/openlp/1096450 into lp:openlp

2013-08-22 Thread Andreas Preikschat
The proposal to merge lp:~phill-ridout/openlp/1096450 into lp:openlp has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463 -- https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463 Your

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1096450 into lp:openlp

2013-08-22 Thread Andreas Preikschat
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1096450 into lp:openlp

2013-08-12 Thread Raoul Snyman
Review: Approve This looks OK to me. Are you sure the strip() is not going to create other issues later? Have you tried a variety of OpenSong files to test your changes? -- https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463 Your team OpenLP Core is subscribed to branch

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1096450 into lp:openlp

2013-08-12 Thread Phill
No it shouldn't because after that the lines are joined with a new line and then passed to addVerse. I've tested it with a load of sample files found on the OpenSong download page and pain painstakingly compared a load of songs of varying types between OpenLP and OpenSong --

[Openlp-core] [Merge] lp:~phill-ridout/openlp/1096450 into lp:openlp

2013-08-04 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/1096450 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1096450 in OpenLP: Opensong Import - some lines missing https://bugs.launchpad.net/openlp/+bug/1096450 For more details, see:

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1096450 into lp:openlp

2013-08-04 Thread Phill
I should add, tested with the python3-productive branch and 2to3. -- https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463 Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/1096450 into lp:openlp.