The proposal to merge lp:~phill-ridout/openlp/1096450 into lp:openlp has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463
--
https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463
Your team
The proposal to merge lp:~phill-ridout/openlp/1096450 into lp:openlp has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463
--
https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463
Your
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
This looks OK to me. Are you sure the strip() is not going to create other
issues later? Have you tried a variety of OpenSong files to test your changes?
--
https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463
Your team OpenLP Core is subscribed to branch
No it shouldn't because after that the lines are joined with a new line and
then passed to addVerse.
I've tested it with a load of sample files found on the OpenSong download page
and pain painstakingly compared a load of songs of varying types between OpenLP
and OpenSong
--
Phill has proposed merging lp:~phill-ridout/openlp/1096450 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1096450 in OpenLP: Opensong Import - some lines missing
https://bugs.launchpad.net/openlp/+bug/1096450
For more details, see:
I should add, tested with the python3-productive branch and 2to3.
--
https://code.launchpad.net/~phill-ridout/openlp/1096450/+merge/178463
Your team OpenLP Core is requested to review the proposed merge of
lp:~phill-ridout/openlp/1096450 into lp:openlp.
7 matches
Mail list logo