The proposal to merge lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
into lp:openlp has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325102
--
Your team OpenLP Core is
Review: Approve
Approved
--
https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325102
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
Nicely done Olli!
--
https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325102
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
Azaziah has proposed merging
lp:~suutari-olli/openlp/azaziah-fixes-and-improvements into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
Related bugs:
Bug #1639860 in OpenLP: "Close button is disabled in numerous windows"
The proposal to merge lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
into lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325101
--
Your team OpenLP Core is
> Please rerun CI with new test and resubmit.
>
> Thanks
I did re-run it, just forgot to copy-paste the new results.
I've updated them to the description.
Sorry for the delay.
--
https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325101
Your team OpenLP Core
The proposal to merge lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
into lp:openlp has been updated.
Description changed to:
Fixed bugs:
Bug #1639860: Close button is disabled in numerous windows
Bug #1652559: Find duplicates wizard does not reset cursor if closed from "x"
instead of
Review: Needs Fixing
Please rerun CI with new test and resubmit.
Thanks
--
https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325101
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Azaziah has proposed merging
lp:~suutari-olli/openlp/azaziah-fixes-and-improvements into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
Related bugs:
Bug #1639860 in OpenLP: "Close button is disabled in numerous windows"
The proposal to merge lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
into lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325053
--
Your team OpenLP Core is
Review: Needs Fixing
This needs checking on MAC as from memory there were issues with dialog closing
and mac os.
This is goin back a number of years in the 2.0 dev period. I have tried to
find the changs nut no luck.
--
I'll test it out on my Mac.
--
https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325053
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
Just some minor things.
Also, I really would prefer to see 1 new test, not just updates to tests.
Diff comments:
>
> === modified file 'openlp/plugins/bibles/lib/mediaitem.py'
> --- openlp/plugins/bibles/lib/mediaitem.py2017-05-07 18:39:17 +
> +++
Azaziah has proposed merging
lp:~suutari-olli/openlp/azaziah-fixes-and-improvements into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1639860 in OpenLP: "Close button is disabled in numerous windows"
https://bugs.launchpad.net/openlp/+bug/1639860
Bug
The proposal to merge lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
into lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325049
--
Your team OpenLP Core is
Azaziah has proposed merging
lp:~suutari-olli/openlp/azaziah-fixes-and-improvements into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1639860 in OpenLP: "Close button is disabled in numerous windows"
https://bugs.launchpad.net/openlp/+bug/1639860
Bug
The proposal to merge lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
into lp:openlp has been updated.
Status: Work in progress => Superseded
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325041
--
Your team OpenLP Core
17 matches
Mail list logo
