Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-15 Thread Phill
Review: Needs Fixing See in line. One question and a few (more) minor fixes please. Diff comments: > === modified file 'openlp/core/common/__init__.py' > --- openlp/core/common/__init__.py2018-02-24 16:10:02 + > +++ openlp/core/common/__init__.py2018-04-14 20:05:07 + > @@ -44,7

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-15 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343256 -- Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-15 Thread Simon Hanna
will update shortly Diff comments: > === modified file 'openlp/core/common/__init__.py' > --- openlp/core/common/__init__.py2018-02-24 16:10:02 + > +++ openlp/core/common/__init__.py2018-04-14 20:05:07 + > @@ -44,7 +44,7 @@ > > FIRST_CAMEL_REGEX =

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-15 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp. Requested reviews: Phill (phill-ridout) Tim Bentley (trb143) Related bugs: Bug #1727517 in OpenLP: "Unicode control chars causes song importer to crash" https://bugs.launchpad.net/openlp/+bug/1727517