Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/new-run-script into lp:openlp/packaging

2018-10-27 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/new-run-script/+merge/357906 Your team OpenLP Core is subscribed to branch lp:openlp/packaging. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/qcollator into lp:openlp

2018-10-27 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357907 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/new-run-script into lp:openlp/packaging

2018-10-27 Thread Bastian Germann
Review: Approve Great! I closed my branch in favour of this one. -- https://code.launchpad.net/~raoul-snyman/openlp/new-run-script/+merge/357906 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/new-run-script into lp:openlp/packaging.

[Openlp-core] Linting: Failed

2018-10-27 Thread Raoul Snyman
Linting failed, please see https://ci.openlp.io/job/MP-03-Linting/22/ for more details -- https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357907 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~bastian-germann/openlp/qcollator into lp:openlp

2018-10-27 Thread Bastian Germann
Bastian Germann has proposed merging lp:~bastian-germann/openlp/qcollator into lp:openlp. Commit message: Replace PyICU with PyQt's QCollator Use QCollator as new collator to get rid of the PyICU dependency. Simplify the natural sorting with its numeric mode. Simplify one test that is heavily

[Openlp-core] [Merge] lp:~bastian-germann/openlp/qcollator into lp:openlp

2018-10-27 Thread Bastian Germann
The proposal to merge lp:~bastian-germann/openlp/qcollator into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357851 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/new-run-script into lp:openlp/packaging

2018-10-27 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/new-run-script into lp:openlp/packaging. Commit message: Fix builder script to use new OpenLP run script name. Requested reviews: OpenLP Core (openlp-core) For more details, see:

[Openlp-core] Linting: Failed

2018-10-27 Thread Raoul Snyman
Linting failed, please see https://ci.openlp.io/job/MP-03-Linting/21/ for more details -- https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357907 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] Linux Test Results: Passed

2018-10-27 Thread Raoul Snyman
Linux tests passed! -- https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357907 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/qcollator into lp:openlp

2018-10-27 Thread Raoul Snyman
Review: Approve I just ran the tests, everything passed, I'm happy. -- https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357907 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/new-run-script into lp:openlp/packaging

2018-10-27 Thread noreply
The proposal to merge lp:~raoul-snyman/openlp/new-run-script into lp:openlp/packaging has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/new-run-script/+merge/357906 -- Your team OpenLP Core is subscribed to branch

[Openlp-core] [Merge] lp:~bastian-germann/openlp/unexport-tests into lp:openlp

2018-10-27 Thread Bastian Germann
Bastian Germann has proposed merging lp:~bastian-germann/openlp/unexport-tests into lp:openlp. Commit message: Do not export any tests* module Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~bastian-germann/openlp/unexport-tests/+merge/357912

[Openlp-core] Linux Test Results: Failed

2018-10-27 Thread Raoul Snyman
Linux tests failed, please see https://ci.openlp.io/job/MP-02-Linux_Tests/61/ for more details -- https://code.launchpad.net/~bastian-germann/openlp/unexport-tests/+merge/357912 Your team OpenLP Core is requested to review the proposed merge of lp:~bastian-germann/openlp/unexport-tests into