[Openlp-core] [Bug 1625087] [NEW] Image insertion doesn't respect natural order

2016-09-19 Thread Samuel Mehrbrodt
Public bug reported: When inserting images (when creating a image slideshow in OpenLP) with filenames like 1.jpg 2.jpg 3.jpg ... 10.jpg 11.jpg They don't get inserted in their natural order. Instead they are inserted like 10.jpg 11.jpg 1.jpg 2.jpg 3.jpg ... ** Affects: openlp Importance:

[Openlp-core] [Bug 1694428] [NEW] Allow to hide CCLI number per song in footer

2017-05-30 Thread Samuel Mehrbrodt
Public bug reported: When entering a CCLI number in the settings, it is shown in every song in the footer. Some songs might be covered by another license, so it makes no sense to show the CCLI license # in that case. There should be a way to define for each song whether it is necessary to show t

[Openlp-core] [Bug 1694430] [NEW] Allow to show alternate title in footer

2017-05-30 Thread Samuel Mehrbrodt
Public bug reported: Add an option to the songs settings, off by default. ** Affects: openlp Importance: Wishlist Status: New ** Changed in: openlp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is subscri

[Openlp-core] [Bug 1666006] Re: Song Editor alway saves theme

2017-06-01 Thread Samuel Mehrbrodt
** Changed in: openlp Status: New => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1666006 Title: Song Editor alway saves theme Status in OpenLP: Fix Released Bug description

[Openlp-core] [Bug 1694428] Re: Allow to hide CCLI number per song in footer

2017-06-01 Thread Samuel Mehrbrodt
Maybe we don't need an additional setting for this. We could show the CCLI license only if a "CCLI song number" has been entered in the song editor. ** Changed in: openlp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is

[Openlp-core] [Bug 1546530] Re: Can we have an 'Altered By' author type?

2017-06-01 Thread Samuel Mehrbrodt
Created an issue in OpenLyrics for this: https://github.com/openlyrics/openlyrics/issues/39 ** Bug watch added: github.com/openlyrics/openlyrics/issues #39 https://github.com/openlyrics/openlyrics/issues/39 ** Changed in: openlp Status: New => Confirmed -- You received this bug notifi

[Openlp-core] [Bug 1695587] Re: Entire Song doesn't search Song Number

2017-06-03 Thread Samuel Mehrbrodt
** Changed in: openlp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1695587 Title: Entire Song doesn't search Song Number Status in OpenLP: In Progress Bug d

[Openlp-core] [Bug 991348] Re: Display CCLI song number in footer

2017-06-03 Thread Samuel Mehrbrodt
Closing per comment #2 ** Changed in: openlp Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/991348 Title: Display CCLI song number in footer Status in OpenLP:

[Openlp-core] [Bug 1695620] [NEW] Make footer elements customizable

2017-06-03 Thread Samuel Mehrbrodt
Public bug reported: This mainly applies for the Songs footer. The footer can become very large if you have multiple authors, songbook info, CCLI license etc. Also you might want to display some parts of the footer larger than others (title vs copyright) -> HTML should be allowed So you should

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-04 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1694430 in OpenLP: "Allow to show alternate title in footer" https://bugs.launchpad.net/openlp/+bug/1694430 Bug #1695620 in Ope

Re: [Openlp-core] [Merge] lp:~samothjtm/openlp/bug-1695587 into lp:openlp

2017-06-08 Thread Samuel Mehrbrodt
Review: Approve -- https://code.launchpad.net/~samothjtm/openlp/bug-1695587/+merge/325118 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsub

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-12 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/bug-1695620 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/325043 -- Your team OpenLP Core is subscribed to branch lp:openlp. _

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-12 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) Related bugs: Bug #1694430 in OpenLP: "Allow to show alternate title in footer" https://bugs.launchpad.net/openlp/+bug/169

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-12 Thread Samuel Mehrbrodt
> Cannot run this but there seem to be lots of line breaks in the footer > display. As the footer area is small this will not be displayed and lead to > forum comments. The footer has the same height as before, there should be no difference by default. So I replaced Pystache with Mako. Should

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-12 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/bug-1695620 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/325514 -- Your team OpenLP Core is subscribed to branch lp:openlp. _

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-12 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) Related bugs: Bug #1694430 in OpenLP: "Allow to show alternate title in footer" https://bugs.launchpad.net/openlp/+bug/169

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-13 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/bug-1695620 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/325533 -- Your team OpenLP Core is subscribed to branch lp:openlp. _

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-13 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Related bugs: Bug #1694430 in OpenLP: "Allow to show alternate title in footer" https://bugs.launchpad.net/openlp/+bug/169

[Openlp-core] [Bug 1809449] [NEW] Slide with more than three optional breaks are cut off

2018-12-21 Thread Samuel Mehrbrodt
Public bug reported: Create a slide (either song or custom presentation) and insert some text with more than three optional splits. After the third split everything is ignored, only three slides are generated. ** Affects: openlp Importance: Undecided Status: New -- You received t

[Openlp-core] [Merge] lp:~sam92/openlp/openlp into lp:openlp

2013-07-17 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/openlp into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~sam92/openlp/openlp/+merge/175240 This sets a minimum size of 150 to each Pane so that the user cannot accidentally

[Openlp-core] [Merge] lp:~sam92/openlp/verse-order-warning into lp:openlp

2013-07-17 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/verse-order-warning into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1072478 in OpenLP: "Don't warn about unused verses if explicit order is missing" https://bugs.launchpad.net/openlp/+b

[Openlp-core] [Bug 1072478] Re: Don't warn about unused verses if explicit order is missing

2013-07-17 Thread Samuel Mehrbrodt
I think what Erik meant is to remove the warning "You have not entered a verse order". That one shows up when the verse order box is empty. I agree with Erik, that's a legitimate state and shouldn't cause a warning. -- You received this bug notification because you are a member of OpenLP Core, w

Re: [Openlp-core] [Merge] lp:~sam92/openlp/verse-order-warning into lp:openlp

2013-07-17 Thread Samuel Mehrbrodt
Sorry, I didn't know it has recently been changed. I guess I can close Bug 1072478 then. -- https://code.launchpad.net/~sam92/openlp/verse-order-warning/+merge/175261 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://la

[Openlp-core] [Bug 1072478] Re: Don't warn about unused verses if explicit order is missing

2013-07-17 Thread Samuel Mehrbrodt
Instead of the warning "Not all verses are in use" there is now a new warning "You have not entered a verse order" when the verse order box is empty. So this is fixed. ** Changed in: openlp/trunk Status: New => Fix Committed -- You received this bug notification because you are a member

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1094809 into lp:openlp

2013-07-19 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1094809 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1094809 in OpenLP: "Song Editor - improve usability of Verse Order field" https://bugs.launchpad.net/openlp/+bug/1094809 For more de

Re: [Openlp-core] [Merge] lp:~sam92/openlp/openlp into lp:openlp

2013-07-19 Thread Samuel Mehrbrodt
Ok, I changed the mainwindow.py accordingly. I needed to put the setChildrenCollapsible() call after the restoreState() call, becuase the "collapsible" property is also part of the saved state. I put a comment explaining that. Can you have a look at it again please? -- https://code.launchpad.ne

[Openlp-core] [Bug 832345] Re: Make it more obvious what the importer should be used to import exported songs (openlyrics)

2013-07-20 Thread Samuel Mehrbrodt
Seems like the Screenshot has been updated meanwhile. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/832345 Title: Make it more obvious what the importer should be used to import exported songs (op

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bug-1094809 into lp:openlp

2013-07-22 Thread Samuel Mehrbrodt
What do you mean? The Line starting with "Valid entries are..."? When I ident that line, the identation will be visible in the message box. How else should I handle that? -- https://code.launchpad.net/~sam92/openlp/bug-1094809/+merge/175894 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bug-1094809 into lp:openlp

2013-07-22 Thread Samuel Mehrbrodt
Thanks, I didn't know that you can concatenate strings that way. I also removed the unused "invalid" variable. -- https://code.launchpad.net/~sam92/openlp/bug-1094809/+merge/175894 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing li

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1094809 into lp:openlp

2013-08-04 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1094809 into lp:openlp. Requested reviews: Tim Bentley (trb143) Related bugs: Bug #1094809 in OpenLP: "Song Editor - improve usability of Verse Order field" https://bugs.launchpad.net/openlp/+bug/1094809 For more de

[Openlp-core] [Merge] lp:~sam92/openlp/openlp into lp:openlp

2013-08-04 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/openlp into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~sam92/openlp/openlp/+merge/178453 I changed the patch according to the comment. -- https://code.launchpad.net/~sam92/openlp

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1094809 into lp:openlp

2013-08-15 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/bug-1094809 into lp:openlp has been updated. Description changed to: Bug 1094809: Improve the Message when a wrong Verse order was entered For more details, see: https://code.launchpad.net/~sam92/openlp/bug-1094809/+merge/178452 -- https://code.launchpad.

[Openlp-core] [Merge] lp:~sam92/openlp/openlp into lp:openlp

2013-08-15 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/openlp into lp:openlp has been updated. Description changed to: Don't allow to collapse the Live or Preview Pane. They can still be hidden via the menu. For more details, see: https://code.launchpad.net/~sam92/openlp/openlp/+merge/178453 -- https://code.la

[Openlp-core] [Bug 1231336] [NEW] OpenLyrics Import: Wrong import of pretty-printed XML files

2013-09-26 Thread Samuel Mehrbrodt
Public bug reported: When I import an OpenLyrics Song that has linebreaks and indentation in a element, the linebreaks and indentation get imported too and the verses are not properly formatted. See attached song as an example. (That song has been created by the OpenLyrics Python Library [http:/

[Openlp-core] [Bug 1231336] Re: OpenLyrics Import: Wrong import of pretty-printed XML files

2013-09-26 Thread Samuel Mehrbrodt
Thanks for the links. Does that mean, this bug is a WONTFIX? -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1231336 Title: OpenLyrics Import: Wrong import of pretty-printed XML files Status in OpenL

[Openlp-core] [Bug 1231336] Re: OpenLyrics Import: Wrong import of pretty-printed XML files

2013-09-26 Thread Samuel Mehrbrodt
*** This bug is a duplicate of bug 1066320 *** https://bugs.launchpad.net/bugs/1066320 Ok. I found out that the OpenLyrics library creates those lines without linebreaks and indentation. So these things must come from some converter or so. -- You received this bug notification because you a

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbeamer-import into lp:openlp

2013-09-26 Thread Samuel Mehrbrodt
Btw, 'file' is a reserved keyword in Python, so I renamed that variable. -- https://code.launchpad.net/~sam92/openlp/fix-songbeamer-import/+merge/187815 Your team OpenLP Core is requested to review the proposed merge of lp:~sam92/openlp/fix-songbeamer-import into lp:openlp. _

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbeamer-import into lp:openlp

2013-09-26 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-songbeamer-import into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-songbeamer-import/+merge/187815 Fix SongBeamer Import chardet failed to guess the

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbeamer-import into lp:openlp

2013-09-26 Thread Samuel Mehrbrodt
Oh, it's not chardet that fails, but detect_file.read() throws the following exception: Traceback (most recent call last): File "/home/samuel/programming/openlp/trunk/openlp/core/ui/wizard.py", line 217, in on_current_id_changed self.performWizard() File "/home/samuel/programming/openlp

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbeamer-import into lp:openlp

2013-09-26 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-songbeamer-import into lp:openlp. Requested reviews: Jonathan Corwin (j-corwin) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-songbeamer-import/+merge/187839 Fix SongBeamer Import The read() call failed when

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbeamer-import into lp:openlp

2013-09-26 Thread Samuel Mehrbrodt
The exception was thrown in the open() call. I now changed the mode from 'r' to 'rb' which opens the file in binary mode. The python docs say: Files opened in binary mode (including 'b' in the mode argument) return contents as bytes objects without any decoding. (http://docs.python.org/3/libra

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbeamer-import into lp:openlp

2013-09-26 Thread Samuel Mehrbrodt
Sorry, I don't understand what's wrong with the current patch. Can you explain please? -- https://code.launchpad.net/~sam92/openlp/fix-songbeamer-import/+merge/187839 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://la

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbeamer-import into lp:openlp

2013-09-28 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-songbeamer-import into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Jonathan Corwin (j-corwin) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-songbeamer-import/+merge/188206 Fix SongBeamer Import

[Openlp-core] [Bug 1234735] [NEW] Outdated downloads on Launchpad

2013-10-03 Thread Samuel Mehrbrodt
Public bug reported: On the start page in Launchpad OpenLP 2.0 is offered as download. We need to either update it to the latest version or remove these downloads so that people don't download an outdated version here. ** Affects: openlp Importance: Undecided Status: New ** Summar

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbeamer-import into lp:openlp

2013-10-06 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-songbeamer-import into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Jonathan Corwin (j-corwin) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-songbeamer-import/+merge/189514 Fix SongBeamer Import

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbeamer-import into lp:openlp

2013-10-22 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-songbeamer-import into lp:openlp. Requested reviews: Jonathan Corwin (j-corwin) Raoul Snyman (raoul-snyman) Phill (phill-ridout) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-songbeamer-import/+merge/192169

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-presentation-loading into lp:openlp

2013-10-22 Thread Samuel Mehrbrodt
I hope that you don't require to have a test even for this small change... -- https://code.launchpad.net/~sam92/openlp/fix-presentation-loading/+merge/192180 Your team OpenLP Core is requested to review the proposed merge of lp:~sam92/openlp/fix-presentation-loading into lp:openlp. _

[Openlp-core] [Merge] lp:~sam92/openlp/fix-presentation-loading into lp:openlp

2013-10-22 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-presentation-loading into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-presentation-loading/+merge/192180 Imported presentations were not displayed - the

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbeamer-import into lp:openlp

2013-10-26 Thread Samuel Mehrbrodt
You mean the Songbeamer test file? That file comes directly from Songbeamer and I chose intentionally a file which is not UTF-8 encoded to verify that Import also works with that encoding. -- https://code.launchpad.net/~sam92/openlp/fix-songbeamer-import/+merge/192169 Your team OpenLP Core is sub

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbeamer-import into lp:openlp

2013-10-26 Thread Samuel Mehrbrodt
Hm I see the same here in Launchpad, but in my editor it is shown correctly (Encoding is UTF-8). I now copied the test_ewimport.py file over and kept the license header, but it still shows up wrong. Any idea what causes this? -- https://code.launchpad.net/~sam92/openlp/fix-songbeamer-import/+me

[Openlp-core] [Merge] lp:~sam92/openlp/fix-songbeamer-import into lp:openlp

2013-10-26 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-songbeamer-import into lp:openlp. Requested reviews: Phill (phill-ridout) Jonathan Corwin (j-corwin) Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-songbeamer-import/+merge/192792

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-presentation-loading into lp:openlp

2013-10-27 Thread Samuel Mehrbrodt
Is this small Test ok? -- https://code.launchpad.net/~sam92/openlp/fix-presentation-loading/+merge/192180 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launc

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-presentation-loading into lp:openlp

2013-10-27 Thread Samuel Mehrbrodt
Cann you have a look again please? -- https://code.launchpad.net/~sam92/openlp/fix-presentation-loading/+merge/192180 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core

[Openlp-core] [Merge] lp:~sam92/openlp/fix-presentation-loading into lp:openlp

2013-11-26 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-presentation-loading into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-presentation-loading/+merge/196725 Imported presentations were not displayed

[Openlp-core] [Merge] lp:~sam92/openlp/fix-presentation-loading into lp:openlp

2013-12-07 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-presentation-loading into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-presentation-loading/+merge/198161 Imported presentations

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-presentation-loading into lp:openlp

2013-12-07 Thread Samuel Mehrbrodt
Please merge as trunk will change again -- https://code.launchpad.net/~sam92/openlp/fix-presentation-loading/+merge/198161 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp

[Openlp-core] [Merge] lp:~sam92/openlp/fix-method-calls into lp:openlp

2014-03-23 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-method-calls into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-method-calls/+merge/212336 -- https://code.launchpad.net/~sam92/openlp/fix-method-calls

[Openlp-core] [Bug 1296574] [NEW] Missing arguments in some event handler functions

2014-03-24 Thread Samuel Mehrbrodt
Public bug reported: I recently upgraded to Ubuntu 14.04 (Python 3.4, Qt 4.8, PyQt 4.10) and now get exceptions on certain actions. For example when sending a song to live, I get the following exception: Traceback (most recent call last): File "/home/samuel/programming/openlp/trunk/openlp/cor

[Openlp-core] [Bug 1296574] Re: Missing arguments in some event handler functions

2014-03-24 Thread Samuel Mehrbrodt
This happens in trunk btw. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1296574 Title: Missing arguments in some event handler functions Status in OpenLP - Worship Presentation Software: New Bu

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/bug-1136278 into lp:openlp

2014-03-24 Thread Samuel Mehrbrodt
I think the problem is that on the one hand we have the migrations in the upgrade.py files which update the DB schema to the latest revision. On the other hand all migrations are also written in the init_schema() method (db.py). So when a new database is created, it is already being created with

[Openlp-core] [Merge] lp:~sam92/openlp/fix-method-calls into lp:openlp

2014-03-24 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-method-calls into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-method-calls/+merge/212414 -- https://code.launchpad.net/~sam92/openlp/fix-method-calls

[Openlp-core] [Bug 1296574] Re: Missing arguments in some event handler functions

2014-03-24 Thread Samuel Mehrbrodt
Hm this happens only when I start OpenLP with "./openlp.py -l debug". Without the debug option I don't have any problems. Any idea why? -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1296574 Title:

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1296574 into lp:openlp

2014-03-26 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1296574 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1296574 in OpenLP: "Missing arguments in some event handler functions" https://bugs.launchpad.net/openlp/+bug/1296574 For more de

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/dvd into lp:openlp

2014-03-27 Thread Samuel Mehrbrodt
Review: Needs Fixing Hi, I tested this again and here are some comments: - Could you prefill the "Media Path" field with the available devices? - When I enter a not available path and click "load disc", I cannot change the path again - When I change the selection in the title combobox, I get the

[Openlp-core] [Merge] lp:~sam92/openlp/author-types into lp:openlp

2014-03-28 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/author-types into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~sam92/openlp/author-types/+merge/213297 Add support for Author Type -- https://code.launchpad.net/~sam92/openlp

Re: [Openlp-core] [Merge] lp:~sam92/openlp/author-types into lp:openlp

2014-03-28 Thread Samuel Mehrbrodt
The basic functionality is working. However, the importers and the tests still need to be updated to handle the new authors relation. But maybe you can already have a look at this code? -- https://code.launchpad.net/~sam92/openlp/author-types/+merge/213297 Your team OpenLP Core is requested to r

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/super-fixes into lp:openlp

2014-03-29 Thread Samuel Mehrbrodt
Review: Approve Great, this fixes the tests for me (Python 3.4) -- https://code.launchpad.net/~raoul-snyman/openlp/super-fixes/+merge/213362 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/super-fixes into lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/dvd into lp:openlp

2014-03-30 Thread Samuel Mehrbrodt
Review: Needs Fixing Thanks for your work, it looks good and I could finally preview a DVD in the dialog. I wonder if you can't use libvlc to detect the optical devices: http://liris.cnrs.fr/advene//download/python-ctypes/doc/vlc.MediaDiscoverer-class.html Some other comments: - Could you show

[Openlp-core] [Merge] lp:~sam92/openlp/author-types into lp:openlp

2014-03-30 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/author-types into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~sam92/openlp/author-types/+merge/213389 Add support for Author Type -- https://code.launchpad.net/~sam92

Re: [Openlp-core] [Merge] lp:~sam92/openlp/author-types into lp:openlp

2014-03-30 Thread Samuel Mehrbrodt
Ok, now everything should work. OpenLyrics Import and Export now handle the author type property. The other importers/exporters just ignore it. -- https://code.launchpad.net/~sam92/openlp/author-types/+merge/213389 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/dvd into lp:openlp

2014-03-30 Thread Samuel Mehrbrodt
Btw, you still have some obsolete tags in your branch, so maybe you can do bzr tag --delete help bzr tag --delete 2.2.2 Else they will again get into trunk when merging. -- https://code.launchpad.net/~tomasgroth/openlp/dvd/+merge/209347 Your team OpenLP Core is requested to review the proposed me

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bibleserver-neue into lp:openlp

2014-03-31 Thread Samuel Mehrbrodt
The only change I did was inserting a new row in the webbibles database with: name: Neue evangelistische Übersetzung abbreviation: NeÜ language_id: 40 (=German) download_source_id: 3 (=Bibleserver) -- https://code.launchpad.net/~sam92/openlp/bibleserver-neue/+merge/213412 Your team OpenLP Core is

[Openlp-core] [Merge] lp:~sam92/openlp/bibleserver-neue into lp:openlp

2014-03-31 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bibleserver-neue into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~sam92/openlp/bibleserver-neue/+merge/213412 -- https://code.launchpad.net/~sam92/openlp/bibleserver-neue

[Openlp-core] [Merge] lp:~sam92/openlp/serviceitem_edittitle into lp:openlp

2014-03-31 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/serviceitem_edittitle into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~sam92/openlp/serviceitem_edittitle/+merge/213545 Got the branch from https://code.launchpad.net

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/dvd into lp:openlp

2014-04-01 Thread Samuel Mehrbrodt
> Since I live in a small country where english isn't an official language and > we don't dub movies I disagree about disabling subtitle selecting. I didn't mean that the option should be removed. Just that no subtitle is selected by default. Maybe we could enhance this: If there is audio availab

Re: [Openlp-core] [Merge] lp:~sam92/openlp/author-types into lp:openlp

2014-04-01 Thread Samuel Mehrbrodt
@Andreas: I can't reproduce that crash. Can you post a traceback? -- https://code.launchpad.net/~sam92/openlp/author-types/+merge/213389 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post t

Re: [Openlp-core] [Merge] lp:~sam92/openlp/serviceitem_edittitle into lp:openlp

2014-04-01 Thread Samuel Mehrbrodt
I made the changes you mentioned and also deleted the tag locally. But I'm not sure if the deletion has made it to Launchpad. -- https://code.launchpad.net/~sam92/openlp/serviceitem_edittitle/+merge/213717 Your team OpenLP Core is subscribed to branch lp:openlp. _

[Openlp-core] [Merge] lp:~sam92/openlp/serviceitem_edittitle into lp:openlp

2014-04-01 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/serviceitem_edittitle into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~sam92/openlp/serviceitem_edittitle/+merge/213717 Got the branch from https

Re: [Openlp-core] [Merge] lp:~sam92/openlp/author-types into lp:openlp

2014-04-01 Thread Samuel Mehrbrodt
> 168 why remove. You can now haw songs without an author! Yes, the string "Author unknown" is being shown in the footer when a song has no author. -- https://code.launchpad.net/~sam92/openlp/author-types/+merge/213721 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~sam92/openlp/author-types into lp:openlp

2014-04-01 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/author-types into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) Andreas Preikschat (googol) For more details, see: https://code.launchpad.net/~sam92/openlp/author-types/+merge/213721 Add support for

Re: [Openlp-core] [Merge] lp:~sam92/openlp/author-types into lp:openlp

2014-04-01 Thread Samuel Mehrbrodt
> We have made a conscious decision previously to always force an author when > adding a song just to encourage folk to obey copyright and credit the author. > (Yes they can work around it, but that is their decision) Ok, I'll revert my changes in this area. -- https://code.launchpad.net/~sam92/o

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/better-tabs into lp:openlp

2014-04-02 Thread Samuel Mehrbrodt
Looks better indeed. I wonder if you can add a hover effect? -- https://code.launchpad.net/~raoul-snyman/openlp/better-tabs/+merge/213747 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/better-tabs into lp:openlp. ___

[Openlp-core] [Merge] lp:~sam92/openlp/author-types into lp:openlp

2014-04-02 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/author-types into lp:openlp. Requested reviews: Andreas Preikschat (googol) Raoul Snyman (raoul-snyman) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~sam92/openlp/author-types/+merge/213857 Add support for

Re: [Openlp-core] [Merge] lp:~sam92/openlp/serviceitem_edittitle into lp:openlp

2014-04-06 Thread Samuel Mehrbrodt
Is there any difference to running the tests locally? -- https://code.launchpad.net/~sam92/openlp/serviceitem_edittitle/+merge/213717 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

Re: [Openlp-core] [Merge] lp:~sam92/openlp/serviceitem_edittitle into lp:openlp

2014-04-07 Thread Samuel Mehrbrodt
[SUCCESS] http://ci.openlp.org/job/Branch-01-Pull/242/ [SUCCESS] http://ci.openlp.org/job/Branch-02-Functional-Tests/203/ [SUCCESS] http://ci.openlp.org/job/Branch-03-Interface-Tests/152/ [SUCCESS] http://ci.openlp.org/job/Branch-04-Windows_Tests/113/ [FAILURE] http://ci.openlp.org/job/Branch-05-Co

[Openlp-core] [Merge] lp:~sam92/openlp/serviceitem_edittitle into lp:openlp

2014-04-07 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/serviceitem_edittitle into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~sam92/openlp/serviceitem_edittitle/+merge/214607 Got the branch from https

Re: [Openlp-core] [Merge] lp:~sam92/openlp/author-types into lp:openlp

2014-04-08 Thread Samuel Mehrbrodt
[SUCCESS] http://ci.openlp.org/job/Branch-01-Pull/249/ [SUCCESS] http://ci.openlp.org/job/Branch-02-Functional-Tests/210/ [SUCCESS] http://ci.openlp.org/job/Branch-03-Interface-Tests/159/ [SUCCESS] http://ci.openlp.org/job/Branch-04-Windows_Tests/120/ [FAILURE] http://ci.openlp.org/job/Branch-05-Co

Re: [Openlp-core] [Merge] lp:~googol/openlp/vlc-new into lp:openlp

2014-04-08 Thread Samuel Mehrbrodt
Review: Approve -- https://code.launchpad.net/~googol/openlp/vlc-new/+merge/213502 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~sam92/openlp/author-types into lp:openlp

2014-04-08 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/author-types into lp:openlp. Requested reviews: Andreas Preikschat (googol) Raoul Snyman (raoul-snyman) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~sam92/openlp/author-types/+merge/214704 Add support for

[Openlp-core] [Merge] lp:~sam92/openlp/verseorder-import into lp:openlp

2014-04-08 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/verseorder-import into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~sam92/openlp/verseorder-import/+merge/214723 Update verse order when verse names change (OpenLyrics Import

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bag_1225763 into lp:openlp

2014-04-08 Thread Samuel Mehrbrodt
I wrote the test and created a new merge proposal: https://code.launchpad.net/~sam92/openlp/bag_1225763/+merge/214771 You can then delete this one. -- https://code.launchpad.net/~marmyshev/openlp/bag_1225763/+merge/186243 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Bug 1225763] Re: Replacing background with video unblank screen even if "Blanked to Theme"

2014-04-08 Thread Samuel Mehrbrodt
** Branch linked: lp:~sam92/openlp/bag_1225763 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1225763 Title: Replacing background with video unblank screen even if "Blanked to Theme" Status in Ope

Re: [Openlp-core] [Merge] lp:~sam92/openlp/verseorder-import into lp:openlp

2014-04-08 Thread Samuel Mehrbrodt
[SUCCESS] http://ci.openlp.org/job/Branch-01-Pull/251/ [SUCCESS] http://ci.openlp.org/job/Branch-02-Functional-Tests/212/ [SUCCESS] http://ci.openlp.org/job/Branch-03-Interface-Tests/161/ [SUCCESS] http://ci.openlp.org/job/Branch-04-Windows_Tests/122/ [FAILURE] http://ci.openlp.org/job/Branch-05-Co

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bag_1225763 into lp:openlp

2014-04-08 Thread Samuel Mehrbrodt
[SUCCESS] http://ci.openlp.org/job/Branch-01-Pull/252/ [SUCCESS] http://ci.openlp.org/job/Branch-02-Functional-Tests/213/ [SUCCESS] http://ci.openlp.org/job/Branch-03-Interface-Tests/162/ [SUCCESS] http://ci.openlp.org/job/Branch-04-Windows_Tests/123/ [FAILURE] http://ci.openlp.org/job/Branch-05-Co

[Openlp-core] [Merge] lp:~sam92/openlp/bag_1225763 into lp:openlp

2014-04-08 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bag_1225763 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1225763 in OpenLP: "Replacing background with video unblank screen even if "Blanked to Theme"" https://bugs.launchpad.net

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bug-1117098 into lp:openlp

2014-04-08 Thread Samuel Mehrbrodt
[SUCCESS] http://ci.openlp.org/job/Branch-01-Pull/254/ [SUCCESS] http://ci.openlp.org/job/Branch-02-Functional-Tests/215/ [SUCCESS] http://ci.openlp.org/job/Branch-03-Interface-Tests/164/ [SUCCESS] http://ci.openlp.org/job/Branch-04-Windows_Tests/125/ [FAILURE] http://ci.openlp.org/job/Branch-05-Co

[Openlp-core] [Bug 1117098] Re: Transparen theme is white on Mac OSX

2014-04-08 Thread Samuel Mehrbrodt
** Branch linked: lp:~sam92/openlp/bug-1117098 ** Summary changed: - Transparen theme is white on Mac OSX + Transparent theme is white on Mac OSX -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1117098

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1117098 into lp:openlp

2014-04-08 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1117098 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1117098 in OpenLP: "Transparent theme is white on Mac OSX" https://bugs.launchpad.net/openlp/+bug/1117098 For more details,

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1117098 into lp:openlp

2014-04-08 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1117098 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1117098 in OpenLP: "Transparent theme is white on Mac OSX" https://bugs.launchpad.net/openlp/+bug/1117098 For more details,

[Openlp-core] [Merge] lp:~sam92/openlp/bag_1225763 into lp:openlp

2014-04-08 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bag_1225763 into lp:openlp. Requested reviews: Tim Bentley (trb143) Related bugs: Bug #1225763 in OpenLP: "Replacing background with video unblank screen even if "Blanked to Theme"" https://bugs.launchpad.net/open

  1   2   3   4   5   6   >