The proposal to merge lp:~suutari-olli/openlp/add-bible-license-field into
lp:openlp has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/add-bible-license-field/+merge/314293
--
Your team OpenLP Core is subscribed to
Review: Approve
--
https://code.launchpad.net/~suutari-olli/openlp/add-bible-license-field/+merge/314293
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~suutari-olli/openlp/add-bible-license-field/+merge/314293
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Azaziah has proposed merging lp:~suutari-olli/openlp/add-bible-license-field
into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
Related bugs:
Bug #1557579 in OpenLP: "Make the song-footer text "Written by" optional"
The proposal to merge lp:~suutari-olli/openlp/add-bible-license-field into
lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/add-bible-license-field/+merge/313501
--
Your team OpenLP Core is subscribed to
Review: Approve
--
https://code.launchpad.net/~suutari-olli/openlp/add-bible-license-field/+merge/313501
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Thanks for the review, I've fixed them.
Diff comments:
>
> === modified file 'openlp/plugins/bibles/forms/bibleimportform.py'
> --- openlp/plugins/bibles/forms/bibleimportform.py2016-08-29 16:11:09
> +
> +++ openlp/plugins/bibles/forms/bibleimportform.py2016-12-04 03:28:05
> +
Azaziah has proposed merging lp:~suutari-olli/openlp/add-bible-license-field
into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #1557579 in OpenLP: "Make the song-footer text "Written by" optional"
The proposal to merge lp:~suutari-olli/openlp/add-bible-license-field into
lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/add-bible-license-field/+merge/312426
--
Your team OpenLP Core is subscribed to
Review: Needs Fixing
A few small fixes and then you should be good to go.
Diff comments:
>
> === modified file 'openlp/plugins/bibles/forms/bibleimportform.py'
> --- openlp/plugins/bibles/forms/bibleimportform.py2016-08-29 16:11:09
> +
> +++
The proposal to merge lp:~suutari-olli/openlp/add-bible-license-field into
lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/add-bible-license-field/+merge/306048
--
Your team OpenLP Core is subscribed to
Azaziah has proposed merging lp:~suutari-olli/openlp/add-bible-license-field
into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Related bugs:
Bug #1557579 in OpenLP: "Make the song-footer text "Written by" optional"
https://bugs.launchpad.net/openlp/+bug/1557579
Bug #1623631 in
> Needs a test just a minor fix is not enough
> Some inline comments.
I've replied to the comments,
will work on a test later.
--
https://code.launchpad.net/~suutari-olli/openlp/add-bible-license-field/+merge/306048
Your team OpenLP Core is subscribed to branch lp:openlp.
Thanks for the comments, I've replied to them.
Diff comments:
>
> === modified file 'openlp/plugins/bibles/forms/editbibleform.py'
> --- openlp/plugins/bibles/forms/editbibleform.py 2016-05-21 08:31:24
> +
> +++ openlp/plugins/bibles/forms/editbibleform.py 2016-09-18 20:29:10
>
Review: Needs Fixing
Needs a test just a minor fix is not enough
Some inline comments.
Diff comments:
>
> === modified file 'openlp/plugins/bibles/forms/editbibleform.py'
> --- openlp/plugins/bibles/forms/editbibleform.py 2016-05-21 08:31:24
> +
> +++
Azaziah has proposed merging lp:~suutari-olli/openlp/add-bible-license-field
into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1557579 in OpenLP: "Make the song-footer text "Written by" optional"
https://bugs.launchpad.net/openlp/+bug/1557579
Bug #1623631 in
16 matches
Mail list logo