[Openlp-core] [Merge] lp:~bastian-germann/openlp/unexport-tests into lp:openlp
The proposal to merge lp:~bastian-germann/openlp/unexport-tests into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~bastian-germann/openlp/unexport-tests/+merge/357914 -- Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/unexport-tests into lp:openlp
Review: Approve -- https://code.launchpad.net/~bastian-germann/openlp/unexport-tests/+merge/357914 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/unexport-tests into lp:openlp
Review: Approve -- https://code.launchpad.net/~bastian-germann/openlp/unexport-tests/+merge/357914 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~bastian-germann/openlp/unexport-tests into lp:openlp
The proposal to merge lp:~bastian-germann/openlp/unexport-tests into lp:openlp has been updated. Description changed to: Do not export any tests* module, but include them only in sdist For more details, see: https://code.launchpad.net/~bastian-germann/openlp/unexport-tests/+merge/357914 -- Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~bastian-germann/openlp/unexport-tests into lp:openlp
Bastian Germann has proposed merging lp:~bastian-germann/openlp/unexport-tests into lp:openlp. Commit message: Do not export any tests* module, but include them only in sdist Requested reviews: Tomas Groth (tomasgroth) For more details, see: https://code.launchpad.net/~bastian-germann/openlp/unexport-tests/+merge/357914 A change to CI or packaging may be required if something depends on the tests/* modules to be available on an installation. -- Your team OpenLP Core is subscribed to branch lp:openlp. === modified file 'MANIFEST.in' --- MANIFEST.in 2018-08-27 17:48:47 + +++ MANIFEST.in 2018-10-28 11:43:31 + @@ -11,7 +11,7 @@ recursive-include documentation * recursive-include resources * recursive-include scripts * -recursive-include tests/resources * +recursive-include tests * include copyright.txt include LICENSE include README.txt === modified file 'setup.py' --- setup.py 2018-10-16 20:07:00 + +++ setup.py 2018-10-28 11:43:31 + @@ -188,7 +188,7 @@ author_email='raoulsny...@openlp.org', url='https://openlp.org/', license='GNU General Public License', -packages=find_packages(exclude=['ez_setup', 'tests']), +packages=find_packages(exclude=['ez_setup', 'tests*']), py_modules=['run_openlp'], include_package_data=True, zip_safe=False, ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~bastian-germann/openlp/unexport-tests into lp:openlp
The proposal to merge lp:~bastian-germann/openlp/unexport-tests into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~bastian-germann/openlp/unexport-tests/+merge/357912 -- Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/unexport-tests into lp:openlp
Review: Approve >From a packaging perspective this changes makes good sense, but as you state >this means the CI must be updated. -- https://code.launchpad.net/~bastian-germann/openlp/unexport-tests/+merge/357912 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~bastian-germann/openlp/unexport-tests into lp:openlp
Bastian Germann has proposed merging lp:~bastian-germann/openlp/unexport-tests into lp:openlp. Commit message: Do not export any tests* module Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~bastian-germann/openlp/unexport-tests/+merge/357912 A change to CI or packaging may be required if something depends on the tests/* modules to be available on an installation. -- Your team OpenLP Core is requested to review the proposed merge of lp:~bastian-germann/openlp/unexport-tests into lp:openlp. === modified file 'setup.py' --- setup.py 2018-10-16 20:07:00 + +++ setup.py 2018-10-27 21:49:07 + @@ -188,7 +188,7 @@ author_email='raoulsny...@openlp.org', url='https://openlp.org/', license='GNU General Public License', -packages=find_packages(exclude=['ez_setup', 'tests']), +packages=find_packages(exclude=['ez_setup', 'tests*']), py_modules=['run_openlp'], include_package_data=True, zip_safe=False, ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
