The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
Review: Approve
Looks good! Thanks for the extra effort!
--
https://code.launchpad.net/~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick/+merge/306037
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
Azaziah has proposed merging
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
Phill (phill-ridout)
For more details, see:
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
It was my initial thought but I failed to set up the test within a reasonable
time.
Iv'e managed to increase the coverage by your instructions, thank you.
> your test 'test_on_lock_button_toggled_search_tab' is only really testing the
> last two lines of on_lock_button_toggled
>
> As, you've
your test 'test_on_lock_button_toggled_search_tab' is only really testing the
last two lines of on_lock_button_toggled
As, you've gone to all the trouble of setting this test up it would be easy to
test the if condition which sets the appropriate icon. In your current test add:
# GIVEN:
Azaziah has proposed merging
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
Phill (phill-ridout)
For more details, see:
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
Review: Needs Fixing
on_lock_button_toggled is such a small method, any changes of tests for that?
Also can you include the parameters in the doc string please. (See inline
comments)
Diff comments:
>
> === modified file 'openlp/plugins/bibles/lib/mediaitem.py'
> ---
Azaziah has proposed merging
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Work in progress => Superseded
For more details, see:
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Needs review => Work in progress
For more details, see:
Review: Approve
--
https://code.launchpad.net/~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick/+merge/305302
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Azaziah has proposed merging
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
> > Please read the unittest.mock documentation, it has lots of examples on how
> to
> > use it and the best way to do it.
> >
> > https://docs.python.org/3/library/unittest.mock.html
> >
> > Check my comments below for the best way to use the library.
>
> We tried to change this test to use
> Please read the unittest.mock documentation, it has lots of examples on how to
> use it and the best way to do it.
>
> https://docs.python.org/3/library/unittest.mock.html
>
> Check my comments below for the best way to use the library.
We tried to change this test to use @patch with phill,
Review: Needs Fixing
Please read the unittest.mock documentation, it has lots of examples on how to
use it and the best way to do it.
https://docs.python.org/3/library/unittest.mock.html
Check my comments below for the best way to use the library.
Diff comments:
>
> === modified file
Azaziah has proposed merging
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
For more details, see:
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
Azaziah has proposed merging
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
For more details, see:
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Description changed to:
This branch fixes the issue where the new Clear Bible search results and
Lock button give focus to Text search if it is used in
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Work in progress => Superseded
For more details, see:
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Needs review => Work in progress
For more details, see:
Azaziah has proposed merging
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
Review: Needs Fixing
Tests? The rest looks good though
--
https://code.launchpad.net/~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick/+merge/302891
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing
Azaziah has proposed merging
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
Review: Needs Fixing
Please see my comments.
Diff comments:
> === modified file 'openlp/plugins/bibles/lib/mediaitem.py'
> --- openlp/plugins/bibles/lib/mediaitem.py2016-08-10 18:31:33 +
> +++ openlp/plugins/bibles/lib/mediaitem.py2016-08-10 21:34:12 +
> @@ -254,7 +254,7 @@
>
Review: Needs Fixing
Looks OK but needs tests!
--
https://code.launchpad.net/~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick/+merge/302597
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Azaziah has proposed merging
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
34 matches
Mail list logo
