Review: Approve
--
https://code.launchpad.net/~alisonken1/openlp/pjlink2-p/+merge/337519
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~alisonken1/openlp/pjlink2-p/+merge/337519
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Fixing
Just the one request, everything else looks spiffy.
Diff comments:
>
> === modified file 'openlp/core/common/__init__.py'
> --- openlp/core/common/__init__.py2017-12-29 09:15:48 +
> +++ openlp/core/common/__init__.py2018-02-11 11:56:38 +
> @@ -51,6 +52,27
Review: Approve
Looks ok and a good refactor.
Not 100% sure about the inline code for the Network lookup.
Let TGC or Superfly comment on that.
--
https://code.launchpad.net/~alisonken1/openlp/pjlink2-p/+merge/337511
Your team OpenLP Core is subscribed to branch lp:openlp.
>> === modified file 'openlp/.version'
>> --- openlp/.version 2016-12-12 22:16:23 +
>> +++ openlp/.version 2018-02-10 09:09:49 +
>> @@ -1 +1 @@
>> -2.5.0
>> +2.5-bzr2809
>
> why?
huh?
Didn't know that happened. Must have been when I was twiddling with
pip install trying something out.
Review: Needs Fixing
One question and a request to refactor.
Diff comments:
> === modified file 'openlp/.version'
> --- openlp/.version 2016-12-12 22:16:23 +
> +++ openlp/.version 2018-02-10 09:09:49 +
> @@ -1 +1 @@
> -2.5.0
> +2.5-bzr2809
why?
> \ No newline at end of file
>
>
6 matches
Mail list logo
