Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/qcollator into lp:openlp

2018-10-27 Thread Raoul Snyman
Review: Approve I just ran the tests, everything passed, I'm happy. -- https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357907 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/qcollator into lp:openlp

2018-10-27 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357907 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/qcollator into lp:openlp

2018-10-26 Thread Tim Bentley
Review: Needs Fixing Sorry but conflicts with the dependancy merge which was added first. -- https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357851 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/qcollator into lp:openlp

2018-10-26 Thread Raoul Snyman
Review: Approve I just checked, and the macOS tests also passed, so I'm good to go with this. Diff comments: > > === modified file 'scripts/check_dependencies.py' > --- scripts/check_dependencies.py 2018-10-12 22:11:04 + > +++ scripts/check_dependencies.py 2018-10-25 21:32:23 +

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/qcollator into lp:openlp

2018-10-25 Thread Raoul Snyman
^^ ignore those. it's failing on a test that should be running -- https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357851 Your team OpenLP Core is requested to review the proposed merge of lp:~bastian-germann/openlp/qcollator into lp:openlp.