Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328825 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

Review: Approve Looks OK to me. -- https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328825 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

We already have a custom file dialog, why not extend that one rather than write a completely new class? -- https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328616 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

Review: Needs Fixing Trunk is fine Advanced Tab Traceback (most recent call last): File "/home/tim/Projects/OpenLP/openlp/pathlib2/openlp/core/ui/mainwindow.py", line 810, in on_settings_configure_iem_clicked self.settings_form.exec() File