This is an automated email from Gerrit.

Spencer Oliver (s...@spen-soft.co.uk) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/368

-- gerrit

commit f282ea9d05689d842afbef326bf065e3203ea59c
Author: Spencer Oliver <s...@spen-soft.co.uk>
Date:   Thu Jan 12 14:15:28 2012 +0000

    stlink: correctly signal stlink_interface_open failure
    
    give the user a error msg on open failure.
    
    Change-Id: If4a57bac7f3e1746c2a05c7a96747a38da188041
    Signed-off-by: Spencer Oliver <s...@spen-soft.co.uk>

diff --git a/src/jtag/drivers/stlink_usb.c b/src/jtag/drivers/stlink_usb.c
index aaf55b0..3b262f9 100644
--- a/src/jtag/drivers/stlink_usb.c
+++ b/src/jtag/drivers/stlink_usb.c
@@ -609,7 +609,7 @@ int stlink_usb_open(struct stlink_interface_param_s *param, 
void **fd)
                  param->pid);
 
        if (jtag_libusb_open(vids, pids, &h->fd) != ERROR_OK) {
-               LOG_DEBUG("stlink_open_usb: open failed");
+               LOG_ERROR("stlink_open_usb: open failed");
                return ERROR_FAIL;
        }
 
diff --git a/src/jtag/stlink/stlink_transport.c 
b/src/jtag/stlink/stlink_transport.c
index c073ffe..14e59ec 100644
--- a/src/jtag/stlink/stlink_transport.c
+++ b/src/jtag/stlink/stlink_transport.c
@@ -142,10 +142,11 @@ static int stlink_transport_init(struct command_context 
*cmd_ctx)
        if (!t) {
                LOG_ERROR("stlink_transport_init: no current target");
                return ERROR_FAIL;
-
        }
 
-       stlink_interface_open();
+       int retval = stlink_interface_open();
+       if (retval != ERROR_OK)
+               return retval;
 
        return stlink_interface_init_target(t);
 }

-- 

------------------------------------------------------------------------------
RSA(R) Conference 2012
Mar 27 - Feb 2
Save $400 by Jan. 27
Register now!
http://p.sf.net/sfu/rsa-sfdev2dev2
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to