Re: [OpenOCD-devel] Change review

2012-03-14 Thread Øyvind Harboe
On Wed, Mar 14, 2012 at 3:38 PM, Chris Morgan wrote: > Oh ok. I'm not in any rush, just saw a relatively high patch load > coming through and didn't want to get missed and dropped. np. One of the things that is no longer a problem with Gerrit is to give long and healthy cool-off periods without

Re: [OpenOCD-devel] Change review

2012-03-14 Thread Chris Morgan
Oh ok. I'm not in any rush, just saw a relatively high patch load coming through and didn't want to get missed and dropped. Chris On Wed, Mar 14, 2012 at 10:34 AM, Øyvind Harboe wrote: > Hi Chris, > > Spencer reviewed it already and it looked good to him. > > Minimally we want to let patches s

Re: [OpenOCD-devel] Change review

2012-03-14 Thread Øyvind Harboe
Hi Chris, Spencer reviewed it already and it looked good to him. Minimally we want to let patches sit around for a week(end) or two before we submit them to master so that people can get a chance to review it. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-

[OpenOCD-devel] Change review

2012-03-14 Thread Chris Morgan
Hello. Is there something special I should be doing to get a patch reviewed? I fixed an issue that I discussed in detail with Freddie last month and pushed the patch to Gerrit but its been sitting on there for a few days now with only a single person that reviewed it. Would hate to have it get sta