[Openocd-development] [RFC, PATCH 0/2] ft2232: some cleanup

2010-06-17 Thread Marc Pignat
Hi all! Here is some cleanup for the ft2232 code, please let me know what you think about it. Best Regards Marc ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

[Openocd-development] [RFC, PATCH 1/2] ft2232: cleanup ft2232_write

2010-06-17 Thread Marc Pignat
* Include the size check into ft2232_write, so calling it is simpler. * Use sizeof(buffer) when possible --- src/jtag/drivers/ft2232.c | 85 +++-- 1 files changed, 43 insertions(+), 42 deletions(-) diff --git a/src/jtag/drivers/ft2232.c

[Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-06-17 Thread Marc Pignat
--- src/jtag/drivers/ft2232.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/jtag/drivers/ft2232.c b/src/jtag/drivers/ft2232.c index bc8463e..9d40b1c 100644 --- a/src/jtag/drivers/ft2232.c +++ b/src/jtag/drivers/ft2232.c @@ -714,23 +714,24 @@

Re: [Openocd-development] -Wshadow is now default

2010-06-17 Thread Øyvind Harboe
I just built the master branch w/Cygwin and no warnings/errors. There may be warnings/errors with certain interfaces and operating systems, but I'll leave that to the community to submit patches. -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00

Re: [Openocd-development] -Wshadow is now default

2010-06-17 Thread Xiaofan Chen
On Thu, Jun 17, 2010 at 9:41 PM, Øyvind Harboe oyvind.har...@zylin.com wrote: I just built the master branch w/Cygwin and no warnings/errors. There may be warnings/errors with certain interfaces and operating systems, but I'll leave that to the community to submit patches. Fair enough. Just

Re: [Openocd-development] -Wshadow is now default

2010-06-17 Thread Xiaofan Chen
On Thu, Jun 17, 2010 at 9:47 PM, Xiaofan Chen xiaof...@gmail.com wrote: There may be warnings/errors with certain interfaces and operating systems, but I'll leave that to the community to submit patches. Fair enough. Just FYI, my config is like this. ../openocd/configure

Re: [Openocd-development] -Wshadow is now default

2010-06-17 Thread Antonio Borneo
Two more patches in attachment. after ./bootstrap, I configure with: ./configure --enable-maintainer-mode --enable-parport --enable-parport-ppdev --enable-dummy --enable-jlink --enable-vsllink Is there any already assessed set of flags for ./configure to enable all the features in OpenOCD? I

Re: [Openocd-development] -Wshadow is now default

2010-06-17 Thread Øyvind Harboe
Merged thanks. -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer ___ Openocd-development mailing list

Re: [Openocd-development] -Wshadow is now default

2010-06-17 Thread Freddie Chopin
Hi! here are some more fixes without which OpenOCD fails to build. The fixes are trivial. I don't know if the files will be encoded right... I've created those patches in Linux (OpenSUSE) with just git format-patch origin... There is something very wrong with the subject lines of those

Re: [Openocd-development] -Wshadow is now default

2010-06-17 Thread Freddie Chopin
On 2010-06-17 20:56, Freddie Chopin wrote: I don't know if the files will be encoded right... I've created those patches in Linux (OpenSUSE) with just git format-patch origin... There is something very wrong with the subject lines of those patches... /; Here is the output of git log which

Re: [Openocd-development] -Wshadow is now default

2010-06-17 Thread Øyvind Harboe
Your patch sequence was perfectly formed. Merged. Tip: next time, please use the following format for your commit comment: topic: short subject blank line longer explanation This works better with some git tools that create summaries. I modified your commit comments before merging. --

Re: [Openocd-development] -Wshadow is now default

2010-06-17 Thread Xiaofan Chen
On Thu, Jun 17, 2010 at 10:25 PM, Xiaofan Chen xiaof...@gmail.com wrote: If I cross build under Linux and only enables J-Link, there is only a few problems. The latest git is fine under Cross build under Ubuntu. Thanks for the fast fixes. ../openocd/configure --build=i686-pc-linux-gnu

Re: [Openocd-development] [PATCH] don't print Jim stacktrace

2010-06-17 Thread Andreas Fritiofson
On Thu, Jun 17, 2010 at 7:24 AM, Øyvind Harboe oyvind.har...@zylin.com wrote: On Thu, Jun 17, 2010 at 2:05 AM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: On Thu, Jun 17, 2010 at 12:30 AM, Øyvind Harboe oyvind.har...@zylin.com wrote: On Wed, Jun 16, 2010 at 11:40 PM, Andreas

Re: [Openocd-development] Unused symbols; Global vs Static

2010-06-17 Thread Antonio Borneo
Other two patches in this thread, this time for the JIM helper src/helper/jim.c . - 0001... makes static all (but one) functions that are only used locally - 0002... removes 3 functions that are never used. In git comment there is the name of functions for future reference. Patches can be merged,

Re: [Openocd-development] Unused symbols; Global vs Static

2010-06-17 Thread Øyvind Harboe
Merged. Thanks! -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer ___ Openocd-development mailing list